Skip to content

add: mux overview - #270

Merged
p-shahi merged 10 commits into
masterfrom
mux/overview
Feb 7, 2023
Merged

add: mux overview#270
p-shahi merged 10 commits into
masterfrom
mux/overview

Conversation

@salmad3

@salmad3salmad3 commented Dec 7, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Context

Notes

  • Section this document lives under will become populated with corresponding PRs

Latest preview

Please view the latest Fleek preview here.

@salmad3salmad3 added the ready for review PR is ready for review label Dec 7, 2022
marten-seemann
marten-seemann reviewed Dec 7, 2022
View reviewed changes
Comment threadcontent/concepts/multiplex/overview.md Outdated
Comment threadcontent/concepts/multiplex/overview.md Outdated
Comment threadcontent/concepts/multiplex/overview.md Outdated
marten-seemann
marten-seemann reviewed Dec 12, 2022
View reviewed changes
Comment threadcontent/concepts/multiplex/overview.md Outdated
Comment threadcontent/concepts/multiplex/overview.md Outdated
Comment threadcontent/concepts/multiplex/overview.md Outdated
Comment threadcontent/concepts/multiplex/overview.md Outdated
salmad3and others added 2 commits December 12, 2022 16:59
@salmad3@marten-seemann
Apply suggestions from code review
1a28c0b
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
@salmad3
incorporate pr feedback
a030a8b
@salmad3

salmad3 commented Dec 19, 2022

Copy link
Copy Markdown
ContributorAuthor

@marten-seemann can be checked again.

@salmad3salmad3 mentioned this pull request Jan 11, 2023
Merged
@salmad3
salmad3 requested a review from p-shahiJanuary 11, 2023 05:08
marten-seemann
marten-seemann reviewed Jan 11, 2023
View reviewed changes
Comment threadcontent/concepts/multiplex/overview.md Outdated
Comment threadcontent/concepts/multiplex/overview.md Outdated
Comment threadcontent/concepts/multiplex/overview.md Outdated
Comment threadcontent/concepts/multiplex/overview.md Outdated
Comment threadcontent/concepts/multiplex/overview.md Outdated
Comment threadcontent/concepts/multiplex/overview.md Outdated
@salmad3salmad3 added the P1 High label Jan 26, 2023
marten-seemann
marten-seemann reviewed Jan 31, 2023
View reviewed changes
Comment threadcontent/concepts/multiplex/overview.md Outdated
Comment threadcontent/concepts/multiplex/overview.md Outdated
Comment threadcontent/concepts/multiplex/overview.md Outdated
Comment threadcontent/concepts/multiplex/overview.md Outdated
Comment threadcontent/concepts/multiplex/overview.md Outdated
Comment threadcontent/concepts/multiplex/overview.md Outdated
Comment threadcontent/concepts/multiplex/overview.md Outdated
Comment threadcontent/concepts/multiplex/overview.md Outdated
Comment threadcontent/concepts/multiplex/overview.md Outdated
Comment threadcontent/concepts/multiplex/overview.md Outdated
@salmad3salmad3 added change request PR requires changes. and removed ready for review PR is ready for review labels Jan 31, 2023
salmad3and others added 2 commits February 1, 2023 09:06
@salmad3@marten-seemann
Apply suggestions from code review
6c32fe5
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
@salmad3
address feedback + edits
1461ad2
p-shahi
p-shahi reviewed Feb 2, 2023
View reviewed changes
Comment threadcontent/concepts/multiplex/overview.md Outdated
Comment threadcontent/concepts/multiplex/overview.md Outdated
Comment threadcontent/concepts/multiplex/overview.md Outdated
Comment threadcontent/concepts/multiplex/overview.md Outdated
Comment threadcontent/concepts/multiplex/overview.md Outdated
@salmad3

salmad3 commented Feb 3, 2023

Copy link
Copy Markdown
ContributorAuthor

Thanks @marten-seemann@p-shahi!

Decided to not try to incorporate the older material that was available, revised the doc and incorporated the suggestions.

@salmad3salmad3 added ready for review PR is ready for review and removed change request PR requires changes. labels Feb 3, 2023
p-shahi
p-shahi reviewed Feb 3, 2023
View reviewed changes
Comment threadcontent/concepts/multiplex/overview.md Outdated
Comment threadcontent/concepts/multiplex/overview.md Outdated
Comment threadcontent/concepts/multiplex/overview.md Outdated
Comment threadcontent/concepts/multiplex/overview.md Outdated
Comment threadcontent/concepts/multiplex/overview.md Outdated
Comment threadcontent/concepts/multiplex/overview.md Outdated
@p-shahi

p-shahi commented Feb 7, 2023

Copy link
Copy Markdown
Member

@marten-seemann Can you take a look, this one looks ready to merge from my end

marten-seemann
marten-seemann approved these changes Feb 7, 2023
View reviewed changes

@marten-seemannmarten-seemann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like there's a lot one could do to improve this text, but I'm fine with merging this as is.

@p-shahip-shahi mentioned this pull request Feb 7, 2023
Open
@p-shahi
p-shahi merged commit 48bc3f2 into masterFeb 7, 2023
@p-shahi
p-shahi deleted the mux/overview branch February 7, 2023 03:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@p-shahip-shahip-shahi left review comments
@marten-seemannmarten-seemannmarten-seemann approved these changes

Assignees

No one assigned

Labels

P1Highready for reviewPR is ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve stream multiplexing overview

3 participants

@salmad3@p-shahi@marten-seemann