Uh oh!
There was an error while loading. Please reload this page.
WIP: Backport KVStore changes - #159
Closed
tnull wants to merge 3 commits into
Closed
Conversation
tnull
marked this pull request as draft
August 22, 2023 10:30
.. as we don't require all that logic anymore now that we don't return an `FilesystemWriter` anymore etc.
This will be mandatory on the upstreamed trait anyways and is useful to make it easiert to compare returned values.
tnullforce-pushed
the
2023-08-kvstore-updates
branch
from
August 24, 2023 09:25
a695c1f to
e1d081cCompare.. which asserts that all `KVStore` implementations operatate synchronously, i.e., yield identical results given the same inputs.
tnullforce-pushed
the
2023-08-kvstore-updates
branch
from
August 24, 2023 18:03
e1d081c to
76d2f03Comparetnull
commented
Sep 11, 2023
CollaboratorAuthor
Closing this as the changes will need to happen as part of #151. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR encompasses fixes and minor changes that were raised during upstreaming the
KVStore.