Uh oh!
There was an error while loading. Please reload this page.
Add VSS Store CI Integ Test - #161
Conversation
tnull
commented
Sep 11, 2023
Thanks! Do we see a way to integrate it more closely? In particular, we should run |
There was a problem hiding this comment.
Note that we'll want to run the usual tests against this backend, so while it might be a bit cleaner to have a separate CI worflow, we'll probably need to do this setup as part of our 'regular' CI run, possibly as part of a vss feature flag for now.
There was a problem hiding this comment.
I think we can do this setup in separate workflow and run all tests against it.
I didn't want to bloat single ci workflow so much and wanted to maintain some separation of concerns regarding vss-integration in particular .
G8XSU
commented
Sep 15, 2023
Yes, once we have a public api to build with vss, will add that. |
tnull
commented
Sep 18, 2023
There is no reason to wait for the public API, as we can just use |
G8XSU
commented
Sep 26, 2023
Depends on lightningdevkit/vss-server#25 |
tnull
commented
Nov 7, 2023
This needs a rebase now that #158 landed :) |
G8XSU
commented
Nov 8, 2023
Rebased on #158 |
tnull
commented
Nov 9, 2023
The integration test fails due to: I.e., on |
G8XSU
commented
Nov 14, 2023
I think this will be fixed once latest vss-client is published(since it depends on some changes in that), i will verify it once. |
G8XSU
commented
Dec 1, 2023
Depends on #213 for now. |
tnull
commented
Dec 4, 2023
In this, we spin up a local vss-server instance using tomcat, and run vss related integration tests in ldk-node.
G8XSU
commented
Dec 12, 2023
@tnull rebased and that error is fixed now. |
tnull
left a comment
There was a problem hiding this comment.
LGTM.
As discussed elsewhere, I'd eventually like to collect all the integration tests under ./tests, but that can happen in the future.
Depends on #158