Skip to content

UniFFI bindings - #25

Merged
tnull merged 10 commits into
lightningdevkit:mainfrom
tnull:2022-09-start-uniffi
May 9, 2023
Merged

UniFFI bindings#25
tnull merged 10 commits into
lightningdevkit:mainfrom
tnull:2022-09-start-uniffi

Conversation

@tnull

@tnulltnull commented Oct 20, 2022•
edited
Loading

Copy link
Copy Markdown
Collaborator

Based on #9, #10, #11,#13,#52.

This PR provides the starting point for UniFFI bindings. Depending on how much code changes are required for the binding generation, we may want to move this to a separate repository.

@tnull
tnullforce-pushed the 2022-09-start-uniffi branch 7 times, most recently from 933cc5c to 7eb0707CompareOctober 21, 2022 09:42
@tnulltnull mentioned this pull request Nov 15, 2022
Closed
@tnull
tnullforce-pushed the 2022-09-start-uniffi branch 2 times, most recently from 78e2f18 to f4df595CompareDecember 13, 2022 13:14
@tnull

tnull commented Dec 13, 2022

Copy link
Copy Markdown
CollaboratorAuthor

Rebased on current state of #11.

@tnull
tnullforce-pushed the 2022-09-start-uniffi branch from f4df595 to 45c7724CompareDecember 13, 2022 14:00
@tnulltnull mentioned this pull request Dec 13, 2022
Merged
@tnull
tnullforce-pushed the 2022-09-start-uniffi branch 3 times, most recently from b7622d9 to 4b449b4CompareDecember 15, 2022 11:37
@tnull

tnull commented Dec 15, 2022

Copy link
Copy Markdown
CollaboratorAuthor

Rebased on #11.

@tnull
tnullforce-pushed the 2022-09-start-uniffi branch 5 times, most recently from a364bb0 to 2d9fe37CompareDecember 19, 2022 11:00
@tnull
tnullforce-pushed the 2022-09-start-uniffi branch 3 times, most recently from 8481816 to 1b70183CompareJanuary 11, 2023 12:54
@thunderbiscuitthunderbiscuit mentioned this pull request Jan 24, 2023
Closed
@tnull
tnullforce-pushed the 2022-09-start-uniffi branch 2 times, most recently from 32d3675 to 4fcfebcCompareJanuary 27, 2023 18:59
@tnulltnull mentioned this pull request Jan 27, 2023
Closed
@tnull
tnullforce-pushed the 2022-09-start-uniffi branch from 7921080 to 40c5031CompareJanuary 27, 2023 20:50
@tnull
tnullforce-pushed the 2022-09-start-uniffi branch 3 times, most recently from 38aac93 to c04f28fCompareMarch 31, 2023 08:32
This was referenced Apr 4, 2023
Merged
Merged
@tnull
tnullforce-pushed the 2022-09-start-uniffi branch from c04f28f to 776d9eeCompareApril 7, 2023 08:26
@tnull
tnullforce-pushed the 2022-09-start-uniffi branch 3 times, most recently from bb3375f to 1d5e59bCompareApril 21, 2023 13:40
@tnulltnull mentioned this pull request Apr 21, 2023
Merged
@tnull

tnull commented Apr 25, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Squashed fixups and rebased. Dropped part of the last WIP commit, as this is getting too big anyways.

We should land this and then add CI bindings testing in a follow-up.

@tnull

tnull commented Apr 26, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Rebased on main.

jkczyz
jkczyz reviewed May 2, 2023
View reviewed changes

@jkczyzjkczyz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the "bindings generation support" commits generated from somewhere?

Comment threadbindings/ldk_node.udl
Comment threadsrc/lib.rs
Comment threadsrc/test/functional_tests.rs Outdated
Comment threadsrc/types.rs
Comment threadsrc/types.rs Outdated
Comment threadsrc/io_utils.rs Outdated
Comment thread.gitignore Outdated
jkczyz
jkczyz reviewed May 3, 2023
View reviewed changes
Comment threadbindings/ldk_node.udl
Comment threadsrc/types.rs
Comment threadsrc/types.rs Outdated
Comment threadbindings/kotlin/ldk-node-android/lib/build.gradle.kts Outdated
Comment thread...in/ldk-node-android/lib/src/androidTest/kotlin/org/lightningdevkit/ldknode/AndroidLibTest.kt Outdated
val address2 = node2.newFundingAddress()
println("Funding address 2: $address2")

//sendToAddress(address1, 100000u)

@jkczyzjkczyzMay 3, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why this is commented out?

@tnulltnullMay 4, 2023•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, as the way I'm issuing commands to the bitcoind regtest node in the JVM version doesn't work on Android (no bitcoin-cli available there, and not even the Runtime JVM object I use to run the commands) . So it's still WIP how to actually integrate the Android library tests with a) any bitcoind/electrsd backend b) run them in the Android device simulator and c) run all of it in CI.

All of it will be a bunch of work that I don't expect to land in this PR, very likely not even for 0.1. I now dropped the commented-out parts and would defer any further changes to a dedicated follow-up.

Comment threadbindings/kotlin/ldk-node-jvm/lib/src/test/kotlin/org/lightningdevkit/ldknode/LibraryTest.kt Outdated
Comment threadsrc/error.rs Outdated
Comment threadsrc/lib.rs
jkczyz
jkczyz reviewed May 8, 2023
View reviewed changes

@jkczyzjkczyz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please squash fix-ups.

@tnull

tnull commented May 8, 2023

Copy link
Copy Markdown
CollaboratorAuthor

LGTM. Please squash fix-ups.

Squashed without further changes.

This was referenced May 9, 2023
Merged
Closed
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz approved these changes
+1 more reviewer
@jurvisjurvisjurvis left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.1

Development

Successfully merging this pull request may close these issues.

4 participants

@tnull@jkczyz@jurvis@notmandatory