Skip to content

Expose list peers and channels - #56

Merged
tnull merged 1 commit into
lightningdevkit:mainfrom
jurvis:jurvis/2022-09-start-uniffi/expose-list-peers-and-channels
May 12, 2023
Merged

Expose list peers and channels#56
tnull merged 1 commit into
lightningdevkit:mainfrom
jurvis:jurvis/2022-09-start-uniffi/expose-list-peers-and-channels

Conversation

@jurvis

@jurvisjurvis commented Mar 31, 2023•
edited by tnull
Loading

Copy link
Copy Markdown
Contributor

Based on #25.

Transferred from tnull#3

@jurvisjurvis mentioned this pull request Mar 31, 2023
Closed
tnull
tnull reviewed Apr 3, 2023
View reviewed changes
Comment threadsrc/test/functional_tests.rs Outdated
Comment threadsrc/types.rs Outdated
Comment threadsrc/types.rs Outdated
Comment threadsrc/types.rs Outdated
Comment threadsrc/types.rs Outdated
Comment threadsrc/types.rs Outdated
Comment threadsrc/types.rs Outdated
Comment threadsrc/types.rs Outdated
Comment threadsrc/types.rs Outdated
Comment threadsrc/types.rs
@tnulltnull mentioned this pull request Apr 4, 2023
Closed
47 tasks
tnull
tnull reviewed Apr 5, 2023
View reviewed changes
Comment threadsrc/error.rs Outdated
Comment threadsrc/lib.rs Outdated
Comment threadsrc/lib.rs Outdated
Comment threadsrc/lib.rs
pub fn list_peers(&self) -> Vec<PeerDetails> {
let active_connected_peers: Vec<PublicKey> =
self.peer_manager.get_peer_node_ids().iter().map(|p| p.0).collect();
self.peer_store

@tnulltnullApr 5, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mh, I wonder if it would be nice to have a is_persisted: bool field on PeerDetails so that this also lists connected-but-not-stored peers. I think it should be possible to get all necessary information from get_peer_node_ids. Feel free to add this here, otherwise I'll add a tracking issue, since it might be easier after our eventual transition to NetAddress.

@jurvisjurvisApr 6, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah... I just took a stab at it and it looks like it may be easier if we both had PeerInfo and the tuple returns by get_peer_node_ids return a consistent type for address.

@tnulltnullApr 7, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, we'll see what lands first, feel free to leave as is currently.

@tnulltnullApr 7, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now tracking here: #62

@tnulltnullMay 3, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jurvis I think this will be possible now as soon as #85 lands.

Comment threadsrc/types.rs Outdated
Comment threadsrc/types.rs Outdated
Comment threadsrc/types.rs Outdated
/// Information about the channel's funding transaction output. `None `unless a funding
/// transaction has been successfully negotiated with the channel's counterparty.
pub funding_txo: Option<OutPoint>,
/// Position of the funding transaction on-chain. `None` unless the funding transaction has been

@tnulltnullApr 5, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mh, yeah, good question after all. Actually I'd like to avoid exposing the complexity of SCID aliases to the user, but I'm not sure we can now that LSP spec might depend on them. Although, maybe we should leave them out for now after all and really just add them when integrating the LSP client.

Comment threadsrc/types.rs Outdated
Comment threadsrc/types.rs Outdated
Comment threadsrc/types.rs Outdated
tnull
tnull reviewed Apr 5, 2023
View reviewed changes
Comment threadsrc/lib.rs Outdated
@tnulltnull mentioned this pull request Apr 7, 2023
Closed
@danielnordhdanielnordh mentioned this pull request Apr 21, 2023
Closed
11 tasks
@jurvis
jurvisforce-pushed the jurvis/2022-09-start-uniffi/expose-list-peers-and-channels branch 2 times, most recently from 5506f23 to 49f7f59CompareApril 22, 2023 00:43
@jurvis

jurvis commented Apr 22, 2023

Copy link
Copy Markdown
ContributorAuthor

resolved conflicts and squashed into 5506f23

@tnull

tnull commented Apr 24, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

resolved conflicts and squashed into 5506f23

Not exactly sure what happened, but seems your changes are gone, i.e., you just pushed the branch you meant to rebase on?

@jurvis

jurvis commented Apr 24, 2023

Copy link
Copy Markdown
ContributorAuthor

Oops, I think I forgot to push something/had a cached version of the page. Squashed into 025b6d2

@jurvis
jurvisforce-pushed the jurvis/2022-09-start-uniffi/expose-list-peers-and-channels branch from d58cf3c to 53db279CompareApril 24, 2023 17:04
@jurvis

jurvis commented Apr 24, 2023

Copy link
Copy Markdown
ContributorAuthor

looks like there may be some conflicts in #25

@tnull

tnull commented Apr 25, 2023

Copy link
Copy Markdown
Collaborator

looks like there may be some conflicts in #25

Yup, just rebased #25, so you'll need to do the same here.

@tnulltnull added this to the 0.1 milestone Apr 25, 2023
@jurvis
jurvisforce-pushed the jurvis/2022-09-start-uniffi/expose-list-peers-and-channels branch from 53db279 to 25c947dCompareApril 26, 2023 17:48
@jurvis

jurvis commented Apr 26, 2023

Copy link
Copy Markdown
ContributorAuthor

hm, looks like there are still conflicts?

@tnull

tnull commented Apr 26, 2023

Copy link
Copy Markdown
Collaborator

hm, looks like there are still conflicts?

The princess is in another castle.

@jurvis
jurvisforce-pushed the jurvis/2022-09-start-uniffi/expose-list-peers-and-channels branch from 25c947d to 50e7368CompareApril 26, 2023 17:54
@jurvis

jurvis commented Apr 26, 2023

Copy link
Copy Markdown
ContributorAuthor

ok looking good -- rebased to 50e7368

@jurvis
jurvisforce-pushed the jurvis/2022-09-start-uniffi/expose-list-peers-and-channels branch from 50e7368 to c726ef9CompareApril 26, 2023 19:01
@jurvis

jurvis commented Apr 26, 2023

Copy link
Copy Markdown
ContributorAuthor

Fixed lint errors and squashed into c726ef9

@jurvis
jurvisforce-pushed the jurvis/2022-09-start-uniffi/expose-list-peers-and-channels branch from c726ef9 to 5a1fbe6CompareMay 10, 2023 03:59
@jurvis

jurvis commented May 10, 2023

Copy link
Copy Markdown
ContributorAuthor

rebased to 5a1fbe6

@tnulltnull mentioned this pull request May 10, 2023
Closed
tnull
tnull reviewed May 10, 2023
View reviewed changes
Comment threadbindings/ldk_node.udl Outdated
Comment threadsrc/test/functional_tests.rs Outdated
Comment threadsrc/types.rs Outdated
/// Information about the channel's funding transaction output. `None `unless a funding
/// transaction has been successfully negotiated with the channel's counterparty.
pub funding_txo: Option<OutPoint>,
/// Position of the funding transaction on-chain. `None` unless the funding transaction has been

@tnulltnullMay 10, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jurvis Lets leave the fields and the mentions of scid aliases out for now and re-add them if needed later. Now tracking here: #90

Comment threadsrc/types.rs Outdated
Jurvis Tan
Expose list_{channels, peers} to bindings
ce70bfe
# Conflicts:
#	bindings/ldk_node.udl
# Conflicts:
#	src/types.rs
@jurvis
jurvisforce-pushed the jurvis/2022-09-start-uniffi/expose-list-peers-and-channels branch from 5a1fbe6 to ce70bfeCompareMay 11, 2023 18:50
tnull
tnull approved these changes May 12, 2023
View reviewed changes

@tnulltnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can address any outstanding issues in a follow-up.

@tnull
tnull merged commit 02a4b08 into lightningdevkit:mainMay 12, 2023
This was referenced May 12, 2023
Closed
Merged
joostjager pushed a commit to joostjager/ldk-node that referenced this pull request Jan 28, 2026
@G8XSU
Merge pull requestlightningdevkit#56from G8XSU/2025-03-18-close-cha…
046972f
…nnel-api-fix
Consistently use UserChannelId and PaymentId as Strings.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnulltnulltnull approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.1

Development

Successfully merging this pull request may close these issues.

2 participants

@jurvis@tnull