Skip to content

Launch VSS, Expose build_with_vss* methods in bindings. - #376

Merged
tnull merged 2 commits into
lightningdevkit:mainfrom
G8XSU:vss-bindings
Oct 17, 2024
Merged

Launch VSS, Expose build_with_vss* methods in bindings.#376
tnull merged 2 commits into
lightningdevkit:mainfrom
G8XSU:vss-bindings

Conversation

@G8XSU

@G8XSUG8XSU commented Oct 15, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Based on #369

@G8XSUG8XSU changed the title Expose build_with_vss_store & build_with_vss_store_with_fixed_headers in bindings.Expose build_with_vss* methods in bindings.Oct 15, 2024
@G8XSU
G8XSU requested a review from tnullOctober 15, 2024 07:20
@G8XSU
G8XSUforce-pushed the vss-bindings branch 2 times, most recently from fe89347 to 66bdf17CompareOctober 15, 2024 18:53
@G8XSUG8XSU changed the title Expose build_with_vss* methods in bindings.Launch VSS, Expose build_with_vss* methods in bindings.Oct 15, 2024
@G8XSU
G8XSUforce-pushed the vss-bindings branch 2 times, most recently from 1f0a68a to 6afd993CompareOctober 15, 2024 23:41
tnull
tnull reviewed Oct 16, 2024
View reviewed changes
Comment threadCargo.toml
Comment threadsrc/builder.rs
Comment threadsrc/builder.rs Outdated
Comment threadsrc/builder.rs Outdated
@G8XSU
G8XSUforce-pushed the vss-bindings branch 2 times, most recently from 8c94253 to 3a9c604CompareOctober 17, 2024 00:10
@G8XSU

G8XSU commented Oct 17, 2024

Copy link
Copy Markdown
ContributorAuthor

CI will fail until rebased on top of #379

@G8XSU
G8XSU requested a review from tnullOctober 17, 2024 00:16
@G8XSU
G8XSUforce-pushed the vss-bindings branch 2 times, most recently from 4fdddd3 to 368bf60CompareOctober 17, 2024 05:27
@G8XSU

G8XSU commented Oct 17, 2024

Copy link
Copy Markdown
ContributorAuthor

Rebased on top #379

tnull
tnull reviewed Oct 17, 2024
View reviewed changes
Comment threadbindings/ldk_node.udl Outdated
Comment threadsrc/lib.rs Outdated
tnull
tnull reviewed Oct 17, 2024
View reviewed changes
Comment threadbindings/ldk_node.udl
@tnull

tnull commented Oct 17, 2024

Copy link
Copy Markdown
Collaborator

Needs a rebase now that #369 landed.

@tnulltnull mentioned this pull request Oct 17, 2024
Closed
12 tasks
@G8XSU
G8XSU requested a review from tnullOctober 17, 2024 09:18
@tnull

tnull commented Oct 17, 2024

Copy link
Copy Markdown
Collaborator

Feel free to squash the fixup.

@G8XSU

G8XSU commented Oct 17, 2024

Copy link
Copy Markdown
ContributorAuthor

Squashed.

tnull
tnull approved these changes Oct 17, 2024
View reviewed changes

@tnulltnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@tnull
tnull merged commit 651f837 into lightningdevkit:mainOct 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnulltnulltnull approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@G8XSU@tnull