Skip to content

Enable using VssStore with VssHeaderProvider. - #369

Merged
tnull merged 3 commits into
lightningdevkit:mainfrom
G8XSU:vss-lnauth
Oct 17, 2024
Merged

Enable using VssStore with VssHeaderProvider.#369
tnull merged 3 commits into
lightningdevkit:mainfrom
G8XSU:vss-lnauth

Conversation

@G8XSU

@G8XSUG8XSU commented Oct 10, 2024

Copy link
Copy Markdown
Contributor
  • Enable using VssStore with VssHeaderProvider.
  • Default to LnUrlJWT auth for using VSS.

tnull
tnull reviewed Oct 11, 2024
View reviewed changes
Comment threadsrc/builder.rs
Comment threadsrc/builder.rs
tnull
tnull reviewed Oct 11, 2024
View reviewed changes

@tnulltnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing on the formatting step.

@G8XSU

G8XSU commented Oct 15, 2024

Copy link
Copy Markdown
ContributorAuthor

Pushed 2 more commits but its not showing up since github is still processing them since 3 hrs: https://github.blog/changelog/2023-09-26-more-details-provided-when-a-pull-request-is-merged-indirectly-or-is-still-processing-updates/#pushed-commits-are-still-being-processed.

@G8XSUG8XSU mentioned this pull request Oct 15, 2024
Merged
@tnull

tnull commented Oct 15, 2024

Copy link
Copy Markdown
Collaborator

Pushed 2 more commits but its not showing up since github is still processing them since 3 hrs: https://github.blog/changelog/2023-09-26-more-details-provided-when-a-pull-request-is-merged-indirectly-or-is-still-processing-updates/#pushed-commits-are-still-being-processed.

Hmm, could you force-push once more? Can't review commits that aren't there 😁

@tnull

tnull commented Oct 15, 2024

Copy link
Copy Markdown
Collaborator

Also needs a rebase to account for the yanked 0.0.124.

@G8XSU

G8XSU commented Oct 15, 2024

Copy link
Copy Markdown
ContributorAuthor

Hmm, could you force-push once more? Can't review commits that aren't there 😁

Already force-pushed, didn't work. Hopefully it will be resolved after rebase, otherwise i might have to close this PR and open a new one.

@G8XSU
G8XSUforce-pushed the vss-lnauth branch 2 times, most recently from 87751f4 to d33d4edCompareOctober 15, 2024 18:03
@G8XSU

G8XSU commented Oct 15, 2024

Copy link
Copy Markdown
ContributorAuthor

Rebased.

@G8XSU
G8XSUforce-pushed the vss-lnauth branch 2 times, most recently from 422857c to d9c3f39CompareOctober 15, 2024 18:48
@G8XSUG8XSU mentioned this pull request Oct 15, 2024
Merged
@G8XSU
G8XSU requested a review from tnullOctober 15, 2024 22:56
tnull
tnull reviewed Oct 16, 2024
View reviewed changes
Comment threadsrc/builder.rs Outdated
Comment threadsrc/builder.rs
Comment threadsrc/builder.rs Outdated
Comment threadsrc/builder.rs Outdated
Comment threadsrc/io/vss_store.rs
Comment threadsrc/builder.rs Outdated
Comment threadsrc/builder.rs Outdated
Comment threadtests/integration_tests_vss.rs Outdated
@tnulltnull mentioned this pull request Oct 16, 2024
Closed
@G8XSU
G8XSUforce-pushed the vss-lnauth branch 2 times, most recently from 06d0d2c to daa18b3CompareOctober 16, 2024 23:55
@G8XSU
G8XSU requested a review from tnullOctober 17, 2024 00:16
tnull
tnull reviewed Oct 17, 2024
View reviewed changes
Comment threadsrc/builder.rs
Comment threadsrc/builder.rs Outdated
Comment threadsrc/builder.rs Outdated
Comment threadsrc/builder.rs Outdated
Comment threadsrc/builder.rs Outdated
Comment threadsrc/builder.rs
Comment threadsrc/builder.rs Outdated
tnull
tnull reviewed Oct 17, 2024
View reviewed changes
Comment threadsrc/builder.rs
tnull
tnull reviewed Oct 17, 2024
View reviewed changes

@tnulltnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM, mod #369 (comment)

Feel free to interleave and squash current round of fixups.

tnull
tnull approved these changes Oct 17, 2024
View reviewed changes

@tnulltnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnull
tnull merged commit 9ba95be into lightningdevkit:mainOct 17, 2024
@tnulltnull mentioned this pull request Oct 17, 2024
Closed
12 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnulltnulltnull approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@G8XSU@tnull