Skip to content

Use KeyObfuscator in VssStore. - #378

Merged
tnull merged 1 commit into
lightningdevkit:mainfrom
G8XSU:vss-obfu
Oct 17, 2024
Merged

Use KeyObfuscator in VssStore.#378
tnull merged 1 commit into
lightningdevkit:mainfrom
G8XSU:vss-obfu

Conversation

@G8XSU

@G8XSUG8XSU commented Oct 15, 2024

Copy link
Copy Markdown
Contributor

Based #369

@G8XSU
G8XSU requested a review from tnullOctober 15, 2024 22:38
tnull
tnull reviewed Oct 16, 2024
View reviewed changes
Comment threadsrc/io/vss_store.rs Outdated
@G8XSU
G8XSU requested a review from tnullOctober 17, 2024 00:16
tnull
tnull reviewed Oct 17, 2024
View reviewed changes
Comment threadsrc/io/vss_store.rs Outdated
Comment threadsrc/io/vss_store.rs Outdated
Comment threadsrc/io/vss_store.rs Outdated
Comment threadsrc/io/vss_store.rs Outdated
@tnull

tnull commented Oct 17, 2024

Copy link
Copy Markdown
Collaborator

Needs a rebase now that #369 landed.

@G8XSU

G8XSU commented Oct 17, 2024

Copy link
Copy Markdown
ContributorAuthor

Rebased

@G8XSU
G8XSU requested a review from tnullOctober 17, 2024 08:45
tnull
tnull reviewed Oct 17, 2024
View reviewed changes
Comment threadsrc/io/vss_store.rs Outdated
@G8XSU
G8XSU requested a review from tnullOctober 17, 2024 09:00
tnull
tnull reviewed Oct 17, 2024
View reviewed changes

@tnulltnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to squash.

I added one comment to simplify the derivation a bit (and save the concat), but you're choice whether to address it while squashing (as it doesn't change anything material).

Comment threadsrc/io/vss_store.rs
@G8XSU
Use KeyObfuscator in VssStore.
0ae0fc1
For client-side key obfuscation, improving privacy and security.
@G8XSU

G8XSU commented Oct 17, 2024

Copy link
Copy Markdown
ContributorAuthor

Squashed fixups.

@tnull
tnull merged commit 5909063 into lightningdevkit:mainOct 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnulltnulltnull approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@G8XSU@tnull