Add LSPS1 client-side integration by tnull · Pull Request #418 · lightningdevkit/ldk-node

tnull · 2024-12-04T14:49:01Z

We add the capability to act as an LSPS1 / bLIP-51 client.

tnull · 2025-01-17T08:47:57Z

Rebased on main after #426 landed.

tnull · 2025-01-30T13:24:52Z

Rebased on main to resolve minor changes.

.. to align with the rest of the APIs where we usually go `node_id`, `address`, etc.

We add support for LSPS1 liquidity sources. To this end we slightly refactor our logic to first create a `LiquiditySourceBuilder` that then can be used to `build()` the `LiquiditySource` with the configured services.

We add the logic required to send `create_order` requests and check on their status.

We add an `Lsps1Liquidity` API object, mirroring the approach we took with the `payment` APIs.

tnull · 2025-02-06T09:56:02Z

Now went ahead and squashed fixups, including the doc changes:

> git diff-tree -U2 0e590ba9 b1a277c6diff --git a/src/liquidity.rs b/src/liquidity.rs
index 7414260c..cbc19954 100644
--- a/src/liquidity.rs+++ b/src/liquidity.rs@@ -224,9 +224,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -285,9 +285,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -343,9 +343,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -390,9 +390,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -442,9 +442,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -964,6 +964,11 @@ pub(crate) struct LSPS2BuyResponse {
/// Should be retrieved by calling [`Node::lsps1_liquidity`].
///
+/// To open [bLIP-52 / LSPS2] JIT channels, please refer to+/// [`Bolt11Payment::receive_via_jit_channel`].+///
/// [bLIP-51 / LSPS1]: https://github.com/lightning/blips/blob/master/blip-0051.md
+/// [bLIP-52 / LSPS2]: https://github.com/lightning/blips/blob/master/blip-0052.md
/// [`Node::lsps1_liquidity`]: crate::Node::lsps1_liquidity
+/// [`Bolt11Payment::receive_via_jit_channel`]: crate::payment::Bolt11Payment::receive_via_jit_channel
#[derive(Clone)]
pub struct LSPS1Liquidity {

tnull · 2024-12-04T14:49:01Z

We add the capability to act as an LSPS1 / bLIP-51 client.

tnull · 2025-01-17T08:47:57Z

Rebased on main after #426 landed.

tnull · 2025-01-30T13:24:52Z

Rebased on main to resolve minor changes.

.. to align with the rest of the APIs where we usually go `node_id`, `address`, etc.

We add support for LSPS1 liquidity sources. To this end we slightly refactor our logic to first create a `LiquiditySourceBuilder` that then can be used to `build()` the `LiquiditySource` with the configured services.

We add the logic required to send `create_order` requests and check on their status.

We add an `Lsps1Liquidity` API object, mirroring the approach we took with the `payment` APIs.

tnull · 2025-02-06T09:56:02Z

Now went ahead and squashed fixups, including the doc changes:

> git diff-tree -U2 0e590ba9 b1a277c6diff --git a/src/liquidity.rs b/src/liquidity.rs
index 7414260c..cbc19954 100644
--- a/src/liquidity.rs+++ b/src/liquidity.rs@@ -224,9 +224,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -285,9 +285,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -343,9 +343,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -390,9 +390,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -442,9 +442,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -964,6 +964,11 @@ pub(crate) struct LSPS2BuyResponse {
/// Should be retrieved by calling [`Node::lsps1_liquidity`].
///
+/// To open [bLIP-52 / LSPS2] JIT channels, please refer to+/// [`Bolt11Payment::receive_via_jit_channel`].+///
/// [bLIP-51 / LSPS1]: https://github.com/lightning/blips/blob/master/blip-0051.md
+/// [bLIP-52 / LSPS2]: https://github.com/lightning/blips/blob/master/blip-0052.md
/// [`Node::lsps1_liquidity`]: crate::Node::lsps1_liquidity
+/// [`Bolt11Payment::receive_via_jit_channel`]: crate::payment::Bolt11Payment::receive_via_jit_channel
#[derive(Clone)]
pub struct LSPS1Liquidity {

tnull · 2024-12-04T14:49:01Z

We add the capability to act as an LSPS1 / bLIP-51 client.

tnull · 2025-01-17T08:47:57Z

Rebased on main after #426 landed.

tnull · 2025-01-30T13:24:52Z

Rebased on main to resolve minor changes.

.. to align with the rest of the APIs where we usually go `node_id`, `address`, etc.

We add support for LSPS1 liquidity sources. To this end we slightly refactor our logic to first create a `LiquiditySourceBuilder` that then can be used to `build()` the `LiquiditySource` with the configured services.

We add the logic required to send `create_order` requests and check on their status.

We add an `Lsps1Liquidity` API object, mirroring the approach we took with the `payment` APIs.

tnull · 2025-02-06T09:56:02Z

Now went ahead and squashed fixups, including the doc changes:

> git diff-tree -U2 0e590ba9 b1a277c6diff --git a/src/liquidity.rs b/src/liquidity.rs
index 7414260c..cbc19954 100644
--- a/src/liquidity.rs+++ b/src/liquidity.rs@@ -224,9 +224,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -285,9 +285,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -343,9 +343,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -390,9 +390,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -442,9 +442,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -964,6 +964,11 @@ pub(crate) struct LSPS2BuyResponse {
/// Should be retrieved by calling [`Node::lsps1_liquidity`].
///
+/// To open [bLIP-52 / LSPS2] JIT channels, please refer to+/// [`Bolt11Payment::receive_via_jit_channel`].+///
/// [bLIP-51 / LSPS1]: https://github.com/lightning/blips/blob/master/blip-0051.md
+/// [bLIP-52 / LSPS2]: https://github.com/lightning/blips/blob/master/blip-0052.md
/// [`Node::lsps1_liquidity`]: crate::Node::lsps1_liquidity
+/// [`Bolt11Payment::receive_via_jit_channel`]: crate::payment::Bolt11Payment::receive_via_jit_channel
#[derive(Clone)]
pub struct LSPS1Liquidity {

tnull · 2024-12-04T14:49:01Z

We add the capability to act as an LSPS1 / bLIP-51 client.

tnull · 2025-01-17T08:47:57Z

Rebased on main after #426 landed.

tnull · 2025-01-30T13:24:52Z

Rebased on main to resolve minor changes.

.. to align with the rest of the APIs where we usually go `node_id`, `address`, etc.

We add support for LSPS1 liquidity sources. To this end we slightly refactor our logic to first create a `LiquiditySourceBuilder` that then can be used to `build()` the `LiquiditySource` with the configured services.

We add the logic required to send `create_order` requests and check on their status.

We add an `Lsps1Liquidity` API object, mirroring the approach we took with the `payment` APIs.

tnull · 2025-02-06T09:56:02Z

Now went ahead and squashed fixups, including the doc changes:

> git diff-tree -U2 0e590ba9 b1a277c6diff --git a/src/liquidity.rs b/src/liquidity.rs
index 7414260c..cbc19954 100644
--- a/src/liquidity.rs+++ b/src/liquidity.rs@@ -224,9 +224,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -285,9 +285,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -343,9 +343,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -390,9 +390,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -442,9 +442,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -964,6 +964,11 @@ pub(crate) struct LSPS2BuyResponse {
/// Should be retrieved by calling [`Node::lsps1_liquidity`].
///
+/// To open [bLIP-52 / LSPS2] JIT channels, please refer to+/// [`Bolt11Payment::receive_via_jit_channel`].+///
/// [bLIP-51 / LSPS1]: https://github.com/lightning/blips/blob/master/blip-0051.md
+/// [bLIP-52 / LSPS2]: https://github.com/lightning/blips/blob/master/blip-0052.md
/// [`Node::lsps1_liquidity`]: crate::Node::lsps1_liquidity
+/// [`Bolt11Payment::receive_via_jit_channel`]: crate::payment::Bolt11Payment::receive_via_jit_channel
#[derive(Clone)]
pub struct LSPS1Liquidity {

tnull · 2024-12-04T14:49:01Z

We add the capability to act as an LSPS1 / bLIP-51 client.

tnull · 2025-01-17T08:47:57Z

Rebased on main after #426 landed.

tnull · 2025-01-30T13:24:52Z

Rebased on main to resolve minor changes.

.. to align with the rest of the APIs where we usually go `node_id`, `address`, etc.

We add support for LSPS1 liquidity sources. To this end we slightly refactor our logic to first create a `LiquiditySourceBuilder` that then can be used to `build()` the `LiquiditySource` with the configured services.

We add the logic required to send `create_order` requests and check on their status.

We add an `Lsps1Liquidity` API object, mirroring the approach we took with the `payment` APIs.

tnull · 2025-02-06T09:56:02Z

Now went ahead and squashed fixups, including the doc changes:

> git diff-tree -U2 0e590ba9 b1a277c6diff --git a/src/liquidity.rs b/src/liquidity.rs
index 7414260c..cbc19954 100644
--- a/src/liquidity.rs+++ b/src/liquidity.rs@@ -224,9 +224,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -285,9 +285,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -343,9 +343,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -390,9 +390,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -442,9 +442,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -964,6 +964,11 @@ pub(crate) struct LSPS2BuyResponse {
/// Should be retrieved by calling [`Node::lsps1_liquidity`].
///
+/// To open [bLIP-52 / LSPS2] JIT channels, please refer to+/// [`Bolt11Payment::receive_via_jit_channel`].+///
/// [bLIP-51 / LSPS1]: https://github.com/lightning/blips/blob/master/blip-0051.md
+/// [bLIP-52 / LSPS2]: https://github.com/lightning/blips/blob/master/blip-0052.md
/// [`Node::lsps1_liquidity`]: crate::Node::lsps1_liquidity
+/// [`Bolt11Payment::receive_via_jit_channel`]: crate::payment::Bolt11Payment::receive_via_jit_channel
#[derive(Clone)]
pub struct LSPS1Liquidity {

tnull · 2024-12-04T14:49:01Z

We add the capability to act as an LSPS1 / bLIP-51 client.

tnull · 2025-01-17T08:47:57Z

Rebased on main after #426 landed.

tnull · 2025-01-30T13:24:52Z

Rebased on main to resolve minor changes.

.. to align with the rest of the APIs where we usually go `node_id`, `address`, etc.

We add support for LSPS1 liquidity sources. To this end we slightly refactor our logic to first create a `LiquiditySourceBuilder` that then can be used to `build()` the `LiquiditySource` with the configured services.

We add the logic required to send `create_order` requests and check on their status.

We add an `Lsps1Liquidity` API object, mirroring the approach we took with the `payment` APIs.

tnull · 2025-02-06T09:56:02Z

Now went ahead and squashed fixups, including the doc changes:

> git diff-tree -U2 0e590ba9 b1a277c6diff --git a/src/liquidity.rs b/src/liquidity.rs
index 7414260c..cbc19954 100644
--- a/src/liquidity.rs+++ b/src/liquidity.rs@@ -224,9 +224,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -285,9 +285,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -343,9 +343,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -390,9 +390,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -442,9 +442,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -964,6 +964,11 @@ pub(crate) struct LSPS2BuyResponse {
/// Should be retrieved by calling [`Node::lsps1_liquidity`].
///
+/// To open [bLIP-52 / LSPS2] JIT channels, please refer to+/// [`Bolt11Payment::receive_via_jit_channel`].+///
/// [bLIP-51 / LSPS1]: https://github.com/lightning/blips/blob/master/blip-0051.md
+/// [bLIP-52 / LSPS2]: https://github.com/lightning/blips/blob/master/blip-0052.md
/// [`Node::lsps1_liquidity`]: crate::Node::lsps1_liquidity
+/// [`Bolt11Payment::receive_via_jit_channel`]: crate::payment::Bolt11Payment::receive_via_jit_channel
#[derive(Clone)]
pub struct LSPS1Liquidity {

tnull · 2024-12-04T14:49:01Z

We add the capability to act as an LSPS1 / bLIP-51 client.

tnull · 2025-01-17T08:47:57Z

Rebased on main after #426 landed.

tnull · 2025-01-30T13:24:52Z

Rebased on main to resolve minor changes.

.. to align with the rest of the APIs where we usually go `node_id`, `address`, etc.

We add support for LSPS1 liquidity sources. To this end we slightly refactor our logic to first create a `LiquiditySourceBuilder` that then can be used to `build()` the `LiquiditySource` with the configured services.

We add the logic required to send `create_order` requests and check on their status.

We add an `Lsps1Liquidity` API object, mirroring the approach we took with the `payment` APIs.

tnull · 2025-02-06T09:56:02Z

Now went ahead and squashed fixups, including the doc changes:

> git diff-tree -U2 0e590ba9 b1a277c6diff --git a/src/liquidity.rs b/src/liquidity.rs
index 7414260c..cbc19954 100644
--- a/src/liquidity.rs+++ b/src/liquidity.rs@@ -224,9 +224,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -285,9 +285,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -343,9 +343,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -390,9 +390,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -442,9 +442,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -964,6 +964,11 @@ pub(crate) struct LSPS2BuyResponse {
/// Should be retrieved by calling [`Node::lsps1_liquidity`].
///
+/// To open [bLIP-52 / LSPS2] JIT channels, please refer to+/// [`Bolt11Payment::receive_via_jit_channel`].+///
/// [bLIP-51 / LSPS1]: https://github.com/lightning/blips/blob/master/blip-0051.md
+/// [bLIP-52 / LSPS2]: https://github.com/lightning/blips/blob/master/blip-0052.md
/// [`Node::lsps1_liquidity`]: crate::Node::lsps1_liquidity
+/// [`Bolt11Payment::receive_via_jit_channel`]: crate::payment::Bolt11Payment::receive_via_jit_channel
#[derive(Clone)]
pub struct LSPS1Liquidity {

tnull · 2024-12-04T14:49:01Z

We add the capability to act as an LSPS1 / bLIP-51 client.

tnull · 2025-01-17T08:47:57Z

Rebased on main after #426 landed.

tnull · 2025-01-30T13:24:52Z

Rebased on main to resolve minor changes.

.. to align with the rest of the APIs where we usually go `node_id`, `address`, etc.

We add support for LSPS1 liquidity sources. To this end we slightly refactor our logic to first create a `LiquiditySourceBuilder` that then can be used to `build()` the `LiquiditySource` with the configured services.

We add the logic required to send `create_order` requests and check on their status.

We add an `Lsps1Liquidity` API object, mirroring the approach we took with the `payment` APIs.

tnull · 2025-02-06T09:56:02Z

Now went ahead and squashed fixups, including the doc changes:

> git diff-tree -U2 0e590ba9 b1a277c6diff --git a/src/liquidity.rs b/src/liquidity.rs
index 7414260c..cbc19954 100644
--- a/src/liquidity.rs+++ b/src/liquidity.rs@@ -224,9 +224,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -285,9 +285,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -343,9 +343,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -390,9 +390,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -442,9 +442,9 @@ where
match sender.send(response) {
Ok(()) => (),
- Err(e) => {+ Err(_) => {
log_error!(
self.logger,
- "Failed to handle response from liquidity service: {:?}",- e+ "Failed to handle response for request {:?} from liquidity service",+ request_id
);
},
@@ -964,6 +964,11 @@ pub(crate) struct LSPS2BuyResponse {
/// Should be retrieved by calling [`Node::lsps1_liquidity`].
///
+/// To open [bLIP-52 / LSPS2] JIT channels, please refer to+/// [`Bolt11Payment::receive_via_jit_channel`].+///
/// [bLIP-51 / LSPS1]: https://github.com/lightning/blips/blob/master/blip-0051.md
+/// [bLIP-52 / LSPS2]: https://github.com/lightning/blips/blob/master/blip-0052.md
/// [`Node::lsps1_liquidity`]: crate::Node::lsps1_liquidity
+/// [`Bolt11Payment::receive_via_jit_channel`]: crate::payment::Bolt11Payment::receive_via_jit_channel
#[derive(Clone)]
pub struct LSPS1Liquidity {

tnull marked this pull request as draft December 4, 2024 14:49

tnull force-pushed the 2024-07-lsps1-integration branch from a160bf2 to d0eb977Compare December 4, 2024 14:55

tnull mentioned this pull request Dec 10, 2024
Add bLIP-52 / LSPS2 service-side support #420
Merged

tnull force-pushed the 2024-07-lsps1-integration branch from d0eb977 to fe59fedCompare December 10, 2024 13:37

tnull force-pushed the 2024-07-lsps1-integration branch 2 times, most recently from 82fc329 to 9d47470Compare January 10, 2025 12:09

tnull added the blocked on dependent PR label Jan 15, 2025

tnull force-pushed the 2024-07-lsps1-integration branch from 9d47470 to 5e13aa5Compare January 16, 2025 09:33

tnull marked this pull request as ready for review January 16, 2025 09:33

tnull added this to the 0.5 milestone Jan 16, 2025

tnull force-pushed the 2024-07-lsps1-integration branch from 5e13aa5 to 2780049Compare January 17, 2025 08:47

tnull removed the blocked on dependent PR label Jan 17, 2025

tnull mentioned this pull request Jan 17, 2025
LDK Node v0.5 Tracking Issue #360
Closed
10 tasks

tnull force-pushed the 2024-07-lsps1-integration branch 2 times, most recently from 115f732 to a2593aeCompare January 30, 2025 13:19

tnull force-pushed the 2024-07-lsps1-integration branch 2 times, most recently from 1d68d58 to e3725b4Compare January 30, 2025 13:41

tnull requested a review from jkczyz January 30, 2025 14:02

jkczyz reviewed Jan 31, 2025
View reviewed changes

Comment threadsrc/liquidity.rs
Comment threadsrc/liquidity.rs Outdated
Comment threadsrc/liquidity.rs Outdated
Comment threadsrc/liquidity.rs Outdated
Comment threadsrc/liquidity.rs
Comment threadsrc/liquidity.rs

tnull added 2 commits February 1, 2025 08:59

Reorder LSPS2 API params
685c5b6
.. to align with the rest of the APIs where we usually go `node_id`, `address`, etc.

Allow to set LSPS1 liquidity source
6a9e3b5
We add support for LSPS1 liquidity sources. To this end we slightly refactor our logic to first create a `LiquiditySourceBuilder` that then can be used to `build()` the `LiquiditySource` with the configured services.

tnull force-pushed the 2024-07-lsps1-integration branch 4 times, most recently from 9cec3f4 to 0e590baCompare February 1, 2025 09:09

tnull added 3 commits February 6, 2025 10:50

Add create_order logic
ce3b3fa
We add the logic required to send `create_order` requests and check on their status.

Add LSPS1 API
4cc0a4a
We add an `Lsps1Liquidity` API object, mirroring the approach we took with the `payment` APIs.

Add Uniffi bindings for LSPS1 API
20bb3b2

tnull added 2 commits February 6, 2025 10:54

Update LSPS2 link in payment store
86f0229

Don't log value attempted on channel send failure
b1a277c

tnull force-pushed the 2024-07-lsps1-integration branch from 0e590ba to b1a277cCompare February 6, 2025 09:55

jkczyz approved these changes Feb 6, 2025
View reviewed changes

tnull merged commit f1fdee5 into lightningdevkit:mainFeb 6, 2025