') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Update BDK to 1.0.0 and LDK to 0.1.0 by tnull · Pull Request #426 · lightningdevkit/ldk-node · GitHub
Skip to content

Update BDK to 1.0.0 and LDK to 0.1.0 - #426

Merged
tnull merged 2 commits into
lightningdevkit:mainfrom
tnull:2025-01-upgrade-bdk-ldk
Jan 16, 2025
Merged

Update BDK to 1.0.0 and LDK to 0.1.0#426
tnull merged 2 commits into
lightningdevkit:mainfrom
tnull:2025-01-upgrade-bdk-ldk

Conversation

@tnull

@tnulltnull commented Jan 3, 2025

Copy link
Copy Markdown
Collaborator

We upgrade LDK and BDK to the latest releases.

@tnull
tnull requested a review from jkczyzJanuary 3, 2025 11:56
@tnull
tnullforce-pushed the 2025-01-upgrade-bdk-ldk branch 8 times, most recently from aa745c6 to 115104cCompareJanuary 6, 2025 12:39
This was referenced Jan 6, 2025
Merged
Merged
@tnull
tnullforce-pushed the 2025-01-upgrade-bdk-ldk branch from 115104c to 4e31967CompareJanuary 13, 2025 09:32
@tnull

tnull commented Jan 13, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Rebased on #429 to check it works (as other CI failures are fixed here).

@tnull
tnullforce-pushed the 2025-01-upgrade-bdk-ldk branch from 4e31967 to d7eb1a1CompareJanuary 13, 2025 10:07
jkczyz
jkczyz reviewed Jan 13, 2025
View reviewed changes
Comment threadsrc/payment/bolt11.rs Outdated
Comment threadsrc/io/test_utils.rs
@tnull
tnullforce-pushed the 2025-01-upgrade-bdk-ldk branch from d7eb1a1 to 363dd0fCompareJanuary 14, 2025 14:49
jkczyz
jkczyz reviewed Jan 14, 2025
View reviewed changes

@jkczyzjkczyz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to squash fixups.

@tnulltnull mentioned this pull request Jan 15, 2025
Merged
@tnull
tnullforce-pushed the 2025-01-upgrade-bdk-ldk branch from 363dd0f to d7e3d67CompareJanuary 15, 2025 08:42
@tnull

tnull commented Jan 15, 2025•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

LGTM. Feel free to squash fixups.

Squashed. I think we'll still need to wait on #429 and until LDK 0.1.0 ships to land this though.

@tnulltnull mentioned this pull request Jan 15, 2025
Merged
@tnull
tnullforce-pushed the 2025-01-upgrade-bdk-ldk branch from d7e3d67 to b8b9f01CompareJanuary 15, 2025 08:53
@tnull
Update BDK to 1.0.0 and LDK to 0.1.0
8f48dc6
@tnull
Fail Unified QR URI parsing if any known param fails
c39bfba
Previously, we decided to continue parsing any fields if we failed to
parse a known (i.e., `lightning` or `lno`) parameter failed to parse.
This however just hides the error and is a bit anti-idiomatic even
though allowing to use *some* URI fields even in the face of
incompatible formats for others.
Here we therefore opt to fail parsing the URI if any field fails.
@tnull
tnullforce-pushed the 2025-01-upgrade-bdk-ldk branch from b8b9f01 to c39bfbaCompareJanuary 16, 2025 08:43
@tnull
tnull requested a review from jkczyzJanuary 16, 2025 08:44
@tnull

tnull commented Jan 16, 2025

Copy link
Copy Markdown
CollaboratorAuthor

@jkczyz Now updated the branch for final 0.1.0 release crates, and dropped the DROPME commit. Should be good to go.

@tnulltnull added this to the 0.5 milestone Jan 16, 2025
@tnulltnull mentioned this pull request Jan 16, 2025
Merged
@tnull
tnull merged commit 03c4ab0 into lightningdevkit:mainJan 16, 2025
@tnulltnull mentioned this pull request Jan 17, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkczyzjkczyzjkczyz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.5

Development

Successfully merging this pull request may close these issues.

2 participants

@tnull@jkczyz