Uh oh!
There was an error while loading. Please reload this page.
Switch to nightlyrustfmt - #657
Conversation
👋 I see @jkczyz was un-assigned. |
cf05abf to
4effbe0Comparetnull
commented
Oct 13, 2025
Now disabled comment wrapping and string formatting options (TBD if we want this eventually). Rest should be good to land, IMO. |
4effbe0 to
23217f0Compareldk-reviews-bot
commented
Oct 15, 2025
🔔 1st Reminder Hey @jkczyz! This PR has been waiting for your review. |
23217f0 to
e4a0352Comparetnull
commented
Oct 16, 2025
Rebased to address minor conflicts. |
| @@ -0,0 +1,4 @@ | |||
| [toolchain] | |||
There was a problem hiding this comment.
If I simply run cargo fmt, isn't that supposed to just work?
~/repo/ldk-node (2025-10-switch-to-nightly-rustfmt ✔) cargo fmt Warning: can't set `format_code_in_doc_comments = true`, unstable features are only available in nightly channel.
Warning: can't set `comment_width = 100`, unstable features are only available in nightly channel.
There was a problem hiding this comment.
I am worried now about IDE support
There was a problem hiding this comment.
Hmm, do you happen to have set an override for LDK Node? I.e., rustup override set XXX? Otherwise it should indeed use what's inteh rust-toolchain.toml.
There was a problem hiding this comment.
What happens in your case if you do:
?main ~/workspace/ldk-node> cargo fmt --version
rustfmt 1.8.0-stable (1159e78c47 2025-09-14)
?main ~/workspace/ldk-node> git checkout 2025-10-switch-to-nightly-rustfmt
Switched to branch '2025-10-switch-to-nightly-rustfmt'
Your branch is up to date with 'origin/2025-10-switch-to-nightly-rustfmt'.
?2025-10-switch-to-nightly-rustfmt ~/workspace/ldk-node> cargo fmt --version
rustfmt 1.8.0-nightly (f6aa851dba 2025-10-07)
There was a problem hiding this comment.
Ah, that was it indeed. Had been reproducing issues on older rust version with the override. All good then. Farewell to the import nits 😎
Just an experiment for now.