Uh oh!
There was an error while loading. Please reload this page.
Nightly rustfmt follow-up - #669
Conversation
We had overlooked that the set toolchain would apply to all components not only the ones listed in `components`.
.. disabling this option avoids `cargo +1.85 fmt` making any changes if run after `cargo +nightly fmt`.
.. we indicate our MSRV in `Cargo.toml`.
.. which we steal from `rust-bitcoin`.
👋 Thanks for assigning @joostjager as a reviewer! |
| @@ -0,0 +1,28 @@ | |||
| name: Nightly rustfmt | |||
There was a problem hiding this comment.
Did you test-run this job in CI? (temp. schedule to trigger it?)
There was a problem hiding this comment.
Did you test-run this job in CI? (temp. schedule to trigger it?)
No, but it's a carbon copy of https://github.com/rust-bitcoin/rust-bitcoin/blob/master/.github/workflows/cron-weekly-rustfmt.yml, which is run weekly over at rust-bitcoin. See for example rust-bitcoin/rust-bitcoin#5120
There was a problem hiding this comment.
I guess we'll find out if the weekly works or not...
| @@ -0,0 +1,28 @@ | |||
| name: Nightly rustfmt | |||
There was a problem hiding this comment.
I guess we'll find out if the weekly works or not...
This is a follow-up to #657 which becomes necessary as
rust-toolchain.tomlunfortunately turned out not to work the way I thought it did.Here, we revert our default
rustfmtversion tostablebut also introduce a weekly cronjob runningcargo +nightly fmt(which we stole fromrust-bitcoin).