Uh oh!
There was an error while loading. Please reload this page.
Include non-permanently connected peers in list_peers() - #95
Conversation
1bfbfe2 to
7b6ac82Comparetnull
commented
May 23, 2023
Rebased after #85 landed. |
7b6ac82 to
a4da746Comparetnull
commented
Jun 6, 2023
Rebased on main. |
Uh oh!
There was an error while loading. Please reload this page.
| (Some(con_addr), Some(_stored_addr)) => NetAddress(con_addr), | ||
| (None, Some(stored_addr)) => stored_addr, | ||
| (Some(con_addr), None) => NetAddress(con_addr), | ||
| (None, None) => continue, |
There was a problem hiding this comment.
As we're using lightning-net-tokio and don't support OnionV3 currently, it shouldn't happen. In particular the conn_addr_opt should always be Some. However, I'd rather skip than unwrap here, as it doesn't hurt and is safer if something ever were to change.
| /// The channel's ID (prior to funding transaction generation, this is a random 32 bytes, | ||
| /// thereafter this is the transaction ID of the funding transaction XOR the funding transaction | ||
| /// output). | ||
| /// The channel ID (prior to funding transaction generation, this is a random 32 byte |
| /// that if we broadcast a revoked state, our counterparty can punish us by claiming at least | ||
| /// this value on chain. | ||
| /// The value, in satoshis, of this channel as it appears in the funding output. | ||
| pub channel_value_sats: u64, |
There was a problem hiding this comment.
We use the plural sats but the singular msat below, it seems.
There was a problem hiding this comment.
Mh, true. Possibly we should decide one way and clean up all at once. This is however doesn't feel like the right place to do it?
Uh oh!
There was an error while loading. Please reload this page.
a4da746 to
efec308CompareUh oh!
There was an error while loading. Please reload this page.
0dfee49 to
b10591aCompare
jkczyz
left a comment
There was a problem hiding this comment.
LGTM. Please squash fixups.
b10591a to
f562395Comparetnull
commented
Jun 13, 2023
Squashed without further changes. |
Closes#62,
based on #85This is a follow-up to #56, as we now are able to include non-permanently connected peers in
list_peers().We also include a number of minor doc fixes as a second commit.