Allow to set `SendingParameters` in BOLT11 & BOLT12 by Anyitechs · Pull Request #79 · lightningdevkit/ldk-server

Anyitechs · 2025-12-09T12:59:42Z

This PR introduces the ability to set SendingParameters in BOLT11 and BOLT12 send methods.

Closes#4

ldk-reviews-bot · 2025-12-09T12:59:45Z

👋 Thanks for assigning @benthecarman as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

benthecarman · 2025-12-09T19:18:55Z

+ max_total_cltv_expiry_delta: max_total_cltv_expiry_delta.unwrap_or_default(),
+ max_path_count: max_path_count.unwrap_or_default(),
+ max_channel_saturation_power_of_half: max_channel_saturation_power_of_half
+ .unwrap_or_default(),
+ };


We can't use unwrap_or_default here, it will set each of these to 0 and not give the user what they expect. Instead you should be setting these to RouteParametersConfig's default value

Ah, thank you.

benthecarman · 2025-12-09T19:19:16Z

+ max_total_cltv_expiry_delta: max_total_cltv_expiry_delta.unwrap_or_default(),
+ max_path_count: max_path_count.unwrap_or_default(),
+ max_channel_saturation_power_of_half: max_channel_saturation_power_of_half
+ .unwrap_or_default(),


benthecarman · 2025-12-09T19:22:23Z

+ // Defaults to [`DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA`].
+ uint32 max_total_cltv_expiry_delta = 2;
+
+ // The maximum number of paths that may be used by (MPP) payments.
+ // Defaults to [`DEFAULT_MAX_PATH_COUNT`].


The defaults to text here won't really work because it'll put the constant but not actually render/fetch the value. Will need to just put the actual value here sadly

benthecarman · 2025-12-09T19:28:35Z

+ max_path_count: params.max_path_count as u8,
+ max_channel_saturation_power_of_half: params.max_channel_saturation_power_of_half as u8,


since we are going down from u32 to u8, this isn't really safe. we should use try_into here so we can properly handle overflows

benthecarman · 2025-12-09T19:28:54Z

+	let route_parameters = request.route_parameters.map(|params| RouteParametersConfig {
+ max_total_routing_fee_msat: params.max_total_routing_fee_msat,
+ max_total_cltv_expiry_delta: params.max_total_cltv_expiry_delta,
+ max_path_count: params.max_path_count as u8,


benthecarman

lgtm! can you squash your commits though

Anyitechs · 2025-12-11T11:56:07Z

can you squash your commits though

Done. Squashed fixups with no further changes.

…gParameters

Anyitechs · 2025-12-09T12:59:42Z

This PR introduces the ability to set SendingParameters in BOLT11 and BOLT12 send methods.

Closes#4

ldk-reviews-bot · 2025-12-09T12:59:45Z

👋 Thanks for assigning @benthecarman as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

benthecarman · 2025-12-09T19:18:55Z

+ max_total_cltv_expiry_delta: max_total_cltv_expiry_delta.unwrap_or_default(),
+ max_path_count: max_path_count.unwrap_or_default(),
+ max_channel_saturation_power_of_half: max_channel_saturation_power_of_half
+ .unwrap_or_default(),
+ };


We can't use unwrap_or_default here, it will set each of these to 0 and not give the user what they expect. Instead you should be setting these to RouteParametersConfig's default value

Ah, thank you.

benthecarman · 2025-12-09T19:19:16Z

+ max_total_cltv_expiry_delta: max_total_cltv_expiry_delta.unwrap_or_default(),
+ max_path_count: max_path_count.unwrap_or_default(),
+ max_channel_saturation_power_of_half: max_channel_saturation_power_of_half
+ .unwrap_or_default(),


benthecarman · 2025-12-09T19:22:23Z

+ // Defaults to [`DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA`].
+ uint32 max_total_cltv_expiry_delta = 2;
+
+ // The maximum number of paths that may be used by (MPP) payments.
+ // Defaults to [`DEFAULT_MAX_PATH_COUNT`].


The defaults to text here won't really work because it'll put the constant but not actually render/fetch the value. Will need to just put the actual value here sadly

benthecarman · 2025-12-09T19:28:35Z

+ max_path_count: params.max_path_count as u8,
+ max_channel_saturation_power_of_half: params.max_channel_saturation_power_of_half as u8,


since we are going down from u32 to u8, this isn't really safe. we should use try_into here so we can properly handle overflows

benthecarman · 2025-12-09T19:28:54Z

+	let route_parameters = request.route_parameters.map(|params| RouteParametersConfig {
+ max_total_routing_fee_msat: params.max_total_routing_fee_msat,
+ max_total_cltv_expiry_delta: params.max_total_cltv_expiry_delta,
+ max_path_count: params.max_path_count as u8,


benthecarman

lgtm! can you squash your commits though

Anyitechs · 2025-12-11T11:56:07Z

can you squash your commits though

Done. Squashed fixups with no further changes.

…gParameters

Anyitechs · 2025-12-09T12:59:42Z

This PR introduces the ability to set SendingParameters in BOLT11 and BOLT12 send methods.

Closes#4

ldk-reviews-bot · 2025-12-09T12:59:45Z

👋 Thanks for assigning @benthecarman as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

benthecarman · 2025-12-09T19:18:55Z

+ max_total_cltv_expiry_delta: max_total_cltv_expiry_delta.unwrap_or_default(),
+ max_path_count: max_path_count.unwrap_or_default(),
+ max_channel_saturation_power_of_half: max_channel_saturation_power_of_half
+ .unwrap_or_default(),
+ };


We can't use unwrap_or_default here, it will set each of these to 0 and not give the user what they expect. Instead you should be setting these to RouteParametersConfig's default value

Ah, thank you.

benthecarman · 2025-12-09T19:19:16Z

+ max_total_cltv_expiry_delta: max_total_cltv_expiry_delta.unwrap_or_default(),
+ max_path_count: max_path_count.unwrap_or_default(),
+ max_channel_saturation_power_of_half: max_channel_saturation_power_of_half
+ .unwrap_or_default(),


benthecarman · 2025-12-09T19:22:23Z

+ // Defaults to [`DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA`].
+ uint32 max_total_cltv_expiry_delta = 2;
+
+ // The maximum number of paths that may be used by (MPP) payments.
+ // Defaults to [`DEFAULT_MAX_PATH_COUNT`].


The defaults to text here won't really work because it'll put the constant but not actually render/fetch the value. Will need to just put the actual value here sadly

benthecarman · 2025-12-09T19:28:35Z

+ max_path_count: params.max_path_count as u8,
+ max_channel_saturation_power_of_half: params.max_channel_saturation_power_of_half as u8,


since we are going down from u32 to u8, this isn't really safe. we should use try_into here so we can properly handle overflows

benthecarman · 2025-12-09T19:28:54Z

+	let route_parameters = request.route_parameters.map(|params| RouteParametersConfig {
+ max_total_routing_fee_msat: params.max_total_routing_fee_msat,
+ max_total_cltv_expiry_delta: params.max_total_cltv_expiry_delta,
+ max_path_count: params.max_path_count as u8,


benthecarman

lgtm! can you squash your commits though

Anyitechs · 2025-12-11T11:56:07Z

can you squash your commits though

Done. Squashed fixups with no further changes.

…gParameters

Anyitechs · 2025-12-09T12:59:42Z

This PR introduces the ability to set SendingParameters in BOLT11 and BOLT12 send methods.

Closes#4

ldk-reviews-bot · 2025-12-09T12:59:45Z

👋 Thanks for assigning @benthecarman as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

benthecarman · 2025-12-09T19:18:55Z

+ max_total_cltv_expiry_delta: max_total_cltv_expiry_delta.unwrap_or_default(),
+ max_path_count: max_path_count.unwrap_or_default(),
+ max_channel_saturation_power_of_half: max_channel_saturation_power_of_half
+ .unwrap_or_default(),
+ };


We can't use unwrap_or_default here, it will set each of these to 0 and not give the user what they expect. Instead you should be setting these to RouteParametersConfig's default value

Ah, thank you.

benthecarman · 2025-12-09T19:19:16Z

+ max_total_cltv_expiry_delta: max_total_cltv_expiry_delta.unwrap_or_default(),
+ max_path_count: max_path_count.unwrap_or_default(),
+ max_channel_saturation_power_of_half: max_channel_saturation_power_of_half
+ .unwrap_or_default(),


benthecarman · 2025-12-09T19:22:23Z

+ // Defaults to [`DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA`].
+ uint32 max_total_cltv_expiry_delta = 2;
+
+ // The maximum number of paths that may be used by (MPP) payments.
+ // Defaults to [`DEFAULT_MAX_PATH_COUNT`].


The defaults to text here won't really work because it'll put the constant but not actually render/fetch the value. Will need to just put the actual value here sadly

benthecarman · 2025-12-09T19:28:35Z

+ max_path_count: params.max_path_count as u8,
+ max_channel_saturation_power_of_half: params.max_channel_saturation_power_of_half as u8,


since we are going down from u32 to u8, this isn't really safe. we should use try_into here so we can properly handle overflows

benthecarman · 2025-12-09T19:28:54Z

+	let route_parameters = request.route_parameters.map(|params| RouteParametersConfig {
+ max_total_routing_fee_msat: params.max_total_routing_fee_msat,
+ max_total_cltv_expiry_delta: params.max_total_cltv_expiry_delta,
+ max_path_count: params.max_path_count as u8,


benthecarman

lgtm! can you squash your commits though

Anyitechs · 2025-12-11T11:56:07Z

can you squash your commits though

Done. Squashed fixups with no further changes.

…gParameters

Anyitechs · 2025-12-09T12:59:42Z

This PR introduces the ability to set SendingParameters in BOLT11 and BOLT12 send methods.

Closes#4

ldk-reviews-bot · 2025-12-09T12:59:45Z

👋 Thanks for assigning @benthecarman as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

benthecarman · 2025-12-09T19:18:55Z

+ max_total_cltv_expiry_delta: max_total_cltv_expiry_delta.unwrap_or_default(),
+ max_path_count: max_path_count.unwrap_or_default(),
+ max_channel_saturation_power_of_half: max_channel_saturation_power_of_half
+ .unwrap_or_default(),
+ };


We can't use unwrap_or_default here, it will set each of these to 0 and not give the user what they expect. Instead you should be setting these to RouteParametersConfig's default value

Ah, thank you.

benthecarman · 2025-12-09T19:19:16Z

+ max_total_cltv_expiry_delta: max_total_cltv_expiry_delta.unwrap_or_default(),
+ max_path_count: max_path_count.unwrap_or_default(),
+ max_channel_saturation_power_of_half: max_channel_saturation_power_of_half
+ .unwrap_or_default(),


benthecarman · 2025-12-09T19:22:23Z

+ // Defaults to [`DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA`].
+ uint32 max_total_cltv_expiry_delta = 2;
+
+ // The maximum number of paths that may be used by (MPP) payments.
+ // Defaults to [`DEFAULT_MAX_PATH_COUNT`].


The defaults to text here won't really work because it'll put the constant but not actually render/fetch the value. Will need to just put the actual value here sadly

benthecarman · 2025-12-09T19:28:35Z

+ max_path_count: params.max_path_count as u8,
+ max_channel_saturation_power_of_half: params.max_channel_saturation_power_of_half as u8,


since we are going down from u32 to u8, this isn't really safe. we should use try_into here so we can properly handle overflows

benthecarman · 2025-12-09T19:28:54Z

+	let route_parameters = request.route_parameters.map(|params| RouteParametersConfig {
+ max_total_routing_fee_msat: params.max_total_routing_fee_msat,
+ max_total_cltv_expiry_delta: params.max_total_cltv_expiry_delta,
+ max_path_count: params.max_path_count as u8,


benthecarman

lgtm! can you squash your commits though

Anyitechs · 2025-12-11T11:56:07Z

can you squash your commits though

Done. Squashed fixups with no further changes.

…gParameters

Anyitechs · 2025-12-09T12:59:42Z

This PR introduces the ability to set SendingParameters in BOLT11 and BOLT12 send methods.

Closes#4

ldk-reviews-bot · 2025-12-09T12:59:45Z

👋 Thanks for assigning @benthecarman as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

benthecarman · 2025-12-09T19:18:55Z

+ max_total_cltv_expiry_delta: max_total_cltv_expiry_delta.unwrap_or_default(),
+ max_path_count: max_path_count.unwrap_or_default(),
+ max_channel_saturation_power_of_half: max_channel_saturation_power_of_half
+ .unwrap_or_default(),
+ };


We can't use unwrap_or_default here, it will set each of these to 0 and not give the user what they expect. Instead you should be setting these to RouteParametersConfig's default value

Ah, thank you.

benthecarman · 2025-12-09T19:19:16Z

+ max_total_cltv_expiry_delta: max_total_cltv_expiry_delta.unwrap_or_default(),
+ max_path_count: max_path_count.unwrap_or_default(),
+ max_channel_saturation_power_of_half: max_channel_saturation_power_of_half
+ .unwrap_or_default(),


benthecarman · 2025-12-09T19:22:23Z

+ // Defaults to [`DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA`].
+ uint32 max_total_cltv_expiry_delta = 2;
+
+ // The maximum number of paths that may be used by (MPP) payments.
+ // Defaults to [`DEFAULT_MAX_PATH_COUNT`].


The defaults to text here won't really work because it'll put the constant but not actually render/fetch the value. Will need to just put the actual value here sadly

benthecarman · 2025-12-09T19:28:35Z

+ max_path_count: params.max_path_count as u8,
+ max_channel_saturation_power_of_half: params.max_channel_saturation_power_of_half as u8,


since we are going down from u32 to u8, this isn't really safe. we should use try_into here so we can properly handle overflows

benthecarman · 2025-12-09T19:28:54Z

+	let route_parameters = request.route_parameters.map(|params| RouteParametersConfig {
+ max_total_routing_fee_msat: params.max_total_routing_fee_msat,
+ max_total_cltv_expiry_delta: params.max_total_cltv_expiry_delta,
+ max_path_count: params.max_path_count as u8,


benthecarman

lgtm! can you squash your commits though

Anyitechs · 2025-12-11T11:56:07Z

can you squash your commits though

Done. Squashed fixups with no further changes.

…gParameters

Anyitechs · 2025-12-09T12:59:42Z

This PR introduces the ability to set SendingParameters in BOLT11 and BOLT12 send methods.

Closes#4

ldk-reviews-bot · 2025-12-09T12:59:45Z

👋 Thanks for assigning @benthecarman as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

benthecarman · 2025-12-09T19:18:55Z

+ max_total_cltv_expiry_delta: max_total_cltv_expiry_delta.unwrap_or_default(),
+ max_path_count: max_path_count.unwrap_or_default(),
+ max_channel_saturation_power_of_half: max_channel_saturation_power_of_half
+ .unwrap_or_default(),
+ };


We can't use unwrap_or_default here, it will set each of these to 0 and not give the user what they expect. Instead you should be setting these to RouteParametersConfig's default value

Ah, thank you.

benthecarman · 2025-12-09T19:19:16Z

+ max_total_cltv_expiry_delta: max_total_cltv_expiry_delta.unwrap_or_default(),
+ max_path_count: max_path_count.unwrap_or_default(),
+ max_channel_saturation_power_of_half: max_channel_saturation_power_of_half
+ .unwrap_or_default(),


benthecarman · 2025-12-09T19:22:23Z

+ // Defaults to [`DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA`].
+ uint32 max_total_cltv_expiry_delta = 2;
+
+ // The maximum number of paths that may be used by (MPP) payments.
+ // Defaults to [`DEFAULT_MAX_PATH_COUNT`].


The defaults to text here won't really work because it'll put the constant but not actually render/fetch the value. Will need to just put the actual value here sadly

benthecarman · 2025-12-09T19:28:35Z

+ max_path_count: params.max_path_count as u8,
+ max_channel_saturation_power_of_half: params.max_channel_saturation_power_of_half as u8,


since we are going down from u32 to u8, this isn't really safe. we should use try_into here so we can properly handle overflows

benthecarman · 2025-12-09T19:28:54Z

+	let route_parameters = request.route_parameters.map(|params| RouteParametersConfig {
+ max_total_routing_fee_msat: params.max_total_routing_fee_msat,
+ max_total_cltv_expiry_delta: params.max_total_cltv_expiry_delta,
+ max_path_count: params.max_path_count as u8,


benthecarman

lgtm! can you squash your commits though

Anyitechs · 2025-12-11T11:56:07Z

can you squash your commits though

Done. Squashed fixups with no further changes.

…gParameters

Anyitechs · 2025-12-09T12:59:42Z

This PR introduces the ability to set SendingParameters in BOLT11 and BOLT12 send methods.

Closes#4

ldk-reviews-bot · 2025-12-09T12:59:45Z

👋 Thanks for assigning @benthecarman as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

benthecarman · 2025-12-09T19:18:55Z

+ max_total_cltv_expiry_delta: max_total_cltv_expiry_delta.unwrap_or_default(),
+ max_path_count: max_path_count.unwrap_or_default(),
+ max_channel_saturation_power_of_half: max_channel_saturation_power_of_half
+ .unwrap_or_default(),
+ };


We can't use unwrap_or_default here, it will set each of these to 0 and not give the user what they expect. Instead you should be setting these to RouteParametersConfig's default value

Ah, thank you.

benthecarman · 2025-12-09T19:19:16Z

+ max_total_cltv_expiry_delta: max_total_cltv_expiry_delta.unwrap_or_default(),
+ max_path_count: max_path_count.unwrap_or_default(),
+ max_channel_saturation_power_of_half: max_channel_saturation_power_of_half
+ .unwrap_or_default(),


benthecarman · 2025-12-09T19:22:23Z

+ // Defaults to [`DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA`].
+ uint32 max_total_cltv_expiry_delta = 2;
+
+ // The maximum number of paths that may be used by (MPP) payments.
+ // Defaults to [`DEFAULT_MAX_PATH_COUNT`].


The defaults to text here won't really work because it'll put the constant but not actually render/fetch the value. Will need to just put the actual value here sadly

benthecarman · 2025-12-09T19:28:35Z

+ max_path_count: params.max_path_count as u8,
+ max_channel_saturation_power_of_half: params.max_channel_saturation_power_of_half as u8,


since we are going down from u32 to u8, this isn't really safe. we should use try_into here so we can properly handle overflows

benthecarman · 2025-12-09T19:28:54Z

+	let route_parameters = request.route_parameters.map(|params| RouteParametersConfig {
+ max_total_routing_fee_msat: params.max_total_routing_fee_msat,
+ max_total_cltv_expiry_delta: params.max_total_cltv_expiry_delta,
+ max_path_count: params.max_path_count as u8,


benthecarman

lgtm! can you squash your commits though

Anyitechs · 2025-12-11T11:56:07Z

can you squash your commits though

Done. Squashed fixups with no further changes.

…gParameters

Anyitechs force-pushed the introduce-SendingParameters branch from 19da5dd to 96842d2Compare December 9, 2025 13:08

ldk-reviews-bot requested a review from valentinewallace December 9, 2025 13:10

tnull requested review from benthecarman and removed request for valentinewallace December 9, 2025 13:55

benthecarman requested changes Dec 9, 2025
View reviewed changes

Anyitechs requested a review from benthecarman December 10, 2025 09:23

benthecarman approved these changes Dec 10, 2025
View reviewed changes

Anyitechs added 2 commits December 11, 2025 12:36

add RouteParametersConfig struct to proto types
aaf587d

allow route_parameters in BOLT11 & BOLT12 send API
ebb776d

Anyitechs force-pushed the introduce-SendingParameters branch from a8de0d1 to ebb776dCompare December 11, 2025 11:47

benthecarman approved these changes Dec 11, 2025
View reviewed changes

benthecarman merged commit 48a02e5 into lightningdevkit:mainDec 11, 2025
7 checks passed

rsafier pushed a commit to rsafier/ldk-server that referenced this pull request Apr 20, 2026
Merge pull requestlightningdevkit#79from Anyitechs/introduce-Sendin…
bd6f2e1
…gParameters