Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 73 additions & 4 deletions ldk-server-cli/src/main.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,11 +10,19 @@ use ldk_server_client::ldk_server_protos::api::{
ListChannelsRequest, ListPaymentsRequest, OnchainReceiveRequest, OnchainSendRequest,
OpenChannelRequest,
};
use ldk_server_client::ldk_server_protos::types::RouteParametersConfig;
use ldk_server_client::ldk_server_protos::types::{
bolt11_invoice_description, Bolt11InvoiceDescription, PageToken, Payment,
};
use std::fmt::Debug;

// Having these default values as constants in the Proto file and
// importing/reusing them here might be better, but Proto3 removed
// the ability to set default values.
const DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA: u32 = 1008;
const DEFAULT_MAX_PATH_COUNT: u32 = 10;
const DEFAULT_MAX_CHANNEL_SATURATION_POWER_OF_HALF: u32 = 2;

#[derive(Parser, Debug)]
#[command(version, about, long_about = None)]
struct Cli {
Expand DownExpand Up@@ -55,6 +63,14 @@ enum Commands {
invoice: String,
#[arg(long)]
amount_msat: Option<u64>,
#[arg(long)]
max_total_routing_fee_msat: Option<u64>,
#[arg(long)]
max_total_cltv_expiry_delta: Option<u32>,
#[arg(long)]
max_path_count: Option<u32>,
#[arg(long)]
max_channel_saturation_power_of_half: Option<u32>,
},
Bolt12Receive {
#[arg(short, long)]
Expand All@@ -75,6 +91,14 @@ enum Commands {
quantity: Option<u64>,
#[arg(short, long)]
payer_note: Option<String>,
#[arg(long)]
max_total_routing_fee_msat: Option<u64>,
#[arg(long)]
max_total_cltv_expiry_delta: Option<u32>,
#[arg(long)]
max_path_count: Option<u32>,
#[arg(long)]
max_channel_saturation_power_of_half: Option<u32>,
},
CloseChannel {
#[arg(short, long)]
Expand DownExpand Up@@ -161,9 +185,30 @@ async fn main() {

handle_response_result(client.bolt11_receive(request).await);
},
Commands::Bolt11Send { invoice, amount_msat } => {
Commands::Bolt11Send {
invoice,
amount_msat,
max_total_routing_fee_msat,
max_total_cltv_expiry_delta,
max_path_count,
max_channel_saturation_power_of_half,
} => {
let route_parameters = RouteParametersConfig {
max_total_routing_fee_msat,
max_total_cltv_expiry_delta: max_total_cltv_expiry_delta
.unwrap_or(DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA),
max_path_count: max_path_count.unwrap_or(DEFAULT_MAX_PATH_COUNT),
max_channel_saturation_power_of_half: max_channel_saturation_power_of_half
.unwrap_or(DEFAULT_MAX_CHANNEL_SATURATION_POWER_OF_HALF),
};
handle_response_result(
client.bolt11_send(Bolt11SendRequest { invoice, amount_msat }).await,
client
.bolt11_send(Bolt11SendRequest {
invoice,
amount_msat,
route_parameters: Some(route_parameters),
})
.await,
);
},
Commands::Bolt12Receive { description, amount_msat, expiry_secs, quantity } => {
Expand All@@ -178,10 +223,34 @@ async fn main() {
.await,
);
},
Commands::Bolt12Send { offer, amount_msat, quantity, payer_note } => {
Commands::Bolt12Send {
offer,
amount_msat,
quantity,
payer_note,
max_total_routing_fee_msat,
max_total_cltv_expiry_delta,
max_path_count,
max_channel_saturation_power_of_half,
} => {
let route_parameters = RouteParametersConfig {
max_total_routing_fee_msat,
max_total_cltv_expiry_delta: max_total_cltv_expiry_delta
.unwrap_or(DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA),
max_path_count: max_path_count.unwrap_or(DEFAULT_MAX_PATH_COUNT),
max_channel_saturation_power_of_half: max_channel_saturation_power_of_half
.unwrap_or(DEFAULT_MAX_CHANNEL_SATURATION_POWER_OF_HALF),
};

handle_response_result(
client
.bolt12_send(Bolt12SendRequest { offer, amount_msat, quantity, payer_note })
.bolt12_send(Bolt12SendRequest {
offer,
amount_msat,
quantity,
payer_note,
route_parameters: Some(route_parameters),
})
.await,
);
},
Expand Down
6 changes: 6 additions & 0 deletions ldk-server-protos/src/api.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -141,6 +141,9 @@ pub struct Bolt11SendRequest {
/// This operation will fail if the amount specified is less than the value required by the given invoice.
#[prost(uint64, optional, tag = "2")]
pub amount_msat: ::core::option::Option<u64>,
/// Configuration options for payment routing and pathfinding.
#[prost(message, optional, tag = "3")]
pub route_parameters: ::core::option::Option<super::types::RouteParametersConfig>,
}
/// The response `content` for the `Bolt11Send` API, when HttpStatusCode is OK (200).
/// When HttpStatusCode is not OK (non-200), the response `content` contains a serialized `ErrorResponse`.
Expand DownExpand Up@@ -205,6 +208,9 @@ pub struct Bolt12SendRequest {
/// If set, it will be seen by the recipient and reflected back in the invoice.
#[prost(string, optional, tag = "4")]
pub payer_note: ::core::option::Option<::prost::alloc::string::String>,
/// Configuration options for payment routing and pathfinding.
#[prost(message, optional, tag = "5")]
pub route_parameters: ::core::option::Option<super::types::RouteParametersConfig>,
}
/// The response `content` for the `Bolt12Send` API, when HttpStatusCode is OK (200).
/// When HttpStatusCode is not OK (non-200), the response `content` contains a serialized `ErrorResponse`.
Expand Down
6 changes: 6 additions & 0 deletions ldk-server-protos/src/proto/api.proto
Original file line numberDiff line numberDiff line change
Expand Up@@ -138,6 +138,9 @@ message Bolt11SendRequest {
// amount paid to be determined by the user.
// This operation will fail if the amount specified is less than the value required by the given invoice.
optional uint64 amount_msat = 2;

// Configuration options for payment routing and pathfinding.
optional types.RouteParametersConfig route_parameters = 3;

}

Expand DownExpand Up@@ -199,6 +202,9 @@ message Bolt12SendRequest {

// If set, it will be seen by the recipient and reflected back in the invoice.
optional string payer_note = 4;

// Configuration options for payment routing and pathfinding.
optional types.RouteParametersConfig route_parameters = 5;
}

// The response `content` for the `Bolt12Send` API, when HttpStatusCode is OK (200).
Expand Down
21 changes: 21 additions & 0 deletions ldk-server-protos/src/proto/types.proto
Original file line numberDiff line numberDiff line change
Expand Up@@ -683,3 +683,24 @@ message Bolt11InvoiceDescription {
string hash = 2;
}
}

// Configuration options for payment routing and pathfinding.
// See https://docs.rs/lightning/0.2.0/lightning/routing/router/struct.RouteParametersConfig.html for more details on each field.
message RouteParametersConfig {
// The maximum total fees, in millisatoshi, that may accrue during route finding.
// Defaults to 1% of the payment amount + 50 sats
optional uint64 max_total_routing_fee_msat = 1;

// The maximum total CLTV delta we accept for the route.
// Defaults to 1008.
uint32 max_total_cltv_expiry_delta = 2;

// The maximum number of paths that may be used by (MPP) payments.
// Defaults to 10.
uint32 max_path_count = 3;

// Selects the maximum share of a channel's total capacity which will be
// sent over a channel, as a power of 1/2.
// Default value: 2
uint32 max_channel_saturation_power_of_half = 4;
}
23 changes: 23 additions & 0 deletions ldk-server-protos/src/types.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -779,6 +779,29 @@ pub mod bolt11_invoice_description {
Hash(::prost::alloc::string::String),
}
}
/// Configuration options for payment routing and pathfinding.
/// See <https://docs.rs/lightning/0.2.0/lightning/routing/router/struct.RouteParametersConfig.html> for more details on each field.
#[allow(clippy::derive_partial_eq_without_eq)]
#[derive(Clone, PartialEq, ::prost::Message)]
pub struct RouteParametersConfig {
/// The maximum total fees, in millisatoshi, that may accrue during route finding.
/// Defaults to 1% of the payment amount + 50 sats
#[prost(uint64, optional, tag = "1")]
pub max_total_routing_fee_msat: ::core::option::Option<u64>,
/// The maximum total CLTV delta we accept for the route.
/// Defaults to 1008.
#[prost(uint32, tag = "2")]
pub max_total_cltv_expiry_delta: u32,
/// The maximum number of paths that may be used by (MPP) payments.
/// Defaults to 10.
#[prost(uint32, tag = "3")]
pub max_path_count: u32,
/// Selects the maximum share of a channel's total capacity which will be
/// sent over a channel, as a power of 1/2.
/// Default value: 2
#[prost(uint32, tag = "4")]
pub max_channel_saturation_power_of_half: u32,
}
/// Represents the direction of a payment.
#[derive(Clone, Copy, Debug, PartialEq, Eq, Hash, PartialOrd, Ord, ::prost::Enumeration)]
#[repr(i32)]
Expand Down
34 changes: 32 additions & 2 deletions ldk-server/src/api/bolt11_send.rs
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
use crate::api::error::LdkServerError;
use crate::api::error::LdkServerErrorCode::InvalidRequestError;
use crate::service::Context;
use ldk_node::lightning::routing::router::RouteParametersConfig;
use ldk_node::lightning_invoice::Bolt11Invoice;
use ldk_server_protos::api::{Bolt11SendRequest, Bolt11SendResponse};
use std::str::FromStr;
Expand All@@ -12,10 +14,38 @@ pub(crate) fn handle_bolt11_send_request(
let invoice = Bolt11Invoice::from_str(&request.invoice.as_str())
.map_err(|_| ldk_node::NodeError::InvalidInvoice)?;

let route_parameters = match request.route_parameters {
Some(params) => {
let max_path_count: u8 = params.max_path_count.try_into().map_err(|_| {
LdkServerError::new(
InvalidRequestError,
format!("Invalid max_path_count, must be between 0 and {}", u8::MAX),
)
})?;
let max_channel_saturation_power_of_half: u8 =
params.max_channel_saturation_power_of_half.try_into().map_err(|_| {
LdkServerError::new(
InvalidRequestError,
format!(
"Invalid max_channel_saturation_power_of_half, must be between 0 and {}",
u8::MAX
),
)
})?;
Some(RouteParametersConfig {
max_total_routing_fee_msat: params.max_total_routing_fee_msat,
max_total_cltv_expiry_delta: params.max_total_cltv_expiry_delta,
max_path_count,
max_channel_saturation_power_of_half,
})
},
None => None,
};

let payment_id = match request.amount_msat {
None => context.node.bolt11_payment().send(&invoice, None),
None => context.node.bolt11_payment().send(&invoice, route_parameters),
Some(amount_msat) => {
context.node.bolt11_payment().send_using_amount(&invoice, amount_msat, None)
context.node.bolt11_payment().send_using_amount(&invoice, amount_msat, route_parameters)
},
}?;

Expand Down
41 changes: 37 additions & 4 deletions ldk-server/src/api/bolt12_send.rs
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
use crate::api::error::LdkServerError;
use crate::api::error::LdkServerErrorCode::InvalidRequestError;
use crate::service::Context;
use ldk_node::lightning::offers::offer::Offer;
use ldk_node::lightning::routing::router::RouteParametersConfig;
use ldk_server_protos::api::{Bolt12SendRequest, Bolt12SendResponse};
use std::str::FromStr;

Expand All@@ -12,16 +14,47 @@ pub(crate) fn handle_bolt12_send_request(
let offer =
Offer::from_str(&request.offer.as_str()).map_err(|_| ldk_node::NodeError::InvalidOffer)?;

let payment_id = match request.amount_msat {
None => {
context.node.bolt12_payment().send(&offer, request.quantity, request.payer_note, None)
let route_parameters = match request.route_parameters {
Some(params) => {
let max_path_count = params.max_path_count.try_into().map_err(|_| {
LdkServerError::new(
InvalidRequestError,
format!("Invalid max_path_count, must be between 0 and {}", u8::MAX),
)
})?;
let max_channel_saturation_power_of_half =
params.max_channel_saturation_power_of_half.try_into().map_err(|_| {
LdkServerError::new(
InvalidRequestError,
format!(
"Invalid max_channel_saturation_power_of_half, must be between 0 and {}",
u8::MAX
),
)
})?;
Some(RouteParametersConfig {
max_total_routing_fee_msat: params.max_total_routing_fee_msat,
max_total_cltv_expiry_delta: params.max_total_cltv_expiry_delta,
max_path_count,
max_channel_saturation_power_of_half,
})
},
None => None,
};

let payment_id = match request.amount_msat {
None => context.node.bolt12_payment().send(
&offer,
request.quantity,
request.payer_note,
route_parameters,
),
Some(amount_msat) => context.node.bolt12_payment().send_using_amount(
&offer,
amount_msat,
request.quantity,
request.payer_note,
None,
route_parameters,
),
}?;

Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Allow to set `SendingParameters` in BOLT11 & BOLT12 by Anyitechs · Pull Request #79 · lightningdevkit/ldk-server · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 73 additions & 4 deletions ldk-server-cli/src/main.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,11 +10,19 @@ use ldk_server_client::ldk_server_protos::api::{
ListChannelsRequest, ListPaymentsRequest, OnchainReceiveRequest, OnchainSendRequest,
OpenChannelRequest,
};
use ldk_server_client::ldk_server_protos::types::RouteParametersConfig;
use ldk_server_client::ldk_server_protos::types::{
bolt11_invoice_description, Bolt11InvoiceDescription, PageToken, Payment,
};
use std::fmt::Debug;

// Having these default values as constants in the Proto file and
// importing/reusing them here might be better, but Proto3 removed
// the ability to set default values.
const DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA: u32 = 1008;
const DEFAULT_MAX_PATH_COUNT: u32 = 10;
const DEFAULT_MAX_CHANNEL_SATURATION_POWER_OF_HALF: u32 = 2;

#[derive(Parser, Debug)]
#[command(version, about, long_about = None)]
struct Cli {
Expand DownExpand Up@@ -55,6 +63,14 @@ enum Commands {
invoice: String,
#[arg(long)]
amount_msat: Option<u64>,
#[arg(long)]
max_total_routing_fee_msat: Option<u64>,
#[arg(long)]
max_total_cltv_expiry_delta: Option<u32>,
#[arg(long)]
max_path_count: Option<u32>,
#[arg(long)]
max_channel_saturation_power_of_half: Option<u32>,
},
Bolt12Receive {
#[arg(short, long)]
Expand All@@ -75,6 +91,14 @@ enum Commands {
quantity: Option<u64>,
#[arg(short, long)]
payer_note: Option<String>,
#[arg(long)]
max_total_routing_fee_msat: Option<u64>,
#[arg(long)]
max_total_cltv_expiry_delta: Option<u32>,
#[arg(long)]
max_path_count: Option<u32>,
#[arg(long)]
max_channel_saturation_power_of_half: Option<u32>,
},
CloseChannel {
#[arg(short, long)]
Expand DownExpand Up@@ -161,9 +185,30 @@ async fn main() {

handle_response_result(client.bolt11_receive(request).await);
},
Commands::Bolt11Send { invoice, amount_msat } => {
Commands::Bolt11Send {
invoice,
amount_msat,
max_total_routing_fee_msat,
max_total_cltv_expiry_delta,
max_path_count,
max_channel_saturation_power_of_half,
} => {
let route_parameters = RouteParametersConfig {
max_total_routing_fee_msat,
max_total_cltv_expiry_delta: max_total_cltv_expiry_delta
.unwrap_or(DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA),
max_path_count: max_path_count.unwrap_or(DEFAULT_MAX_PATH_COUNT),
max_channel_saturation_power_of_half: max_channel_saturation_power_of_half
.unwrap_or(DEFAULT_MAX_CHANNEL_SATURATION_POWER_OF_HALF),
};
handle_response_result(
client.bolt11_send(Bolt11SendRequest { invoice, amount_msat }).await,
client
.bolt11_send(Bolt11SendRequest {
invoice,
amount_msat,
route_parameters: Some(route_parameters),
})
.await,
);
},
Commands::Bolt12Receive { description, amount_msat, expiry_secs, quantity } => {
Expand All@@ -178,10 +223,34 @@ async fn main() {
.await,
);
},
Commands::Bolt12Send { offer, amount_msat, quantity, payer_note } => {
Commands::Bolt12Send {
offer,
amount_msat,
quantity,
payer_note,
max_total_routing_fee_msat,
max_total_cltv_expiry_delta,
max_path_count,
max_channel_saturation_power_of_half,
} => {
let route_parameters = RouteParametersConfig {
max_total_routing_fee_msat,
max_total_cltv_expiry_delta: max_total_cltv_expiry_delta
.unwrap_or(DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA),
max_path_count: max_path_count.unwrap_or(DEFAULT_MAX_PATH_COUNT),
max_channel_saturation_power_of_half: max_channel_saturation_power_of_half
.unwrap_or(DEFAULT_MAX_CHANNEL_SATURATION_POWER_OF_HALF),
};

handle_response_result(
client
.bolt12_send(Bolt12SendRequest { offer, amount_msat, quantity, payer_note })
.bolt12_send(Bolt12SendRequest {
offer,
amount_msat,
quantity,
payer_note,
route_parameters: Some(route_parameters),
})
.await,
);
},
Expand Down
6 changes: 6 additions & 0 deletions ldk-server-protos/src/api.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -141,6 +141,9 @@ pub struct Bolt11SendRequest {
/// This operation will fail if the amount specified is less than the value required by the given invoice.
#[prost(uint64, optional, tag = "2")]
pub amount_msat: ::core::option::Option<u64>,
/// Configuration options for payment routing and pathfinding.
#[prost(message, optional, tag = "3")]
pub route_parameters: ::core::option::Option<super::types::RouteParametersConfig>,
}
/// The response `content` for the `Bolt11Send` API, when HttpStatusCode is OK (200).
/// When HttpStatusCode is not OK (non-200), the response `content` contains a serialized `ErrorResponse`.
Expand DownExpand Up@@ -205,6 +208,9 @@ pub struct Bolt12SendRequest {
/// If set, it will be seen by the recipient and reflected back in the invoice.
#[prost(string, optional, tag = "4")]
pub payer_note: ::core::option::Option<::prost::alloc::string::String>,
/// Configuration options for payment routing and pathfinding.
#[prost(message, optional, tag = "5")]
pub route_parameters: ::core::option::Option<super::types::RouteParametersConfig>,
}
/// The response `content` for the `Bolt12Send` API, when HttpStatusCode is OK (200).
/// When HttpStatusCode is not OK (non-200), the response `content` contains a serialized `ErrorResponse`.
Expand Down
6 changes: 6 additions & 0 deletions ldk-server-protos/src/proto/api.proto
Original file line numberDiff line numberDiff line change
Expand Up@@ -138,6 +138,9 @@ message Bolt11SendRequest {
// amount paid to be determined by the user.
// This operation will fail if the amount specified is less than the value required by the given invoice.
optional uint64 amount_msat = 2;

// Configuration options for payment routing and pathfinding.
optional types.RouteParametersConfig route_parameters = 3;

}

Expand DownExpand Up@@ -199,6 +202,9 @@ message Bolt12SendRequest {

// If set, it will be seen by the recipient and reflected back in the invoice.
optional string payer_note = 4;

// Configuration options for payment routing and pathfinding.
optional types.RouteParametersConfig route_parameters = 5;
}

// The response `content` for the `Bolt12Send` API, when HttpStatusCode is OK (200).
Expand Down
21 changes: 21 additions & 0 deletions ldk-server-protos/src/proto/types.proto
Original file line numberDiff line numberDiff line change
Expand Up@@ -683,3 +683,24 @@ message Bolt11InvoiceDescription {
string hash = 2;
}
}

// Configuration options for payment routing and pathfinding.
// See https://docs.rs/lightning/0.2.0/lightning/routing/router/struct.RouteParametersConfig.html for more details on each field.
message RouteParametersConfig {
// The maximum total fees, in millisatoshi, that may accrue during route finding.
// Defaults to 1% of the payment amount + 50 sats
optional uint64 max_total_routing_fee_msat = 1;

// The maximum total CLTV delta we accept for the route.
// Defaults to 1008.
uint32 max_total_cltv_expiry_delta = 2;

// The maximum number of paths that may be used by (MPP) payments.
// Defaults to 10.
uint32 max_path_count = 3;

// Selects the maximum share of a channel's total capacity which will be
// sent over a channel, as a power of 1/2.
// Default value: 2
uint32 max_channel_saturation_power_of_half = 4;
}
23 changes: 23 additions & 0 deletions ldk-server-protos/src/types.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -779,6 +779,29 @@ pub mod bolt11_invoice_description {
Hash(::prost::alloc::string::String),
}
}
/// Configuration options for payment routing and pathfinding.
/// See <https://docs.rs/lightning/0.2.0/lightning/routing/router/struct.RouteParametersConfig.html> for more details on each field.
#[allow(clippy::derive_partial_eq_without_eq)]
#[derive(Clone, PartialEq, ::prost::Message)]
pub struct RouteParametersConfig {
/// The maximum total fees, in millisatoshi, that may accrue during route finding.
/// Defaults to 1% of the payment amount + 50 sats
#[prost(uint64, optional, tag = "1")]
pub max_total_routing_fee_msat: ::core::option::Option<u64>,
/// The maximum total CLTV delta we accept for the route.
/// Defaults to 1008.
#[prost(uint32, tag = "2")]
pub max_total_cltv_expiry_delta: u32,
/// The maximum number of paths that may be used by (MPP) payments.
/// Defaults to 10.
#[prost(uint32, tag = "3")]
pub max_path_count: u32,
/// Selects the maximum share of a channel's total capacity which will be
/// sent over a channel, as a power of 1/2.
/// Default value: 2
#[prost(uint32, tag = "4")]
pub max_channel_saturation_power_of_half: u32,
}
/// Represents the direction of a payment.
#[derive(Clone, Copy, Debug, PartialEq, Eq, Hash, PartialOrd, Ord, ::prost::Enumeration)]
#[repr(i32)]
Expand Down
34 changes: 32 additions & 2 deletions ldk-server/src/api/bolt11_send.rs
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
use crate::api::error::LdkServerError;
use crate::api::error::LdkServerErrorCode::InvalidRequestError;
use crate::service::Context;
use ldk_node::lightning::routing::router::RouteParametersConfig;
use ldk_node::lightning_invoice::Bolt11Invoice;
use ldk_server_protos::api::{Bolt11SendRequest, Bolt11SendResponse};
use std::str::FromStr;
Expand All@@ -12,10 +14,38 @@ pub(crate) fn handle_bolt11_send_request(
let invoice = Bolt11Invoice::from_str(&request.invoice.as_str())
.map_err(|_| ldk_node::NodeError::InvalidInvoice)?;

let route_parameters = match request.route_parameters {
Some(params) => {
let max_path_count: u8 = params.max_path_count.try_into().map_err(|_| {
LdkServerError::new(
InvalidRequestError,
format!("Invalid max_path_count, must be between 0 and {}", u8::MAX),
)
})?;
let max_channel_saturation_power_of_half: u8 =
params.max_channel_saturation_power_of_half.try_into().map_err(|_| {
LdkServerError::new(
InvalidRequestError,
format!(
"Invalid max_channel_saturation_power_of_half, must be between 0 and {}",
u8::MAX
),
)
})?;
Some(RouteParametersConfig {
max_total_routing_fee_msat: params.max_total_routing_fee_msat,
max_total_cltv_expiry_delta: params.max_total_cltv_expiry_delta,
max_path_count,
max_channel_saturation_power_of_half,
})
},
None => None,
};

let payment_id = match request.amount_msat {
None => context.node.bolt11_payment().send(&invoice, None),
None => context.node.bolt11_payment().send(&invoice, route_parameters),
Some(amount_msat) => {
context.node.bolt11_payment().send_using_amount(&invoice, amount_msat, None)
context.node.bolt11_payment().send_using_amount(&invoice, amount_msat, route_parameters)
},
}?;

Expand Down
41 changes: 37 additions & 4 deletions ldk-server/src/api/bolt12_send.rs
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
use crate::api::error::LdkServerError;
use crate::api::error::LdkServerErrorCode::InvalidRequestError;
use crate::service::Context;
use ldk_node::lightning::offers::offer::Offer;
use ldk_node::lightning::routing::router::RouteParametersConfig;
use ldk_server_protos::api::{Bolt12SendRequest, Bolt12SendResponse};
use std::str::FromStr;

Expand All@@ -12,16 +14,47 @@ pub(crate) fn handle_bolt12_send_request(
let offer =
Offer::from_str(&request.offer.as_str()).map_err(|_| ldk_node::NodeError::InvalidOffer)?;

let payment_id = match request.amount_msat {
None => {
context.node.bolt12_payment().send(&offer, request.quantity, request.payer_note, None)
let route_parameters = match request.route_parameters {
Some(params) => {
let max_path_count = params.max_path_count.try_into().map_err(|_| {
LdkServerError::new(
InvalidRequestError,
format!("Invalid max_path_count, must be between 0 and {}", u8::MAX),
)
})?;
let max_channel_saturation_power_of_half =
params.max_channel_saturation_power_of_half.try_into().map_err(|_| {
LdkServerError::new(
InvalidRequestError,
format!(
"Invalid max_channel_saturation_power_of_half, must be between 0 and {}",
u8::MAX
),
)
})?;
Some(RouteParametersConfig {
max_total_routing_fee_msat: params.max_total_routing_fee_msat,
max_total_cltv_expiry_delta: params.max_total_cltv_expiry_delta,
max_path_count,
max_channel_saturation_power_of_half,
})
},
None => None,
};

let payment_id = match request.amount_msat {
None => context.node.bolt12_payment().send(
&offer,
request.quantity,
request.payer_note,
route_parameters,
),
Some(amount_msat) => context.node.bolt12_payment().send_using_amount(
&offer,
amount_msat,
request.quantity,
request.payer_note,
None,
route_parameters,
),
}?;

Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Allow to set `SendingParameters` in BOLT11 & BOLT12 by Anyitechs · Pull Request #79 · lightningdevkit/ldk-server · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 73 additions & 4 deletions ldk-server-cli/src/main.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,11 +10,19 @@ use ldk_server_client::ldk_server_protos::api::{
ListChannelsRequest, ListPaymentsRequest, OnchainReceiveRequest, OnchainSendRequest,
OpenChannelRequest,
};
use ldk_server_client::ldk_server_protos::types::RouteParametersConfig;
use ldk_server_client::ldk_server_protos::types::{
bolt11_invoice_description, Bolt11InvoiceDescription, PageToken, Payment,
};
use std::fmt::Debug;

// Having these default values as constants in the Proto file and
// importing/reusing them here might be better, but Proto3 removed
// the ability to set default values.
const DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA: u32 = 1008;
const DEFAULT_MAX_PATH_COUNT: u32 = 10;
const DEFAULT_MAX_CHANNEL_SATURATION_POWER_OF_HALF: u32 = 2;

#[derive(Parser, Debug)]
#[command(version, about, long_about = None)]
struct Cli {
Expand DownExpand Up@@ -55,6 +63,14 @@ enum Commands {
invoice: String,
#[arg(long)]
amount_msat: Option<u64>,
#[arg(long)]
max_total_routing_fee_msat: Option<u64>,
#[arg(long)]
max_total_cltv_expiry_delta: Option<u32>,
#[arg(long)]
max_path_count: Option<u32>,
#[arg(long)]
max_channel_saturation_power_of_half: Option<u32>,
},
Bolt12Receive {
#[arg(short, long)]
Expand All@@ -75,6 +91,14 @@ enum Commands {
quantity: Option<u64>,
#[arg(short, long)]
payer_note: Option<String>,
#[arg(long)]
max_total_routing_fee_msat: Option<u64>,
#[arg(long)]
max_total_cltv_expiry_delta: Option<u32>,
#[arg(long)]
max_path_count: Option<u32>,
#[arg(long)]
max_channel_saturation_power_of_half: Option<u32>,
},
CloseChannel {
#[arg(short, long)]
Expand DownExpand Up@@ -161,9 +185,30 @@ async fn main() {

handle_response_result(client.bolt11_receive(request).await);
},
Commands::Bolt11Send { invoice, amount_msat } => {
Commands::Bolt11Send {
invoice,
amount_msat,
max_total_routing_fee_msat,
max_total_cltv_expiry_delta,
max_path_count,
max_channel_saturation_power_of_half,
} => {
let route_parameters = RouteParametersConfig {
max_total_routing_fee_msat,
max_total_cltv_expiry_delta: max_total_cltv_expiry_delta
.unwrap_or(DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA),
max_path_count: max_path_count.unwrap_or(DEFAULT_MAX_PATH_COUNT),
max_channel_saturation_power_of_half: max_channel_saturation_power_of_half
.unwrap_or(DEFAULT_MAX_CHANNEL_SATURATION_POWER_OF_HALF),
};
handle_response_result(
client.bolt11_send(Bolt11SendRequest { invoice, amount_msat }).await,
client
.bolt11_send(Bolt11SendRequest {
invoice,
amount_msat,
route_parameters: Some(route_parameters),
})
.await,
);
},
Commands::Bolt12Receive { description, amount_msat, expiry_secs, quantity } => {
Expand All@@ -178,10 +223,34 @@ async fn main() {
.await,
);
},
Commands::Bolt12Send { offer, amount_msat, quantity, payer_note } => {
Commands::Bolt12Send {
offer,
amount_msat,
quantity,
payer_note,
max_total_routing_fee_msat,
max_total_cltv_expiry_delta,
max_path_count,
max_channel_saturation_power_of_half,
} => {
let route_parameters = RouteParametersConfig {
max_total_routing_fee_msat,
max_total_cltv_expiry_delta: max_total_cltv_expiry_delta
.unwrap_or(DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA),
max_path_count: max_path_count.unwrap_or(DEFAULT_MAX_PATH_COUNT),
max_channel_saturation_power_of_half: max_channel_saturation_power_of_half
.unwrap_or(DEFAULT_MAX_CHANNEL_SATURATION_POWER_OF_HALF),
};

handle_response_result(
client
.bolt12_send(Bolt12SendRequest { offer, amount_msat, quantity, payer_note })
.bolt12_send(Bolt12SendRequest {
offer,
amount_msat,
quantity,
payer_note,
route_parameters: Some(route_parameters),
})
.await,
);
},
Expand Down
6 changes: 6 additions & 0 deletions ldk-server-protos/src/api.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -141,6 +141,9 @@ pub struct Bolt11SendRequest {
/// This operation will fail if the amount specified is less than the value required by the given invoice.
#[prost(uint64, optional, tag = "2")]
pub amount_msat: ::core::option::Option<u64>,
/// Configuration options for payment routing and pathfinding.
#[prost(message, optional, tag = "3")]
pub route_parameters: ::core::option::Option<super::types::RouteParametersConfig>,
}
/// The response `content` for the `Bolt11Send` API, when HttpStatusCode is OK (200).
/// When HttpStatusCode is not OK (non-200), the response `content` contains a serialized `ErrorResponse`.
Expand DownExpand Up@@ -205,6 +208,9 @@ pub struct Bolt12SendRequest {
/// If set, it will be seen by the recipient and reflected back in the invoice.
#[prost(string, optional, tag = "4")]
pub payer_note: ::core::option::Option<::prost::alloc::string::String>,
/// Configuration options for payment routing and pathfinding.
#[prost(message, optional, tag = "5")]
pub route_parameters: ::core::option::Option<super::types::RouteParametersConfig>,
}
/// The response `content` for the `Bolt12Send` API, when HttpStatusCode is OK (200).
/// When HttpStatusCode is not OK (non-200), the response `content` contains a serialized `ErrorResponse`.
Expand Down
6 changes: 6 additions & 0 deletions ldk-server-protos/src/proto/api.proto
Original file line numberDiff line numberDiff line change
Expand Up@@ -138,6 +138,9 @@ message Bolt11SendRequest {
// amount paid to be determined by the user.
// This operation will fail if the amount specified is less than the value required by the given invoice.
optional uint64 amount_msat = 2;

// Configuration options for payment routing and pathfinding.
optional types.RouteParametersConfig route_parameters = 3;

}

Expand DownExpand Up@@ -199,6 +202,9 @@ message Bolt12SendRequest {

// If set, it will be seen by the recipient and reflected back in the invoice.
optional string payer_note = 4;

// Configuration options for payment routing and pathfinding.
optional types.RouteParametersConfig route_parameters = 5;
}

// The response `content` for the `Bolt12Send` API, when HttpStatusCode is OK (200).
Expand Down
21 changes: 21 additions & 0 deletions ldk-server-protos/src/proto/types.proto
Original file line numberDiff line numberDiff line change
Expand Up@@ -683,3 +683,24 @@ message Bolt11InvoiceDescription {
string hash = 2;
}
}

// Configuration options for payment routing and pathfinding.
// See https://docs.rs/lightning/0.2.0/lightning/routing/router/struct.RouteParametersConfig.html for more details on each field.
message RouteParametersConfig {
// The maximum total fees, in millisatoshi, that may accrue during route finding.
// Defaults to 1% of the payment amount + 50 sats
optional uint64 max_total_routing_fee_msat = 1;

// The maximum total CLTV delta we accept for the route.
// Defaults to 1008.
uint32 max_total_cltv_expiry_delta = 2;

// The maximum number of paths that may be used by (MPP) payments.
// Defaults to 10.
uint32 max_path_count = 3;

// Selects the maximum share of a channel's total capacity which will be
// sent over a channel, as a power of 1/2.
// Default value: 2
uint32 max_channel_saturation_power_of_half = 4;
}
23 changes: 23 additions & 0 deletions ldk-server-protos/src/types.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -779,6 +779,29 @@ pub mod bolt11_invoice_description {
Hash(::prost::alloc::string::String),
}
}
/// Configuration options for payment routing and pathfinding.
/// See <https://docs.rs/lightning/0.2.0/lightning/routing/router/struct.RouteParametersConfig.html> for more details on each field.
#[allow(clippy::derive_partial_eq_without_eq)]
#[derive(Clone, PartialEq, ::prost::Message)]
pub struct RouteParametersConfig {
/// The maximum total fees, in millisatoshi, that may accrue during route finding.
/// Defaults to 1% of the payment amount + 50 sats
#[prost(uint64, optional, tag = "1")]
pub max_total_routing_fee_msat: ::core::option::Option<u64>,
/// The maximum total CLTV delta we accept for the route.
/// Defaults to 1008.
#[prost(uint32, tag = "2")]
pub max_total_cltv_expiry_delta: u32,
/// The maximum number of paths that may be used by (MPP) payments.
/// Defaults to 10.
#[prost(uint32, tag = "3")]
pub max_path_count: u32,
/// Selects the maximum share of a channel's total capacity which will be
/// sent over a channel, as a power of 1/2.
/// Default value: 2
#[prost(uint32, tag = "4")]
pub max_channel_saturation_power_of_half: u32,
}
/// Represents the direction of a payment.
#[derive(Clone, Copy, Debug, PartialEq, Eq, Hash, PartialOrd, Ord, ::prost::Enumeration)]
#[repr(i32)]
Expand Down
34 changes: 32 additions & 2 deletions ldk-server/src/api/bolt11_send.rs
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
use crate::api::error::LdkServerError;
use crate::api::error::LdkServerErrorCode::InvalidRequestError;
use crate::service::Context;
use ldk_node::lightning::routing::router::RouteParametersConfig;
use ldk_node::lightning_invoice::Bolt11Invoice;
use ldk_server_protos::api::{Bolt11SendRequest, Bolt11SendResponse};
use std::str::FromStr;
Expand All@@ -12,10 +14,38 @@ pub(crate) fn handle_bolt11_send_request(
let invoice = Bolt11Invoice::from_str(&request.invoice.as_str())
.map_err(|_| ldk_node::NodeError::InvalidInvoice)?;

let route_parameters = match request.route_parameters {
Some(params) => {
let max_path_count: u8 = params.max_path_count.try_into().map_err(|_| {
LdkServerError::new(
InvalidRequestError,
format!("Invalid max_path_count, must be between 0 and {}", u8::MAX),
)
})?;
let max_channel_saturation_power_of_half: u8 =
params.max_channel_saturation_power_of_half.try_into().map_err(|_| {
LdkServerError::new(
InvalidRequestError,
format!(
"Invalid max_channel_saturation_power_of_half, must be between 0 and {}",
u8::MAX
),
)
})?;
Some(RouteParametersConfig {
max_total_routing_fee_msat: params.max_total_routing_fee_msat,
max_total_cltv_expiry_delta: params.max_total_cltv_expiry_delta,
max_path_count,
max_channel_saturation_power_of_half,
})
},
None => None,
};

let payment_id = match request.amount_msat {
None => context.node.bolt11_payment().send(&invoice, None),
None => context.node.bolt11_payment().send(&invoice, route_parameters),
Some(amount_msat) => {
context.node.bolt11_payment().send_using_amount(&invoice, amount_msat, None)
context.node.bolt11_payment().send_using_amount(&invoice, amount_msat, route_parameters)
},
}?;

Expand Down
41 changes: 37 additions & 4 deletions ldk-server/src/api/bolt12_send.rs
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
use crate::api::error::LdkServerError;
use crate::api::error::LdkServerErrorCode::InvalidRequestError;
use crate::service::Context;
use ldk_node::lightning::offers::offer::Offer;
use ldk_node::lightning::routing::router::RouteParametersConfig;
use ldk_server_protos::api::{Bolt12SendRequest, Bolt12SendResponse};
use std::str::FromStr;

Expand All@@ -12,16 +14,47 @@ pub(crate) fn handle_bolt12_send_request(
let offer =
Offer::from_str(&request.offer.as_str()).map_err(|_| ldk_node::NodeError::InvalidOffer)?;

let payment_id = match request.amount_msat {
None => {
context.node.bolt12_payment().send(&offer, request.quantity, request.payer_note, None)
let route_parameters = match request.route_parameters {
Some(params) => {
let max_path_count = params.max_path_count.try_into().map_err(|_| {
LdkServerError::new(
InvalidRequestError,
format!("Invalid max_path_count, must be between 0 and {}", u8::MAX),
)
})?;
let max_channel_saturation_power_of_half =
params.max_channel_saturation_power_of_half.try_into().map_err(|_| {
LdkServerError::new(
InvalidRequestError,
format!(
"Invalid max_channel_saturation_power_of_half, must be between 0 and {}",
u8::MAX
),
)
})?;
Some(RouteParametersConfig {
max_total_routing_fee_msat: params.max_total_routing_fee_msat,
max_total_cltv_expiry_delta: params.max_total_cltv_expiry_delta,
max_path_count,
max_channel_saturation_power_of_half,
})
},
None => None,
};

let payment_id = match request.amount_msat {
None => context.node.bolt12_payment().send(
&offer,
request.quantity,
request.payer_note,
route_parameters,
),
Some(amount_msat) => context.node.bolt12_payment().send_using_amount(
&offer,
amount_msat,
request.quantity,
request.payer_note,
None,
route_parameters,
),
}?;

Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Allow to set `SendingParameters` in BOLT11 & BOLT12 by Anyitechs · Pull Request #79 · lightningdevkit/ldk-server · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 73 additions & 4 deletions ldk-server-cli/src/main.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,11 +10,19 @@ use ldk_server_client::ldk_server_protos::api::{
ListChannelsRequest, ListPaymentsRequest, OnchainReceiveRequest, OnchainSendRequest,
OpenChannelRequest,
};
use ldk_server_client::ldk_server_protos::types::RouteParametersConfig;
use ldk_server_client::ldk_server_protos::types::{
bolt11_invoice_description, Bolt11InvoiceDescription, PageToken, Payment,
};
use std::fmt::Debug;

// Having these default values as constants in the Proto file and
// importing/reusing them here might be better, but Proto3 removed
// the ability to set default values.
const DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA: u32 = 1008;
const DEFAULT_MAX_PATH_COUNT: u32 = 10;
const DEFAULT_MAX_CHANNEL_SATURATION_POWER_OF_HALF: u32 = 2;

#[derive(Parser, Debug)]
#[command(version, about, long_about = None)]
struct Cli {
Expand DownExpand Up@@ -55,6 +63,14 @@ enum Commands {
invoice: String,
#[arg(long)]
amount_msat: Option<u64>,
#[arg(long)]
max_total_routing_fee_msat: Option<u64>,
#[arg(long)]
max_total_cltv_expiry_delta: Option<u32>,
#[arg(long)]
max_path_count: Option<u32>,
#[arg(long)]
max_channel_saturation_power_of_half: Option<u32>,
},
Bolt12Receive {
#[arg(short, long)]
Expand All@@ -75,6 +91,14 @@ enum Commands {
quantity: Option<u64>,
#[arg(short, long)]
payer_note: Option<String>,
#[arg(long)]
max_total_routing_fee_msat: Option<u64>,
#[arg(long)]
max_total_cltv_expiry_delta: Option<u32>,
#[arg(long)]
max_path_count: Option<u32>,
#[arg(long)]
max_channel_saturation_power_of_half: Option<u32>,
},
CloseChannel {
#[arg(short, long)]
Expand DownExpand Up@@ -161,9 +185,30 @@ async fn main() {

handle_response_result(client.bolt11_receive(request).await);
},
Commands::Bolt11Send { invoice, amount_msat } => {
Commands::Bolt11Send {
invoice,
amount_msat,
max_total_routing_fee_msat,
max_total_cltv_expiry_delta,
max_path_count,
max_channel_saturation_power_of_half,
} => {
let route_parameters = RouteParametersConfig {
max_total_routing_fee_msat,
max_total_cltv_expiry_delta: max_total_cltv_expiry_delta
.unwrap_or(DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA),
max_path_count: max_path_count.unwrap_or(DEFAULT_MAX_PATH_COUNT),
max_channel_saturation_power_of_half: max_channel_saturation_power_of_half
.unwrap_or(DEFAULT_MAX_CHANNEL_SATURATION_POWER_OF_HALF),
};
handle_response_result(
client.bolt11_send(Bolt11SendRequest { invoice, amount_msat }).await,
client
.bolt11_send(Bolt11SendRequest {
invoice,
amount_msat,
route_parameters: Some(route_parameters),
})
.await,
);
},
Commands::Bolt12Receive { description, amount_msat, expiry_secs, quantity } => {
Expand All@@ -178,10 +223,34 @@ async fn main() {
.await,
);
},
Commands::Bolt12Send { offer, amount_msat, quantity, payer_note } => {
Commands::Bolt12Send {
offer,
amount_msat,
quantity,
payer_note,
max_total_routing_fee_msat,
max_total_cltv_expiry_delta,
max_path_count,
max_channel_saturation_power_of_half,
} => {
let route_parameters = RouteParametersConfig {
max_total_routing_fee_msat,
max_total_cltv_expiry_delta: max_total_cltv_expiry_delta
.unwrap_or(DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA),
max_path_count: max_path_count.unwrap_or(DEFAULT_MAX_PATH_COUNT),
max_channel_saturation_power_of_half: max_channel_saturation_power_of_half
.unwrap_or(DEFAULT_MAX_CHANNEL_SATURATION_POWER_OF_HALF),
};

handle_response_result(
client
.bolt12_send(Bolt12SendRequest { offer, amount_msat, quantity, payer_note })
.bolt12_send(Bolt12SendRequest {
offer,
amount_msat,
quantity,
payer_note,
route_parameters: Some(route_parameters),
})
.await,
);
},
Expand Down
6 changes: 6 additions & 0 deletions ldk-server-protos/src/api.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -141,6 +141,9 @@ pub struct Bolt11SendRequest {
/// This operation will fail if the amount specified is less than the value required by the given invoice.
#[prost(uint64, optional, tag = "2")]
pub amount_msat: ::core::option::Option<u64>,
/// Configuration options for payment routing and pathfinding.
#[prost(message, optional, tag = "3")]
pub route_parameters: ::core::option::Option<super::types::RouteParametersConfig>,
}
/// The response `content` for the `Bolt11Send` API, when HttpStatusCode is OK (200).
/// When HttpStatusCode is not OK (non-200), the response `content` contains a serialized `ErrorResponse`.
Expand DownExpand Up@@ -205,6 +208,9 @@ pub struct Bolt12SendRequest {
/// If set, it will be seen by the recipient and reflected back in the invoice.
#[prost(string, optional, tag = "4")]
pub payer_note: ::core::option::Option<::prost::alloc::string::String>,
/// Configuration options for payment routing and pathfinding.
#[prost(message, optional, tag = "5")]
pub route_parameters: ::core::option::Option<super::types::RouteParametersConfig>,
}
/// The response `content` for the `Bolt12Send` API, when HttpStatusCode is OK (200).
/// When HttpStatusCode is not OK (non-200), the response `content` contains a serialized `ErrorResponse`.
Expand Down
6 changes: 6 additions & 0 deletions ldk-server-protos/src/proto/api.proto
Original file line numberDiff line numberDiff line change
Expand Up@@ -138,6 +138,9 @@ message Bolt11SendRequest {
// amount paid to be determined by the user.
// This operation will fail if the amount specified is less than the value required by the given invoice.
optional uint64 amount_msat = 2;

// Configuration options for payment routing and pathfinding.
optional types.RouteParametersConfig route_parameters = 3;

}

Expand DownExpand Up@@ -199,6 +202,9 @@ message Bolt12SendRequest {

// If set, it will be seen by the recipient and reflected back in the invoice.
optional string payer_note = 4;

// Configuration options for payment routing and pathfinding.
optional types.RouteParametersConfig route_parameters = 5;
}

// The response `content` for the `Bolt12Send` API, when HttpStatusCode is OK (200).
Expand Down
21 changes: 21 additions & 0 deletions ldk-server-protos/src/proto/types.proto
Original file line numberDiff line numberDiff line change
Expand Up@@ -683,3 +683,24 @@ message Bolt11InvoiceDescription {
string hash = 2;
}
}

// Configuration options for payment routing and pathfinding.
// See https://docs.rs/lightning/0.2.0/lightning/routing/router/struct.RouteParametersConfig.html for more details on each field.
message RouteParametersConfig {
// The maximum total fees, in millisatoshi, that may accrue during route finding.
// Defaults to 1% of the payment amount + 50 sats
optional uint64 max_total_routing_fee_msat = 1;

// The maximum total CLTV delta we accept for the route.
// Defaults to 1008.
uint32 max_total_cltv_expiry_delta = 2;

// The maximum number of paths that may be used by (MPP) payments.
// Defaults to 10.
uint32 max_path_count = 3;

// Selects the maximum share of a channel's total capacity which will be
// sent over a channel, as a power of 1/2.
// Default value: 2
uint32 max_channel_saturation_power_of_half = 4;
}
23 changes: 23 additions & 0 deletions ldk-server-protos/src/types.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -779,6 +779,29 @@ pub mod bolt11_invoice_description {
Hash(::prost::alloc::string::String),
}
}
/// Configuration options for payment routing and pathfinding.
/// See <https://docs.rs/lightning/0.2.0/lightning/routing/router/struct.RouteParametersConfig.html> for more details on each field.
#[allow(clippy::derive_partial_eq_without_eq)]
#[derive(Clone, PartialEq, ::prost::Message)]
pub struct RouteParametersConfig {
/// The maximum total fees, in millisatoshi, that may accrue during route finding.
/// Defaults to 1% of the payment amount + 50 sats
#[prost(uint64, optional, tag = "1")]
pub max_total_routing_fee_msat: ::core::option::Option<u64>,
/// The maximum total CLTV delta we accept for the route.
/// Defaults to 1008.
#[prost(uint32, tag = "2")]
pub max_total_cltv_expiry_delta: u32,
/// The maximum number of paths that may be used by (MPP) payments.
/// Defaults to 10.
#[prost(uint32, tag = "3")]
pub max_path_count: u32,
/// Selects the maximum share of a channel's total capacity which will be
/// sent over a channel, as a power of 1/2.
/// Default value: 2
#[prost(uint32, tag = "4")]
pub max_channel_saturation_power_of_half: u32,
}
/// Represents the direction of a payment.
#[derive(Clone, Copy, Debug, PartialEq, Eq, Hash, PartialOrd, Ord, ::prost::Enumeration)]
#[repr(i32)]
Expand Down
34 changes: 32 additions & 2 deletions ldk-server/src/api/bolt11_send.rs
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
use crate::api::error::LdkServerError;
use crate::api::error::LdkServerErrorCode::InvalidRequestError;
use crate::service::Context;
use ldk_node::lightning::routing::router::RouteParametersConfig;
use ldk_node::lightning_invoice::Bolt11Invoice;
use ldk_server_protos::api::{Bolt11SendRequest, Bolt11SendResponse};
use std::str::FromStr;
Expand All@@ -12,10 +14,38 @@ pub(crate) fn handle_bolt11_send_request(
let invoice = Bolt11Invoice::from_str(&request.invoice.as_str())
.map_err(|_| ldk_node::NodeError::InvalidInvoice)?;

let route_parameters = match request.route_parameters {
Some(params) => {
let max_path_count: u8 = params.max_path_count.try_into().map_err(|_| {
LdkServerError::new(
InvalidRequestError,
format!("Invalid max_path_count, must be between 0 and {}", u8::MAX),
)
})?;
let max_channel_saturation_power_of_half: u8 =
params.max_channel_saturation_power_of_half.try_into().map_err(|_| {
LdkServerError::new(
InvalidRequestError,
format!(
"Invalid max_channel_saturation_power_of_half, must be between 0 and {}",
u8::MAX
),
)
})?;
Some(RouteParametersConfig {
max_total_routing_fee_msat: params.max_total_routing_fee_msat,
max_total_cltv_expiry_delta: params.max_total_cltv_expiry_delta,
max_path_count,
max_channel_saturation_power_of_half,
})
},
None => None,
};

let payment_id = match request.amount_msat {
None => context.node.bolt11_payment().send(&invoice, None),
None => context.node.bolt11_payment().send(&invoice, route_parameters),
Some(amount_msat) => {
context.node.bolt11_payment().send_using_amount(&invoice, amount_msat, None)
context.node.bolt11_payment().send_using_amount(&invoice, amount_msat, route_parameters)
},
}?;

Expand Down
41 changes: 37 additions & 4 deletions ldk-server/src/api/bolt12_send.rs
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
use crate::api::error::LdkServerError;
use crate::api::error::LdkServerErrorCode::InvalidRequestError;
use crate::service::Context;
use ldk_node::lightning::offers::offer::Offer;
use ldk_node::lightning::routing::router::RouteParametersConfig;
use ldk_server_protos::api::{Bolt12SendRequest, Bolt12SendResponse};
use std::str::FromStr;

Expand All@@ -12,16 +14,47 @@ pub(crate) fn handle_bolt12_send_request(
let offer =
Offer::from_str(&request.offer.as_str()).map_err(|_| ldk_node::NodeError::InvalidOffer)?;

let payment_id = match request.amount_msat {
None => {
context.node.bolt12_payment().send(&offer, request.quantity, request.payer_note, None)
let route_parameters = match request.route_parameters {
Some(params) => {
let max_path_count = params.max_path_count.try_into().map_err(|_| {
LdkServerError::new(
InvalidRequestError,
format!("Invalid max_path_count, must be between 0 and {}", u8::MAX),
)
})?;
let max_channel_saturation_power_of_half =
params.max_channel_saturation_power_of_half.try_into().map_err(|_| {
LdkServerError::new(
InvalidRequestError,
format!(
"Invalid max_channel_saturation_power_of_half, must be between 0 and {}",
u8::MAX
),
)
})?;
Some(RouteParametersConfig {
max_total_routing_fee_msat: params.max_total_routing_fee_msat,
max_total_cltv_expiry_delta: params.max_total_cltv_expiry_delta,
max_path_count,
max_channel_saturation_power_of_half,
})
},
None => None,
};

let payment_id = match request.amount_msat {
None => context.node.bolt12_payment().send(
&offer,
request.quantity,
request.payer_note,
route_parameters,
),
Some(amount_msat) => context.node.bolt12_payment().send_using_amount(
&offer,
amount_msat,
request.quantity,
request.payer_note,
None,
route_parameters,
),
}?;

Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Allow to set `SendingParameters` in BOLT11 & BOLT12 by Anyitechs · Pull Request #79 · lightningdevkit/ldk-server · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 73 additions & 4 deletions ldk-server-cli/src/main.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,11 +10,19 @@ use ldk_server_client::ldk_server_protos::api::{
ListChannelsRequest, ListPaymentsRequest, OnchainReceiveRequest, OnchainSendRequest,
OpenChannelRequest,
};
use ldk_server_client::ldk_server_protos::types::RouteParametersConfig;
use ldk_server_client::ldk_server_protos::types::{
bolt11_invoice_description, Bolt11InvoiceDescription, PageToken, Payment,
};
use std::fmt::Debug;

// Having these default values as constants in the Proto file and
// importing/reusing them here might be better, but Proto3 removed
// the ability to set default values.
const DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA: u32 = 1008;
const DEFAULT_MAX_PATH_COUNT: u32 = 10;
const DEFAULT_MAX_CHANNEL_SATURATION_POWER_OF_HALF: u32 = 2;

#[derive(Parser, Debug)]
#[command(version, about, long_about = None)]
struct Cli {
Expand DownExpand Up@@ -55,6 +63,14 @@ enum Commands {
invoice: String,
#[arg(long)]
amount_msat: Option<u64>,
#[arg(long)]
max_total_routing_fee_msat: Option<u64>,
#[arg(long)]
max_total_cltv_expiry_delta: Option<u32>,
#[arg(long)]
max_path_count: Option<u32>,
#[arg(long)]
max_channel_saturation_power_of_half: Option<u32>,
},
Bolt12Receive {
#[arg(short, long)]
Expand All@@ -75,6 +91,14 @@ enum Commands {
quantity: Option<u64>,
#[arg(short, long)]
payer_note: Option<String>,
#[arg(long)]
max_total_routing_fee_msat: Option<u64>,
#[arg(long)]
max_total_cltv_expiry_delta: Option<u32>,
#[arg(long)]
max_path_count: Option<u32>,
#[arg(long)]
max_channel_saturation_power_of_half: Option<u32>,
},
CloseChannel {
#[arg(short, long)]
Expand DownExpand Up@@ -161,9 +185,30 @@ async fn main() {

handle_response_result(client.bolt11_receive(request).await);
},
Commands::Bolt11Send { invoice, amount_msat } => {
Commands::Bolt11Send {
invoice,
amount_msat,
max_total_routing_fee_msat,
max_total_cltv_expiry_delta,
max_path_count,
max_channel_saturation_power_of_half,
} => {
let route_parameters = RouteParametersConfig {
max_total_routing_fee_msat,
max_total_cltv_expiry_delta: max_total_cltv_expiry_delta
.unwrap_or(DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA),
max_path_count: max_path_count.unwrap_or(DEFAULT_MAX_PATH_COUNT),
max_channel_saturation_power_of_half: max_channel_saturation_power_of_half
.unwrap_or(DEFAULT_MAX_CHANNEL_SATURATION_POWER_OF_HALF),
};
handle_response_result(
client.bolt11_send(Bolt11SendRequest { invoice, amount_msat }).await,
client
.bolt11_send(Bolt11SendRequest {
invoice,
amount_msat,
route_parameters: Some(route_parameters),
})
.await,
);
},
Commands::Bolt12Receive { description, amount_msat, expiry_secs, quantity } => {
Expand All@@ -178,10 +223,34 @@ async fn main() {
.await,
);
},
Commands::Bolt12Send { offer, amount_msat, quantity, payer_note } => {
Commands::Bolt12Send {
offer,
amount_msat,
quantity,
payer_note,
max_total_routing_fee_msat,
max_total_cltv_expiry_delta,
max_path_count,
max_channel_saturation_power_of_half,
} => {
let route_parameters = RouteParametersConfig {
max_total_routing_fee_msat,
max_total_cltv_expiry_delta: max_total_cltv_expiry_delta
.unwrap_or(DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA),
max_path_count: max_path_count.unwrap_or(DEFAULT_MAX_PATH_COUNT),
max_channel_saturation_power_of_half: max_channel_saturation_power_of_half
.unwrap_or(DEFAULT_MAX_CHANNEL_SATURATION_POWER_OF_HALF),
};

handle_response_result(
client
.bolt12_send(Bolt12SendRequest { offer, amount_msat, quantity, payer_note })
.bolt12_send(Bolt12SendRequest {
offer,
amount_msat,
quantity,
payer_note,
route_parameters: Some(route_parameters),
})
.await,
);
},
Expand Down
6 changes: 6 additions & 0 deletions ldk-server-protos/src/api.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -141,6 +141,9 @@ pub struct Bolt11SendRequest {
/// This operation will fail if the amount specified is less than the value required by the given invoice.
#[prost(uint64, optional, tag = "2")]
pub amount_msat: ::core::option::Option<u64>,
/// Configuration options for payment routing and pathfinding.
#[prost(message, optional, tag = "3")]
pub route_parameters: ::core::option::Option<super::types::RouteParametersConfig>,
}
/// The response `content` for the `Bolt11Send` API, when HttpStatusCode is OK (200).
/// When HttpStatusCode is not OK (non-200), the response `content` contains a serialized `ErrorResponse`.
Expand DownExpand Up@@ -205,6 +208,9 @@ pub struct Bolt12SendRequest {
/// If set, it will be seen by the recipient and reflected back in the invoice.
#[prost(string, optional, tag = "4")]
pub payer_note: ::core::option::Option<::prost::alloc::string::String>,
/// Configuration options for payment routing and pathfinding.
#[prost(message, optional, tag = "5")]
pub route_parameters: ::core::option::Option<super::types::RouteParametersConfig>,
}
/// The response `content` for the `Bolt12Send` API, when HttpStatusCode is OK (200).
/// When HttpStatusCode is not OK (non-200), the response `content` contains a serialized `ErrorResponse`.
Expand Down
6 changes: 6 additions & 0 deletions ldk-server-protos/src/proto/api.proto
Original file line numberDiff line numberDiff line change
Expand Up@@ -138,6 +138,9 @@ message Bolt11SendRequest {
// amount paid to be determined by the user.
// This operation will fail if the amount specified is less than the value required by the given invoice.
optional uint64 amount_msat = 2;

// Configuration options for payment routing and pathfinding.
optional types.RouteParametersConfig route_parameters = 3;

}

Expand DownExpand Up@@ -199,6 +202,9 @@ message Bolt12SendRequest {

// If set, it will be seen by the recipient and reflected back in the invoice.
optional string payer_note = 4;

// Configuration options for payment routing and pathfinding.
optional types.RouteParametersConfig route_parameters = 5;
}

// The response `content` for the `Bolt12Send` API, when HttpStatusCode is OK (200).
Expand Down
21 changes: 21 additions & 0 deletions ldk-server-protos/src/proto/types.proto
Original file line numberDiff line numberDiff line change
Expand Up@@ -683,3 +683,24 @@ message Bolt11InvoiceDescription {
string hash = 2;
}
}

// Configuration options for payment routing and pathfinding.
// See https://docs.rs/lightning/0.2.0/lightning/routing/router/struct.RouteParametersConfig.html for more details on each field.
message RouteParametersConfig {
// The maximum total fees, in millisatoshi, that may accrue during route finding.
// Defaults to 1% of the payment amount + 50 sats
optional uint64 max_total_routing_fee_msat = 1;

// The maximum total CLTV delta we accept for the route.
// Defaults to 1008.
uint32 max_total_cltv_expiry_delta = 2;

// The maximum number of paths that may be used by (MPP) payments.
// Defaults to 10.
uint32 max_path_count = 3;

// Selects the maximum share of a channel's total capacity which will be
// sent over a channel, as a power of 1/2.
// Default value: 2
uint32 max_channel_saturation_power_of_half = 4;
}
23 changes: 23 additions & 0 deletions ldk-server-protos/src/types.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -779,6 +779,29 @@ pub mod bolt11_invoice_description {
Hash(::prost::alloc::string::String),
}
}
/// Configuration options for payment routing and pathfinding.
/// See <https://docs.rs/lightning/0.2.0/lightning/routing/router/struct.RouteParametersConfig.html> for more details on each field.
#[allow(clippy::derive_partial_eq_without_eq)]
#[derive(Clone, PartialEq, ::prost::Message)]
pub struct RouteParametersConfig {
/// The maximum total fees, in millisatoshi, that may accrue during route finding.
/// Defaults to 1% of the payment amount + 50 sats
#[prost(uint64, optional, tag = "1")]
pub max_total_routing_fee_msat: ::core::option::Option<u64>,
/// The maximum total CLTV delta we accept for the route.
/// Defaults to 1008.
#[prost(uint32, tag = "2")]
pub max_total_cltv_expiry_delta: u32,
/// The maximum number of paths that may be used by (MPP) payments.
/// Defaults to 10.
#[prost(uint32, tag = "3")]
pub max_path_count: u32,
/// Selects the maximum share of a channel's total capacity which will be
/// sent over a channel, as a power of 1/2.
/// Default value: 2
#[prost(uint32, tag = "4")]
pub max_channel_saturation_power_of_half: u32,
}
/// Represents the direction of a payment.
#[derive(Clone, Copy, Debug, PartialEq, Eq, Hash, PartialOrd, Ord, ::prost::Enumeration)]
#[repr(i32)]
Expand Down
34 changes: 32 additions & 2 deletions ldk-server/src/api/bolt11_send.rs
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
use crate::api::error::LdkServerError;
use crate::api::error::LdkServerErrorCode::InvalidRequestError;
use crate::service::Context;
use ldk_node::lightning::routing::router::RouteParametersConfig;
use ldk_node::lightning_invoice::Bolt11Invoice;
use ldk_server_protos::api::{Bolt11SendRequest, Bolt11SendResponse};
use std::str::FromStr;
Expand All@@ -12,10 +14,38 @@ pub(crate) fn handle_bolt11_send_request(
let invoice = Bolt11Invoice::from_str(&request.invoice.as_str())
.map_err(|_| ldk_node::NodeError::InvalidInvoice)?;

let route_parameters = match request.route_parameters {
Some(params) => {
let max_path_count: u8 = params.max_path_count.try_into().map_err(|_| {
LdkServerError::new(
InvalidRequestError,
format!("Invalid max_path_count, must be between 0 and {}", u8::MAX),
)
})?;
let max_channel_saturation_power_of_half: u8 =
params.max_channel_saturation_power_of_half.try_into().map_err(|_| {
LdkServerError::new(
InvalidRequestError,
format!(
"Invalid max_channel_saturation_power_of_half, must be between 0 and {}",
u8::MAX
),
)
})?;
Some(RouteParametersConfig {
max_total_routing_fee_msat: params.max_total_routing_fee_msat,
max_total_cltv_expiry_delta: params.max_total_cltv_expiry_delta,
max_path_count,
max_channel_saturation_power_of_half,
})
},
None => None,
};

let payment_id = match request.amount_msat {
None => context.node.bolt11_payment().send(&invoice, None),
None => context.node.bolt11_payment().send(&invoice, route_parameters),
Some(amount_msat) => {
context.node.bolt11_payment().send_using_amount(&invoice, amount_msat, None)
context.node.bolt11_payment().send_using_amount(&invoice, amount_msat, route_parameters)
},
}?;

Expand Down
41 changes: 37 additions & 4 deletions ldk-server/src/api/bolt12_send.rs
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
use crate::api::error::LdkServerError;
use crate::api::error::LdkServerErrorCode::InvalidRequestError;
use crate::service::Context;
use ldk_node::lightning::offers::offer::Offer;
use ldk_node::lightning::routing::router::RouteParametersConfig;
use ldk_server_protos::api::{Bolt12SendRequest, Bolt12SendResponse};
use std::str::FromStr;

Expand All@@ -12,16 +14,47 @@ pub(crate) fn handle_bolt12_send_request(
let offer =
Offer::from_str(&request.offer.as_str()).map_err(|_| ldk_node::NodeError::InvalidOffer)?;

let payment_id = match request.amount_msat {
None => {
context.node.bolt12_payment().send(&offer, request.quantity, request.payer_note, None)
let route_parameters = match request.route_parameters {
Some(params) => {
let max_path_count = params.max_path_count.try_into().map_err(|_| {
LdkServerError::new(
InvalidRequestError,
format!("Invalid max_path_count, must be between 0 and {}", u8::MAX),
)
})?;
let max_channel_saturation_power_of_half =
params.max_channel_saturation_power_of_half.try_into().map_err(|_| {
LdkServerError::new(
InvalidRequestError,
format!(
"Invalid max_channel_saturation_power_of_half, must be between 0 and {}",
u8::MAX
),
)
})?;
Some(RouteParametersConfig {
max_total_routing_fee_msat: params.max_total_routing_fee_msat,
max_total_cltv_expiry_delta: params.max_total_cltv_expiry_delta,
max_path_count,
max_channel_saturation_power_of_half,
})
},
None => None,
};

let payment_id = match request.amount_msat {
None => context.node.bolt12_payment().send(
&offer,
request.quantity,
request.payer_note,
route_parameters,
),
Some(amount_msat) => context.node.bolt12_payment().send_using_amount(
&offer,
amount_msat,
request.quantity,
request.payer_note,
None,
route_parameters,
),
}?;

Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Allow to set `SendingParameters` in BOLT11 & BOLT12 by Anyitechs · Pull Request #79 · lightningdevkit/ldk-server · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 73 additions & 4 deletions ldk-server-cli/src/main.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,11 +10,19 @@ use ldk_server_client::ldk_server_protos::api::{
ListChannelsRequest, ListPaymentsRequest, OnchainReceiveRequest, OnchainSendRequest,
OpenChannelRequest,
};
use ldk_server_client::ldk_server_protos::types::RouteParametersConfig;
use ldk_server_client::ldk_server_protos::types::{
bolt11_invoice_description, Bolt11InvoiceDescription, PageToken, Payment,
};
use std::fmt::Debug;

// Having these default values as constants in the Proto file and
// importing/reusing them here might be better, but Proto3 removed
// the ability to set default values.
const DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA: u32 = 1008;
const DEFAULT_MAX_PATH_COUNT: u32 = 10;
const DEFAULT_MAX_CHANNEL_SATURATION_POWER_OF_HALF: u32 = 2;

#[derive(Parser, Debug)]
#[command(version, about, long_about = None)]
struct Cli {
Expand DownExpand Up@@ -55,6 +63,14 @@ enum Commands {
invoice: String,
#[arg(long)]
amount_msat: Option<u64>,
#[arg(long)]
max_total_routing_fee_msat: Option<u64>,
#[arg(long)]
max_total_cltv_expiry_delta: Option<u32>,
#[arg(long)]
max_path_count: Option<u32>,
#[arg(long)]
max_channel_saturation_power_of_half: Option<u32>,
},
Bolt12Receive {
#[arg(short, long)]
Expand All@@ -75,6 +91,14 @@ enum Commands {
quantity: Option<u64>,
#[arg(short, long)]
payer_note: Option<String>,
#[arg(long)]
max_total_routing_fee_msat: Option<u64>,
#[arg(long)]
max_total_cltv_expiry_delta: Option<u32>,
#[arg(long)]
max_path_count: Option<u32>,
#[arg(long)]
max_channel_saturation_power_of_half: Option<u32>,
},
CloseChannel {
#[arg(short, long)]
Expand DownExpand Up@@ -161,9 +185,30 @@ async fn main() {

handle_response_result(client.bolt11_receive(request).await);
},
Commands::Bolt11Send { invoice, amount_msat } => {
Commands::Bolt11Send {
invoice,
amount_msat,
max_total_routing_fee_msat,
max_total_cltv_expiry_delta,
max_path_count,
max_channel_saturation_power_of_half,
} => {
let route_parameters = RouteParametersConfig {
max_total_routing_fee_msat,
max_total_cltv_expiry_delta: max_total_cltv_expiry_delta
.unwrap_or(DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA),
max_path_count: max_path_count.unwrap_or(DEFAULT_MAX_PATH_COUNT),
max_channel_saturation_power_of_half: max_channel_saturation_power_of_half
.unwrap_or(DEFAULT_MAX_CHANNEL_SATURATION_POWER_OF_HALF),
};
handle_response_result(
client.bolt11_send(Bolt11SendRequest { invoice, amount_msat }).await,
client
.bolt11_send(Bolt11SendRequest {
invoice,
amount_msat,
route_parameters: Some(route_parameters),
})
.await,
);
},
Commands::Bolt12Receive { description, amount_msat, expiry_secs, quantity } => {
Expand All@@ -178,10 +223,34 @@ async fn main() {
.await,
);
},
Commands::Bolt12Send { offer, amount_msat, quantity, payer_note } => {
Commands::Bolt12Send {
offer,
amount_msat,
quantity,
payer_note,
max_total_routing_fee_msat,
max_total_cltv_expiry_delta,
max_path_count,
max_channel_saturation_power_of_half,
} => {
let route_parameters = RouteParametersConfig {
max_total_routing_fee_msat,
max_total_cltv_expiry_delta: max_total_cltv_expiry_delta
.unwrap_or(DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA),
max_path_count: max_path_count.unwrap_or(DEFAULT_MAX_PATH_COUNT),
max_channel_saturation_power_of_half: max_channel_saturation_power_of_half
.unwrap_or(DEFAULT_MAX_CHANNEL_SATURATION_POWER_OF_HALF),
};

handle_response_result(
client
.bolt12_send(Bolt12SendRequest { offer, amount_msat, quantity, payer_note })
.bolt12_send(Bolt12SendRequest {
offer,
amount_msat,
quantity,
payer_note,
route_parameters: Some(route_parameters),
})
.await,
);
},
Expand Down
6 changes: 6 additions & 0 deletions ldk-server-protos/src/api.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -141,6 +141,9 @@ pub struct Bolt11SendRequest {
/// This operation will fail if the amount specified is less than the value required by the given invoice.
#[prost(uint64, optional, tag = "2")]
pub amount_msat: ::core::option::Option<u64>,
/// Configuration options for payment routing and pathfinding.
#[prost(message, optional, tag = "3")]
pub route_parameters: ::core::option::Option<super::types::RouteParametersConfig>,
}
/// The response `content` for the `Bolt11Send` API, when HttpStatusCode is OK (200).
/// When HttpStatusCode is not OK (non-200), the response `content` contains a serialized `ErrorResponse`.
Expand DownExpand Up@@ -205,6 +208,9 @@ pub struct Bolt12SendRequest {
/// If set, it will be seen by the recipient and reflected back in the invoice.
#[prost(string, optional, tag = "4")]
pub payer_note: ::core::option::Option<::prost::alloc::string::String>,
/// Configuration options for payment routing and pathfinding.
#[prost(message, optional, tag = "5")]
pub route_parameters: ::core::option::Option<super::types::RouteParametersConfig>,
}
/// The response `content` for the `Bolt12Send` API, when HttpStatusCode is OK (200).
/// When HttpStatusCode is not OK (non-200), the response `content` contains a serialized `ErrorResponse`.
Expand Down
6 changes: 6 additions & 0 deletions ldk-server-protos/src/proto/api.proto
Original file line numberDiff line numberDiff line change
Expand Up@@ -138,6 +138,9 @@ message Bolt11SendRequest {
// amount paid to be determined by the user.
// This operation will fail if the amount specified is less than the value required by the given invoice.
optional uint64 amount_msat = 2;

// Configuration options for payment routing and pathfinding.
optional types.RouteParametersConfig route_parameters = 3;

}

Expand DownExpand Up@@ -199,6 +202,9 @@ message Bolt12SendRequest {

// If set, it will be seen by the recipient and reflected back in the invoice.
optional string payer_note = 4;

// Configuration options for payment routing and pathfinding.
optional types.RouteParametersConfig route_parameters = 5;
}

// The response `content` for the `Bolt12Send` API, when HttpStatusCode is OK (200).
Expand Down
21 changes: 21 additions & 0 deletions ldk-server-protos/src/proto/types.proto
Original file line numberDiff line numberDiff line change
Expand Up@@ -683,3 +683,24 @@ message Bolt11InvoiceDescription {
string hash = 2;
}
}

// Configuration options for payment routing and pathfinding.
// See https://docs.rs/lightning/0.2.0/lightning/routing/router/struct.RouteParametersConfig.html for more details on each field.
message RouteParametersConfig {
// The maximum total fees, in millisatoshi, that may accrue during route finding.
// Defaults to 1% of the payment amount + 50 sats
optional uint64 max_total_routing_fee_msat = 1;

// The maximum total CLTV delta we accept for the route.
// Defaults to 1008.
uint32 max_total_cltv_expiry_delta = 2;

// The maximum number of paths that may be used by (MPP) payments.
// Defaults to 10.
uint32 max_path_count = 3;

// Selects the maximum share of a channel's total capacity which will be
// sent over a channel, as a power of 1/2.
// Default value: 2
uint32 max_channel_saturation_power_of_half = 4;
}
23 changes: 23 additions & 0 deletions ldk-server-protos/src/types.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -779,6 +779,29 @@ pub mod bolt11_invoice_description {
Hash(::prost::alloc::string::String),
}
}
/// Configuration options for payment routing and pathfinding.
/// See <https://docs.rs/lightning/0.2.0/lightning/routing/router/struct.RouteParametersConfig.html> for more details on each field.
#[allow(clippy::derive_partial_eq_without_eq)]
#[derive(Clone, PartialEq, ::prost::Message)]
pub struct RouteParametersConfig {
/// The maximum total fees, in millisatoshi, that may accrue during route finding.
/// Defaults to 1% of the payment amount + 50 sats
#[prost(uint64, optional, tag = "1")]
pub max_total_routing_fee_msat: ::core::option::Option<u64>,
/// The maximum total CLTV delta we accept for the route.
/// Defaults to 1008.
#[prost(uint32, tag = "2")]
pub max_total_cltv_expiry_delta: u32,
/// The maximum number of paths that may be used by (MPP) payments.
/// Defaults to 10.
#[prost(uint32, tag = "3")]
pub max_path_count: u32,
/// Selects the maximum share of a channel's total capacity which will be
/// sent over a channel, as a power of 1/2.
/// Default value: 2
#[prost(uint32, tag = "4")]
pub max_channel_saturation_power_of_half: u32,
}
/// Represents the direction of a payment.
#[derive(Clone, Copy, Debug, PartialEq, Eq, Hash, PartialOrd, Ord, ::prost::Enumeration)]
#[repr(i32)]
Expand Down
34 changes: 32 additions & 2 deletions ldk-server/src/api/bolt11_send.rs
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
use crate::api::error::LdkServerError;
use crate::api::error::LdkServerErrorCode::InvalidRequestError;
use crate::service::Context;
use ldk_node::lightning::routing::router::RouteParametersConfig;
use ldk_node::lightning_invoice::Bolt11Invoice;
use ldk_server_protos::api::{Bolt11SendRequest, Bolt11SendResponse};
use std::str::FromStr;
Expand All@@ -12,10 +14,38 @@ pub(crate) fn handle_bolt11_send_request(
let invoice = Bolt11Invoice::from_str(&request.invoice.as_str())
.map_err(|_| ldk_node::NodeError::InvalidInvoice)?;

let route_parameters = match request.route_parameters {
Some(params) => {
let max_path_count: u8 = params.max_path_count.try_into().map_err(|_| {
LdkServerError::new(
InvalidRequestError,
format!("Invalid max_path_count, must be between 0 and {}", u8::MAX),
)
})?;
let max_channel_saturation_power_of_half: u8 =
params.max_channel_saturation_power_of_half.try_into().map_err(|_| {
LdkServerError::new(
InvalidRequestError,
format!(
"Invalid max_channel_saturation_power_of_half, must be between 0 and {}",
u8::MAX
),
)
})?;
Some(RouteParametersConfig {
max_total_routing_fee_msat: params.max_total_routing_fee_msat,
max_total_cltv_expiry_delta: params.max_total_cltv_expiry_delta,
max_path_count,
max_channel_saturation_power_of_half,
})
},
None => None,
};

let payment_id = match request.amount_msat {
None => context.node.bolt11_payment().send(&invoice, None),
None => context.node.bolt11_payment().send(&invoice, route_parameters),
Some(amount_msat) => {
context.node.bolt11_payment().send_using_amount(&invoice, amount_msat, None)
context.node.bolt11_payment().send_using_amount(&invoice, amount_msat, route_parameters)
},
}?;

Expand Down
41 changes: 37 additions & 4 deletions ldk-server/src/api/bolt12_send.rs
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
use crate::api::error::LdkServerError;
use crate::api::error::LdkServerErrorCode::InvalidRequestError;
use crate::service::Context;
use ldk_node::lightning::offers::offer::Offer;
use ldk_node::lightning::routing::router::RouteParametersConfig;
use ldk_server_protos::api::{Bolt12SendRequest, Bolt12SendResponse};
use std::str::FromStr;

Expand All@@ -12,16 +14,47 @@ pub(crate) fn handle_bolt12_send_request(
let offer =
Offer::from_str(&request.offer.as_str()).map_err(|_| ldk_node::NodeError::InvalidOffer)?;

let payment_id = match request.amount_msat {
None => {
context.node.bolt12_payment().send(&offer, request.quantity, request.payer_note, None)
let route_parameters = match request.route_parameters {
Some(params) => {
let max_path_count = params.max_path_count.try_into().map_err(|_| {
LdkServerError::new(
InvalidRequestError,
format!("Invalid max_path_count, must be between 0 and {}", u8::MAX),
)
})?;
let max_channel_saturation_power_of_half =
params.max_channel_saturation_power_of_half.try_into().map_err(|_| {
LdkServerError::new(
InvalidRequestError,
format!(
"Invalid max_channel_saturation_power_of_half, must be between 0 and {}",
u8::MAX
),
)
})?;
Some(RouteParametersConfig {
max_total_routing_fee_msat: params.max_total_routing_fee_msat,
max_total_cltv_expiry_delta: params.max_total_cltv_expiry_delta,
max_path_count,
max_channel_saturation_power_of_half,
})
},
None => None,
};

let payment_id = match request.amount_msat {
None => context.node.bolt12_payment().send(
&offer,
request.quantity,
request.payer_note,
route_parameters,
),
Some(amount_msat) => context.node.bolt12_payment().send_using_amount(
&offer,
amount_msat,
request.quantity,
request.payer_note,
None,
route_parameters,
),
}?;

Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Allow to set `SendingParameters` in BOLT11 & BOLT12 by Anyitechs · Pull Request #79 · lightningdevkit/ldk-server · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 73 additions & 4 deletions ldk-server-cli/src/main.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,11 +10,19 @@ use ldk_server_client::ldk_server_protos::api::{
ListChannelsRequest, ListPaymentsRequest, OnchainReceiveRequest, OnchainSendRequest,
OpenChannelRequest,
};
use ldk_server_client::ldk_server_protos::types::RouteParametersConfig;
use ldk_server_client::ldk_server_protos::types::{
bolt11_invoice_description, Bolt11InvoiceDescription, PageToken, Payment,
};
use std::fmt::Debug;

// Having these default values as constants in the Proto file and
// importing/reusing them here might be better, but Proto3 removed
// the ability to set default values.
const DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA: u32 = 1008;
const DEFAULT_MAX_PATH_COUNT: u32 = 10;
const DEFAULT_MAX_CHANNEL_SATURATION_POWER_OF_HALF: u32 = 2;

#[derive(Parser, Debug)]
#[command(version, about, long_about = None)]
struct Cli {
Expand DownExpand Up@@ -55,6 +63,14 @@ enum Commands {
invoice: String,
#[arg(long)]
amount_msat: Option<u64>,
#[arg(long)]
max_total_routing_fee_msat: Option<u64>,
#[arg(long)]
max_total_cltv_expiry_delta: Option<u32>,
#[arg(long)]
max_path_count: Option<u32>,
#[arg(long)]
max_channel_saturation_power_of_half: Option<u32>,
},
Bolt12Receive {
#[arg(short, long)]
Expand All@@ -75,6 +91,14 @@ enum Commands {
quantity: Option<u64>,
#[arg(short, long)]
payer_note: Option<String>,
#[arg(long)]
max_total_routing_fee_msat: Option<u64>,
#[arg(long)]
max_total_cltv_expiry_delta: Option<u32>,
#[arg(long)]
max_path_count: Option<u32>,
#[arg(long)]
max_channel_saturation_power_of_half: Option<u32>,
},
CloseChannel {
#[arg(short, long)]
Expand DownExpand Up@@ -161,9 +185,30 @@ async fn main() {

handle_response_result(client.bolt11_receive(request).await);
},
Commands::Bolt11Send { invoice, amount_msat } => {
Commands::Bolt11Send {
invoice,
amount_msat,
max_total_routing_fee_msat,
max_total_cltv_expiry_delta,
max_path_count,
max_channel_saturation_power_of_half,
} => {
let route_parameters = RouteParametersConfig {
max_total_routing_fee_msat,
max_total_cltv_expiry_delta: max_total_cltv_expiry_delta
.unwrap_or(DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA),
max_path_count: max_path_count.unwrap_or(DEFAULT_MAX_PATH_COUNT),
max_channel_saturation_power_of_half: max_channel_saturation_power_of_half
.unwrap_or(DEFAULT_MAX_CHANNEL_SATURATION_POWER_OF_HALF),
};
handle_response_result(
client.bolt11_send(Bolt11SendRequest { invoice, amount_msat }).await,
client
.bolt11_send(Bolt11SendRequest {
invoice,
amount_msat,
route_parameters: Some(route_parameters),
})
.await,
);
},
Commands::Bolt12Receive { description, amount_msat, expiry_secs, quantity } => {
Expand All@@ -178,10 +223,34 @@ async fn main() {
.await,
);
},
Commands::Bolt12Send { offer, amount_msat, quantity, payer_note } => {
Commands::Bolt12Send {
offer,
amount_msat,
quantity,
payer_note,
max_total_routing_fee_msat,
max_total_cltv_expiry_delta,
max_path_count,
max_channel_saturation_power_of_half,
} => {
let route_parameters = RouteParametersConfig {
max_total_routing_fee_msat,
max_total_cltv_expiry_delta: max_total_cltv_expiry_delta
.unwrap_or(DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA),
max_path_count: max_path_count.unwrap_or(DEFAULT_MAX_PATH_COUNT),
max_channel_saturation_power_of_half: max_channel_saturation_power_of_half
.unwrap_or(DEFAULT_MAX_CHANNEL_SATURATION_POWER_OF_HALF),
};

handle_response_result(
client
.bolt12_send(Bolt12SendRequest { offer, amount_msat, quantity, payer_note })
.bolt12_send(Bolt12SendRequest {
offer,
amount_msat,
quantity,
payer_note,
route_parameters: Some(route_parameters),
})
.await,
);
},
Expand Down
6 changes: 6 additions & 0 deletions ldk-server-protos/src/api.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -141,6 +141,9 @@ pub struct Bolt11SendRequest {
/// This operation will fail if the amount specified is less than the value required by the given invoice.
#[prost(uint64, optional, tag = "2")]
pub amount_msat: ::core::option::Option<u64>,
/// Configuration options for payment routing and pathfinding.
#[prost(message, optional, tag = "3")]
pub route_parameters: ::core::option::Option<super::types::RouteParametersConfig>,
}
/// The response `content` for the `Bolt11Send` API, when HttpStatusCode is OK (200).
/// When HttpStatusCode is not OK (non-200), the response `content` contains a serialized `ErrorResponse`.
Expand DownExpand Up@@ -205,6 +208,9 @@ pub struct Bolt12SendRequest {
/// If set, it will be seen by the recipient and reflected back in the invoice.
#[prost(string, optional, tag = "4")]
pub payer_note: ::core::option::Option<::prost::alloc::string::String>,
/// Configuration options for payment routing and pathfinding.
#[prost(message, optional, tag = "5")]
pub route_parameters: ::core::option::Option<super::types::RouteParametersConfig>,
}
/// The response `content` for the `Bolt12Send` API, when HttpStatusCode is OK (200).
/// When HttpStatusCode is not OK (non-200), the response `content` contains a serialized `ErrorResponse`.
Expand Down
6 changes: 6 additions & 0 deletions ldk-server-protos/src/proto/api.proto
Original file line numberDiff line numberDiff line change
Expand Up@@ -138,6 +138,9 @@ message Bolt11SendRequest {
// amount paid to be determined by the user.
// This operation will fail if the amount specified is less than the value required by the given invoice.
optional uint64 amount_msat = 2;

// Configuration options for payment routing and pathfinding.
optional types.RouteParametersConfig route_parameters = 3;

}

Expand DownExpand Up@@ -199,6 +202,9 @@ message Bolt12SendRequest {

// If set, it will be seen by the recipient and reflected back in the invoice.
optional string payer_note = 4;

// Configuration options for payment routing and pathfinding.
optional types.RouteParametersConfig route_parameters = 5;
}

// The response `content` for the `Bolt12Send` API, when HttpStatusCode is OK (200).
Expand Down
21 changes: 21 additions & 0 deletions ldk-server-protos/src/proto/types.proto
Original file line numberDiff line numberDiff line change
Expand Up@@ -683,3 +683,24 @@ message Bolt11InvoiceDescription {
string hash = 2;
}
}

// Configuration options for payment routing and pathfinding.
// See https://docs.rs/lightning/0.2.0/lightning/routing/router/struct.RouteParametersConfig.html for more details on each field.
message RouteParametersConfig {
// The maximum total fees, in millisatoshi, that may accrue during route finding.
// Defaults to 1% of the payment amount + 50 sats
optional uint64 max_total_routing_fee_msat = 1;

// The maximum total CLTV delta we accept for the route.
// Defaults to 1008.
uint32 max_total_cltv_expiry_delta = 2;

// The maximum number of paths that may be used by (MPP) payments.
// Defaults to 10.
uint32 max_path_count = 3;

// Selects the maximum share of a channel's total capacity which will be
// sent over a channel, as a power of 1/2.
// Default value: 2
uint32 max_channel_saturation_power_of_half = 4;
}
23 changes: 23 additions & 0 deletions ldk-server-protos/src/types.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -779,6 +779,29 @@ pub mod bolt11_invoice_description {
Hash(::prost::alloc::string::String),
}
}
/// Configuration options for payment routing and pathfinding.
/// See <https://docs.rs/lightning/0.2.0/lightning/routing/router/struct.RouteParametersConfig.html> for more details on each field.
#[allow(clippy::derive_partial_eq_without_eq)]
#[derive(Clone, PartialEq, ::prost::Message)]
pub struct RouteParametersConfig {
/// The maximum total fees, in millisatoshi, that may accrue during route finding.
/// Defaults to 1% of the payment amount + 50 sats
#[prost(uint64, optional, tag = "1")]
pub max_total_routing_fee_msat: ::core::option::Option<u64>,
/// The maximum total CLTV delta we accept for the route.
/// Defaults to 1008.
#[prost(uint32, tag = "2")]
pub max_total_cltv_expiry_delta: u32,
/// The maximum number of paths that may be used by (MPP) payments.
/// Defaults to 10.
#[prost(uint32, tag = "3")]
pub max_path_count: u32,
/// Selects the maximum share of a channel's total capacity which will be
/// sent over a channel, as a power of 1/2.
/// Default value: 2
#[prost(uint32, tag = "4")]
pub max_channel_saturation_power_of_half: u32,
}
/// Represents the direction of a payment.
#[derive(Clone, Copy, Debug, PartialEq, Eq, Hash, PartialOrd, Ord, ::prost::Enumeration)]
#[repr(i32)]
Expand Down
34 changes: 32 additions & 2 deletions ldk-server/src/api/bolt11_send.rs
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
use crate::api::error::LdkServerError;
use crate::api::error::LdkServerErrorCode::InvalidRequestError;
use crate::service::Context;
use ldk_node::lightning::routing::router::RouteParametersConfig;
use ldk_node::lightning_invoice::Bolt11Invoice;
use ldk_server_protos::api::{Bolt11SendRequest, Bolt11SendResponse};
use std::str::FromStr;
Expand All@@ -12,10 +14,38 @@ pub(crate) fn handle_bolt11_send_request(
let invoice = Bolt11Invoice::from_str(&request.invoice.as_str())
.map_err(|_| ldk_node::NodeError::InvalidInvoice)?;

let route_parameters = match request.route_parameters {
Some(params) => {
let max_path_count: u8 = params.max_path_count.try_into().map_err(|_| {
LdkServerError::new(
InvalidRequestError,
format!("Invalid max_path_count, must be between 0 and {}", u8::MAX),
)
})?;
let max_channel_saturation_power_of_half: u8 =
params.max_channel_saturation_power_of_half.try_into().map_err(|_| {
LdkServerError::new(
InvalidRequestError,
format!(
"Invalid max_channel_saturation_power_of_half, must be between 0 and {}",
u8::MAX
),
)
})?;
Some(RouteParametersConfig {
max_total_routing_fee_msat: params.max_total_routing_fee_msat,
max_total_cltv_expiry_delta: params.max_total_cltv_expiry_delta,
max_path_count,
max_channel_saturation_power_of_half,
})
},
None => None,
};

let payment_id = match request.amount_msat {
None => context.node.bolt11_payment().send(&invoice, None),
None => context.node.bolt11_payment().send(&invoice, route_parameters),
Some(amount_msat) => {
context.node.bolt11_payment().send_using_amount(&invoice, amount_msat, None)
context.node.bolt11_payment().send_using_amount(&invoice, amount_msat, route_parameters)
},
}?;

Expand Down
41 changes: 37 additions & 4 deletions ldk-server/src/api/bolt12_send.rs
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
use crate::api::error::LdkServerError;
use crate::api::error::LdkServerErrorCode::InvalidRequestError;
use crate::service::Context;
use ldk_node::lightning::offers::offer::Offer;
use ldk_node::lightning::routing::router::RouteParametersConfig;
use ldk_server_protos::api::{Bolt12SendRequest, Bolt12SendResponse};
use std::str::FromStr;

Expand All@@ -12,16 +14,47 @@ pub(crate) fn handle_bolt12_send_request(
let offer =
Offer::from_str(&request.offer.as_str()).map_err(|_| ldk_node::NodeError::InvalidOffer)?;

let payment_id = match request.amount_msat {
None => {
context.node.bolt12_payment().send(&offer, request.quantity, request.payer_note, None)
let route_parameters = match request.route_parameters {
Some(params) => {
let max_path_count = params.max_path_count.try_into().map_err(|_| {
LdkServerError::new(
InvalidRequestError,
format!("Invalid max_path_count, must be between 0 and {}", u8::MAX),
)
})?;
let max_channel_saturation_power_of_half =
params.max_channel_saturation_power_of_half.try_into().map_err(|_| {
LdkServerError::new(
InvalidRequestError,
format!(
"Invalid max_channel_saturation_power_of_half, must be between 0 and {}",
u8::MAX
),
)
})?;
Some(RouteParametersConfig {
max_total_routing_fee_msat: params.max_total_routing_fee_msat,
max_total_cltv_expiry_delta: params.max_total_cltv_expiry_delta,
max_path_count,
max_channel_saturation_power_of_half,
})
},
None => None,
};

let payment_id = match request.amount_msat {
None => context.node.bolt12_payment().send(
&offer,
request.quantity,
request.payer_note,
route_parameters,
),
Some(amount_msat) => context.node.bolt12_payment().send_using_amount(
&offer,
amount_msat,
request.quantity,
request.payer_note,
None,
route_parameters,
),
}?;

Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Allow to set `SendingParameters` in BOLT11 & BOLT12 by Anyitechs · Pull Request #79 · lightningdevkit/ldk-server · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 73 additions & 4 deletions ldk-server-cli/src/main.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,11 +10,19 @@ use ldk_server_client::ldk_server_protos::api::{
ListChannelsRequest, ListPaymentsRequest, OnchainReceiveRequest, OnchainSendRequest,
OpenChannelRequest,
};
use ldk_server_client::ldk_server_protos::types::RouteParametersConfig;
use ldk_server_client::ldk_server_protos::types::{
bolt11_invoice_description, Bolt11InvoiceDescription, PageToken, Payment,
};
use std::fmt::Debug;

// Having these default values as constants in the Proto file and
// importing/reusing them here might be better, but Proto3 removed
// the ability to set default values.
const DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA: u32 = 1008;
const DEFAULT_MAX_PATH_COUNT: u32 = 10;
const DEFAULT_MAX_CHANNEL_SATURATION_POWER_OF_HALF: u32 = 2;

#[derive(Parser, Debug)]
#[command(version, about, long_about = None)]
struct Cli {
Expand DownExpand Up@@ -55,6 +63,14 @@ enum Commands {
invoice: String,
#[arg(long)]
amount_msat: Option<u64>,
#[arg(long)]
max_total_routing_fee_msat: Option<u64>,
#[arg(long)]
max_total_cltv_expiry_delta: Option<u32>,
#[arg(long)]
max_path_count: Option<u32>,
#[arg(long)]
max_channel_saturation_power_of_half: Option<u32>,
},
Bolt12Receive {
#[arg(short, long)]
Expand All@@ -75,6 +91,14 @@ enum Commands {
quantity: Option<u64>,
#[arg(short, long)]
payer_note: Option<String>,
#[arg(long)]
max_total_routing_fee_msat: Option<u64>,
#[arg(long)]
max_total_cltv_expiry_delta: Option<u32>,
#[arg(long)]
max_path_count: Option<u32>,
#[arg(long)]
max_channel_saturation_power_of_half: Option<u32>,
},
CloseChannel {
#[arg(short, long)]
Expand DownExpand Up@@ -161,9 +185,30 @@ async fn main() {

handle_response_result(client.bolt11_receive(request).await);
},
Commands::Bolt11Send { invoice, amount_msat } => {
Commands::Bolt11Send {
invoice,
amount_msat,
max_total_routing_fee_msat,
max_total_cltv_expiry_delta,
max_path_count,
max_channel_saturation_power_of_half,
} => {
let route_parameters = RouteParametersConfig {
max_total_routing_fee_msat,
max_total_cltv_expiry_delta: max_total_cltv_expiry_delta
.unwrap_or(DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA),
max_path_count: max_path_count.unwrap_or(DEFAULT_MAX_PATH_COUNT),
max_channel_saturation_power_of_half: max_channel_saturation_power_of_half
.unwrap_or(DEFAULT_MAX_CHANNEL_SATURATION_POWER_OF_HALF),
};
handle_response_result(
client.bolt11_send(Bolt11SendRequest { invoice, amount_msat }).await,
client
.bolt11_send(Bolt11SendRequest {
invoice,
amount_msat,
route_parameters: Some(route_parameters),
})
.await,
);
},
Commands::Bolt12Receive { description, amount_msat, expiry_secs, quantity } => {
Expand All@@ -178,10 +223,34 @@ async fn main() {
.await,
);
},
Commands::Bolt12Send { offer, amount_msat, quantity, payer_note } => {
Commands::Bolt12Send {
offer,
amount_msat,
quantity,
payer_note,
max_total_routing_fee_msat,
max_total_cltv_expiry_delta,
max_path_count,
max_channel_saturation_power_of_half,
} => {
let route_parameters = RouteParametersConfig {
max_total_routing_fee_msat,
max_total_cltv_expiry_delta: max_total_cltv_expiry_delta
.unwrap_or(DEFAULT_MAX_TOTAL_CLTV_EXPIRY_DELTA),
max_path_count: max_path_count.unwrap_or(DEFAULT_MAX_PATH_COUNT),
max_channel_saturation_power_of_half: max_channel_saturation_power_of_half
.unwrap_or(DEFAULT_MAX_CHANNEL_SATURATION_POWER_OF_HALF),
};

handle_response_result(
client
.bolt12_send(Bolt12SendRequest { offer, amount_msat, quantity, payer_note })
.bolt12_send(Bolt12SendRequest {
offer,
amount_msat,
quantity,
payer_note,
route_parameters: Some(route_parameters),
})
.await,
);
},
Expand Down
6 changes: 6 additions & 0 deletions ldk-server-protos/src/api.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -141,6 +141,9 @@ pub struct Bolt11SendRequest {
/// This operation will fail if the amount specified is less than the value required by the given invoice.
#[prost(uint64, optional, tag = "2")]
pub amount_msat: ::core::option::Option<u64>,
/// Configuration options for payment routing and pathfinding.
#[prost(message, optional, tag = "3")]
pub route_parameters: ::core::option::Option<super::types::RouteParametersConfig>,
}
/// The response `content` for the `Bolt11Send` API, when HttpStatusCode is OK (200).
/// When HttpStatusCode is not OK (non-200), the response `content` contains a serialized `ErrorResponse`.
Expand DownExpand Up@@ -205,6 +208,9 @@ pub struct Bolt12SendRequest {
/// If set, it will be seen by the recipient and reflected back in the invoice.
#[prost(string, optional, tag = "4")]
pub payer_note: ::core::option::Option<::prost::alloc::string::String>,
/// Configuration options for payment routing and pathfinding.
#[prost(message, optional, tag = "5")]
pub route_parameters: ::core::option::Option<super::types::RouteParametersConfig>,
}
/// The response `content` for the `Bolt12Send` API, when HttpStatusCode is OK (200).
/// When HttpStatusCode is not OK (non-200), the response `content` contains a serialized `ErrorResponse`.
Expand Down
6 changes: 6 additions & 0 deletions ldk-server-protos/src/proto/api.proto
Original file line numberDiff line numberDiff line change
Expand Up@@ -138,6 +138,9 @@ message Bolt11SendRequest {
// amount paid to be determined by the user.
// This operation will fail if the amount specified is less than the value required by the given invoice.
optional uint64 amount_msat = 2;

// Configuration options for payment routing and pathfinding.
optional types.RouteParametersConfig route_parameters = 3;

}

Expand DownExpand Up@@ -199,6 +202,9 @@ message Bolt12SendRequest {

// If set, it will be seen by the recipient and reflected back in the invoice.
optional string payer_note = 4;

// Configuration options for payment routing and pathfinding.
optional types.RouteParametersConfig route_parameters = 5;
}

// The response `content` for the `Bolt12Send` API, when HttpStatusCode is OK (200).
Expand Down
21 changes: 21 additions & 0 deletions ldk-server-protos/src/proto/types.proto
Original file line numberDiff line numberDiff line change
Expand Up@@ -683,3 +683,24 @@ message Bolt11InvoiceDescription {
string hash = 2;
}
}

// Configuration options for payment routing and pathfinding.
// See https://docs.rs/lightning/0.2.0/lightning/routing/router/struct.RouteParametersConfig.html for more details on each field.
message RouteParametersConfig {
// The maximum total fees, in millisatoshi, that may accrue during route finding.
// Defaults to 1% of the payment amount + 50 sats
optional uint64 max_total_routing_fee_msat = 1;

// The maximum total CLTV delta we accept for the route.
// Defaults to 1008.
uint32 max_total_cltv_expiry_delta = 2;

// The maximum number of paths that may be used by (MPP) payments.
// Defaults to 10.
uint32 max_path_count = 3;

// Selects the maximum share of a channel's total capacity which will be
// sent over a channel, as a power of 1/2.
// Default value: 2
uint32 max_channel_saturation_power_of_half = 4;
}
23 changes: 23 additions & 0 deletions ldk-server-protos/src/types.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -779,6 +779,29 @@ pub mod bolt11_invoice_description {
Hash(::prost::alloc::string::String),
}
}
/// Configuration options for payment routing and pathfinding.
/// See <https://docs.rs/lightning/0.2.0/lightning/routing/router/struct.RouteParametersConfig.html> for more details on each field.
#[allow(clippy::derive_partial_eq_without_eq)]
#[derive(Clone, PartialEq, ::prost::Message)]
pub struct RouteParametersConfig {
/// The maximum total fees, in millisatoshi, that may accrue during route finding.
/// Defaults to 1% of the payment amount + 50 sats
#[prost(uint64, optional, tag = "1")]
pub max_total_routing_fee_msat: ::core::option::Option<u64>,
/// The maximum total CLTV delta we accept for the route.
/// Defaults to 1008.
#[prost(uint32, tag = "2")]
pub max_total_cltv_expiry_delta: u32,
/// The maximum number of paths that may be used by (MPP) payments.
/// Defaults to 10.
#[prost(uint32, tag = "3")]
pub max_path_count: u32,
/// Selects the maximum share of a channel's total capacity which will be
/// sent over a channel, as a power of 1/2.
/// Default value: 2
#[prost(uint32, tag = "4")]
pub max_channel_saturation_power_of_half: u32,
}
/// Represents the direction of a payment.
#[derive(Clone, Copy, Debug, PartialEq, Eq, Hash, PartialOrd, Ord, ::prost::Enumeration)]
#[repr(i32)]
Expand Down
34 changes: 32 additions & 2 deletions ldk-server/src/api/bolt11_send.rs
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
use crate::api::error::LdkServerError;
use crate::api::error::LdkServerErrorCode::InvalidRequestError;
use crate::service::Context;
use ldk_node::lightning::routing::router::RouteParametersConfig;
use ldk_node::lightning_invoice::Bolt11Invoice;
use ldk_server_protos::api::{Bolt11SendRequest, Bolt11SendResponse};
use std::str::FromStr;
Expand All@@ -12,10 +14,38 @@ pub(crate) fn handle_bolt11_send_request(
let invoice = Bolt11Invoice::from_str(&request.invoice.as_str())
.map_err(|_| ldk_node::NodeError::InvalidInvoice)?;

let route_parameters = match request.route_parameters {
Some(params) => {
let max_path_count: u8 = params.max_path_count.try_into().map_err(|_| {
LdkServerError::new(
InvalidRequestError,
format!("Invalid max_path_count, must be between 0 and {}", u8::MAX),
)
})?;
let max_channel_saturation_power_of_half: u8 =
params.max_channel_saturation_power_of_half.try_into().map_err(|_| {
LdkServerError::new(
InvalidRequestError,
format!(
"Invalid max_channel_saturation_power_of_half, must be between 0 and {}",
u8::MAX
),
)
})?;
Some(RouteParametersConfig {
max_total_routing_fee_msat: params.max_total_routing_fee_msat,
max_total_cltv_expiry_delta: params.max_total_cltv_expiry_delta,
max_path_count,
max_channel_saturation_power_of_half,
})
},
None => None,
};

let payment_id = match request.amount_msat {
None => context.node.bolt11_payment().send(&invoice, None),
None => context.node.bolt11_payment().send(&invoice, route_parameters),
Some(amount_msat) => {
context.node.bolt11_payment().send_using_amount(&invoice, amount_msat, None)
context.node.bolt11_payment().send_using_amount(&invoice, amount_msat, route_parameters)
},
}?;

Expand Down
41 changes: 37 additions & 4 deletions ldk-server/src/api/bolt12_send.rs
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
use crate::api::error::LdkServerError;
use crate::api::error::LdkServerErrorCode::InvalidRequestError;
use crate::service::Context;
use ldk_node::lightning::offers::offer::Offer;
use ldk_node::lightning::routing::router::RouteParametersConfig;
use ldk_server_protos::api::{Bolt12SendRequest, Bolt12SendResponse};
use std::str::FromStr;

Expand All@@ -12,16 +14,47 @@ pub(crate) fn handle_bolt12_send_request(
let offer =
Offer::from_str(&request.offer.as_str()).map_err(|_| ldk_node::NodeError::InvalidOffer)?;

let payment_id = match request.amount_msat {
None => {
context.node.bolt12_payment().send(&offer, request.quantity, request.payer_note, None)
let route_parameters = match request.route_parameters {
Some(params) => {
let max_path_count = params.max_path_count.try_into().map_err(|_| {
LdkServerError::new(
InvalidRequestError,
format!("Invalid max_path_count, must be between 0 and {}", u8::MAX),
)
})?;
let max_channel_saturation_power_of_half =
params.max_channel_saturation_power_of_half.try_into().map_err(|_| {
LdkServerError::new(
InvalidRequestError,
format!(
"Invalid max_channel_saturation_power_of_half, must be between 0 and {}",
u8::MAX
),
)
})?;
Some(RouteParametersConfig {
max_total_routing_fee_msat: params.max_total_routing_fee_msat,
max_total_cltv_expiry_delta: params.max_total_cltv_expiry_delta,
max_path_count,
max_channel_saturation_power_of_half,
})
},
None => None,
};

let payment_id = match request.amount_msat {
None => context.node.bolt12_payment().send(
&offer,
request.quantity,
request.payer_note,
route_parameters,
),
Some(amount_msat) => context.node.bolt12_payment().send_using_amount(
&offer,
amount_msat,
request.quantity,
request.payer_note,
None,
route_parameters,
),
}?;

Expand Down