') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Impl `Display` for SocketAddress by yanganto · Pull Request #2670 · lightningdevkit/rust-lightning · GitHub
Skip to content

Impl Display for SocketAddress - #2670

Merged
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom
yanganto:socket-addr-to-string
Oct 20, 2023
Merged

Impl Display for SocketAddress#2670
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom
yanganto:socket-addr-to-string

Conversation

@yanganto

@yangantoyanganto commented Oct 18, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor
  • impl Display SocketAddress

@yanganto
yanganto marked this pull request as draft October 18, 2023 12:29
@yangantoyanganto changed the title Fix SocketAddress bugsImpl Display for SocketAddressOct 18, 2023
@yanganto
yangantoforce-pushed the socket-addr-to-string branch 3 times, most recently from 8882676 to 789bcc7CompareOctober 18, 2023 12:54
@yanganto
yanganto marked this pull request as ready for review October 18, 2023 12:54
@codecov-commenter

codecov-commenter commented Oct 18, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (62fd36d) 88.93% compared to head (31aa483) 88.96%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@ Coverage Diff @@## main #2670 +/- ##
==========================================
+ Coverage 88.93% 88.96% +0.03% 
==========================================
Files 112 112 Lines 87850 87881 +31 Branches 87850 87881 +31 ==========================================
+ Hits 78129 78183 +54 + Misses 7473 7447 -26 - Partials 2248 2251 +3
FilesCoverage Δ
lightning/src/util/ser.rs76.35% <66.66%> (-0.05%)⬇️
lightning/src/ln/msgs.rs77.23% <88.09%> (+0.06%)⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yanganto
yangantoforce-pushed the socket-addr-to-string branch from 789bcc7 to d37b5b6CompareOctober 18, 2023 13:10
TheBlueMatt
TheBlueMatt reviewed Oct 18, 2023
View reviewed changes
Comment threadlightning/src/ln/msgs.rs Outdated
TheBlueMatt
TheBlueMatt reviewed Oct 18, 2023
View reviewed changes
Comment threadlightning/src/ln/msgs.rs Outdated
TheBlueMatt
TheBlueMatt reviewed Oct 18, 2023
View reviewed changes
Comment threadlightning/src/ln/msgs.rs Outdated
Comment threadlightning/src/ln/msgs.rs Outdated
Comment threadlightning/src/ln/msgs.rs Outdated
@yanganto
yangantoforce-pushed the socket-addr-to-string branch from dd55052 to 0f1bf86CompareOctober 18, 2023 16:00
@benthecarman

benthecarman commented Oct 18, 2023

Copy link
Copy Markdown
Contributor

Closes #2183

TheBlueMatt
TheBlueMatt reviewed Oct 18, 2023
View reviewed changes

@TheBlueMattTheBlueMatt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Only two small comments. Once you address them, could you go ahead and squash all the fixup commits here so that the history doesn't contain any commits which clean up stuff from previous ones?

Comment threadlightning/src/ln/msgs.rs Outdated
Comment threadlightning/src/ln/msgs.rs Outdated
@yanganto
yangantoforce-pushed the socket-addr-to-string branch from 170cf92 to e95b762CompareOctober 19, 2023 05:20
tnull
tnull reviewed Oct 19, 2023
View reviewed changes

@tnulltnull left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please squash commits!

@yanganto
yangantoforce-pushed the socket-addr-to-string branch from e95b762 to a565b5eCompareOctober 19, 2023 08:18
@yanganto
yanganto requested a review from tnullOctober 19, 2023 11:31
tnull
tnull previously approved these changes Oct 19, 2023
View reviewed changes
@yanganto
yangantoforce-pushed the socket-addr-to-string branch from a565b5e to 7045b82CompareOctober 20, 2023 01:40
@tnull

tnull commented Oct 20, 2023

Copy link
Copy Markdown
Contributor

Ah, this unfortunately needs a minor rebase now after #2636 landed, sorry!

@yanganto
yangantoforce-pushed the socket-addr-to-string branch from 7045b82 to 4c465f3CompareOctober 20, 2023 08:13
@yanganto
yangantoforce-pushed the socket-addr-to-string branch from 4c465f3 to 31aa483CompareOctober 20, 2023 08:15
@yanganto

yanganto commented Oct 20, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Ah, this unfortunately needs a minor rebase now after #2636 landed, sorry!

No worry, thanks for pinning me and letting me know.

@TheBlueMatt
TheBlueMatt merged commit 33bbf26 into lightningdevkit:mainOct 20, 2023
@benthecarmanbenthecarman mentioned this pull request Oct 20, 2023
Closed
@yanganto
yanganto deleted the socket-addr-to-string branch October 21, 2023 14:21
@yanganto
yanganto restored the socket-addr-to-string branch October 21, 2023 14:21
@yanganto
yanganto deleted the socket-addr-to-string branch October 21, 2023 14:21
@yanganto
yanganto restored the socket-addr-to-string branch October 21, 2023 14:22
PXplod pushed a commit to bitlightlabs/rust-lightning that referenced this pull request Sep 30, 2024
@zoedberg
Merge tag 'v0.0.118' into6b4f5ab
d1145ee
0.0.118 - Oct 23, 2023 - "Just the Twelve Sinks"
API Updates
===========
* BOLT12 sending and receiving is now supported as an alpha feature. You may
run into unexpected issues and will need to have a direct connection with
the offer's blinded path introduction points as messages are not yet routed.
We are seeking feedback from early testers (lightningdevkit#2578, lightningdevkit#2039).
* `ConfirmationTarget` has been rewritten to provide information about the
specific use LDK needs the feerate estimate for, rather than the generic
low-, medium-, and high-priority estimates. This allows LDK users to more
accurately target their feerate estimates (lightningdevkit#2660). For those wishing to
retain their existing behavior, see the table below for conversion.
* `ChainHash` is now used in place of `BlockHash` where it represents the
genesis block (lightningdevkit#2662).
* `lightning-invoice` payment utilities now take a `Deref` to
`AChannelManager` (lightningdevkit#2652).
* `peel_onion` is provided to statelessly decode an `OnionMessage` (lightningdevkit#2599).
* `ToSocketAddrs` + `Display` are now impl'd for `SocketAddress` (lightningdevkit#2636, lightningdevkit#2670)
* `Display` is now implemented for `OutPoint` (lightningdevkit#2649).
* `Features::from_be_bytes` is now provided (lightningdevkit#2640).
For those moving to the new `ConfirmationTarget`, the new variants in terms of
the old mempool/low/medium/high priorities are as follows:
* `OnChainSweep` = `HighPriority`
* `MaxAllowedNonAnchorChannelRemoteFee` = `max(25 * 250, HighPriority * 10)`
* `MinAllowedAnchorChannelRemoteFee` = `MempoolMinimum`
* `MinAllowedNonAnchorChannelRemoteFee` = `Background - 250`
* `AnchorChannelFee` = `Background`
* `NonAnchorChannelFee` = `Normal`
* `ChannelCloseMinimum` = `Background`
Bug Fixes
=========
* Calling `ChannelManager::close_channel[_with_feerate_and_script]` on a
channel which did not exist would immediately hang holding several key
`ChannelManager`-internal locks (lightningdevkit#2657).
* Channel information updates received from a failing HTLC are no longer
applied to our `NetworkGraph`. This prevents a node which we attempted to
route a payment through from being able to learn the sender of the payment.
In some rare cases, this may result in marginally reduced payment success
rates (lightningdevkit#2666).
* Anchor outputs are now properly considered when calculating the amount
available to send in HTLCs. This can prevent force-closes in anchor channels
when sending payments which overflow the available balance (lightningdevkit#2674).
* A peer that sends an `update_fulfill_htlc` message for a forwarded HTLC,
then reconnects prior to sending a `commitment_signed` (thus retransmitting
their `update_fulfill_htlc`) may result in the channel stalling and being
unable to make progress (lightningdevkit#2661).
* In exceedingly rare circumstances, messages intended to be sent to a peer
prior to reconnection can be sent after reconnection. This could result in
undefined channel state and force-closes (lightningdevkit#2663).
Backwards Compatibility
=======================
* Creating a blinded path to receive a payment then downgrading to LDK prior to
0.0.117 may result in failure to receive the payment (lightningdevkit#2413).
* Calling `ChannelManager::pay_for_offer` or
`ChannelManager::create_refund_builder` may prevent downgrading to LDK prior
to 0.0.118 until the payment times out and has been removed (lightningdevkit#2039).
Node Compatibility
==================
* LDK now sends a bogus `channel_reestablish` message to peers when they ask to
resume an unknown channel. This should cause LND nodes to force-close and
broadcast the latest channel state to the chain. In order to trigger this
when we wish to force-close a channel, LDK now disconnects immediately after
sending a channel-closing `error` message. This should result in cooperative
peers also working to confirm the latest commitment transaction when we wish
to force-close (lightningdevkit#2658).
Security
========
0.0.118 expands mitigations against transaction cycling attacks to non-anchor
channels, though note that no mitigations which exist today are considered robust
to prevent the class of attacks.
* In order to mitigate against transaction cycling attacks, non-anchor HTLC
transactions are now properly re-signed before broadcasting (lightningdevkit#2667).
In total, this release features 61 files changed, 3470 insertions, 1503
deletions in 85 commits from 12 authors, in alphabetical order:
* Antonio Yang
* Elias Rohrer
* Evan Feenstra
* Fedeparma74
* Gursharan Singh
* Jeffrey Czyz
* Matt Corallo
* Sergi Delgado Segura
* Vladimir Fomene
* Wilmer Paulino
* benthecarman
* slanesuke
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnulltnulltnull approved these changes
@TheBlueMattTheBlueMattTheBlueMatt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yanganto@codecov-commenter@benthecarman@tnull@TheBlueMatt