Add additional coverage to `full_stack_target` by TheBlueMatt · Pull Request #2850 · lightningdevkit/rust-lightning

TheBlueMatt · 2024-01-24T22:05:35Z

Based on #2810, this adds coverage in the full_stack_target which would have caught #2842, both directly (using node announcement generation) and indirectly (with a new test case which tests gossip forwarding).

coderabbitai · 2024-01-24T22:05:59Z

Warning

Rate Limit Exceeded

@TheBlueMatt has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 29 minutes and 40 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 7c94636 and 440a3ea.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

codecov-commenter · 2024-01-24T22:12:06Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e64342a) 89.18% compared to head (7aa06d2) 90.02%.
Report is 9 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@ Coverage Diff @@## main #2850 +/- ##
==========================================
+ Coverage 89.18% 90.02% +0.84% 
==========================================
Files 115 115 Lines 93379 98265 +4886 Branches 93379 98265 +4886 ==========================================
+ Hits 83276 88466 +5190 + Misses 7575 7373 -202 + Partials 2528 2426 -102

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Slightly reducing the amount of data we read to do things.

To potentially get more test coverage

The whole point of full_stack_target is to just expose our entire API to the fuzzer and see what happens. Sadly, we're really only exposing a small subset of our API. This improves that by exposing a handful of other assorted methods from ChannelManager and PeerManager.

This will make test_no_existing_test_breakage marginally easier to update.

TheBlueMatt · 2024-02-07T02:33:27Z

Fixed silent rebase conflict and added coverage of channel config updating.

TheBlueMatt · 2024-02-09T00:49:29Z

Diff is fuzz-only and mostly additive so not really worth getting a second review on it.

TheBlueMatt · 2024-01-24T22:05:35Z

Based on #2810, this adds coverage in the full_stack_target which would have caught #2842, both directly (using node announcement generation) and indirectly (with a new test case which tests gossip forwarding).

coderabbitai · 2024-01-24T22:05:59Z

Warning

Rate Limit Exceeded

@TheBlueMatt has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 29 minutes and 40 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 7c94636 and 440a3ea.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

codecov-commenter · 2024-01-24T22:12:06Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e64342a) 89.18% compared to head (7aa06d2) 90.02%.
Report is 9 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@ Coverage Diff @@## main #2850 +/- ##
==========================================
+ Coverage 89.18% 90.02% +0.84% 
==========================================
Files 115 115 Lines 93379 98265 +4886 Branches 93379 98265 +4886 ==========================================
+ Hits 83276 88466 +5190 + Misses 7575 7373 -202 + Partials 2528 2426 -102

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Slightly reducing the amount of data we read to do things.

To potentially get more test coverage

The whole point of full_stack_target is to just expose our entire API to the fuzzer and see what happens. Sadly, we're really only exposing a small subset of our API. This improves that by exposing a handful of other assorted methods from ChannelManager and PeerManager.

This will make test_no_existing_test_breakage marginally easier to update.

TheBlueMatt · 2024-02-07T02:33:27Z

Fixed silent rebase conflict and added coverage of channel config updating.

TheBlueMatt · 2024-02-09T00:49:29Z

Diff is fuzz-only and mostly additive so not really worth getting a second review on it.

TheBlueMatt · 2024-01-24T22:05:35Z

Based on #2810, this adds coverage in the full_stack_target which would have caught #2842, both directly (using node announcement generation) and indirectly (with a new test case which tests gossip forwarding).

coderabbitai · 2024-01-24T22:05:59Z

Warning

Rate Limit Exceeded

@TheBlueMatt has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 29 minutes and 40 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 7c94636 and 440a3ea.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

codecov-commenter · 2024-01-24T22:12:06Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e64342a) 89.18% compared to head (7aa06d2) 90.02%.
Report is 9 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@ Coverage Diff @@## main #2850 +/- ##
==========================================
+ Coverage 89.18% 90.02% +0.84% 
==========================================
Files 115 115 Lines 93379 98265 +4886 Branches 93379 98265 +4886 ==========================================
+ Hits 83276 88466 +5190 + Misses 7575 7373 -202 + Partials 2528 2426 -102

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Slightly reducing the amount of data we read to do things.

To potentially get more test coverage

The whole point of full_stack_target is to just expose our entire API to the fuzzer and see what happens. Sadly, we're really only exposing a small subset of our API. This improves that by exposing a handful of other assorted methods from ChannelManager and PeerManager.

This will make test_no_existing_test_breakage marginally easier to update.

TheBlueMatt · 2024-02-07T02:33:27Z

Fixed silent rebase conflict and added coverage of channel config updating.

TheBlueMatt · 2024-02-09T00:49:29Z

Diff is fuzz-only and mostly additive so not really worth getting a second review on it.

TheBlueMatt · 2024-01-24T22:05:35Z

Based on #2810, this adds coverage in the full_stack_target which would have caught #2842, both directly (using node announcement generation) and indirectly (with a new test case which tests gossip forwarding).

coderabbitai · 2024-01-24T22:05:59Z

Warning

Rate Limit Exceeded

@TheBlueMatt has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 29 minutes and 40 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 7c94636 and 440a3ea.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

codecov-commenter · 2024-01-24T22:12:06Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e64342a) 89.18% compared to head (7aa06d2) 90.02%.
Report is 9 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@ Coverage Diff @@## main #2850 +/- ##
==========================================
+ Coverage 89.18% 90.02% +0.84% 
==========================================
Files 115 115 Lines 93379 98265 +4886 Branches 93379 98265 +4886 ==========================================
+ Hits 83276 88466 +5190 + Misses 7575 7373 -202 + Partials 2528 2426 -102

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Slightly reducing the amount of data we read to do things.

To potentially get more test coverage

The whole point of full_stack_target is to just expose our entire API to the fuzzer and see what happens. Sadly, we're really only exposing a small subset of our API. This improves that by exposing a handful of other assorted methods from ChannelManager and PeerManager.

This will make test_no_existing_test_breakage marginally easier to update.

TheBlueMatt · 2024-02-07T02:33:27Z

Fixed silent rebase conflict and added coverage of channel config updating.

TheBlueMatt · 2024-02-09T00:49:29Z

Diff is fuzz-only and mostly additive so not really worth getting a second review on it.

TheBlueMatt · 2024-01-24T22:05:35Z

Based on #2810, this adds coverage in the full_stack_target which would have caught #2842, both directly (using node announcement generation) and indirectly (with a new test case which tests gossip forwarding).

coderabbitai · 2024-01-24T22:05:59Z

Warning

Rate Limit Exceeded

@TheBlueMatt has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 29 minutes and 40 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 7c94636 and 440a3ea.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

codecov-commenter · 2024-01-24T22:12:06Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e64342a) 89.18% compared to head (7aa06d2) 90.02%.
Report is 9 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@ Coverage Diff @@## main #2850 +/- ##
==========================================
+ Coverage 89.18% 90.02% +0.84% 
==========================================
Files 115 115 Lines 93379 98265 +4886 Branches 93379 98265 +4886 ==========================================
+ Hits 83276 88466 +5190 + Misses 7575 7373 -202 + Partials 2528 2426 -102

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Slightly reducing the amount of data we read to do things.

To potentially get more test coverage

The whole point of full_stack_target is to just expose our entire API to the fuzzer and see what happens. Sadly, we're really only exposing a small subset of our API. This improves that by exposing a handful of other assorted methods from ChannelManager and PeerManager.

This will make test_no_existing_test_breakage marginally easier to update.

TheBlueMatt · 2024-02-07T02:33:27Z

Fixed silent rebase conflict and added coverage of channel config updating.

TheBlueMatt · 2024-02-09T00:49:29Z

Diff is fuzz-only and mostly additive so not really worth getting a second review on it.

TheBlueMatt · 2024-01-24T22:05:35Z

Based on #2810, this adds coverage in the full_stack_target which would have caught #2842, both directly (using node announcement generation) and indirectly (with a new test case which tests gossip forwarding).

coderabbitai · 2024-01-24T22:05:59Z

Warning

Rate Limit Exceeded

@TheBlueMatt has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 29 minutes and 40 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 7c94636 and 440a3ea.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

codecov-commenter · 2024-01-24T22:12:06Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e64342a) 89.18% compared to head (7aa06d2) 90.02%.
Report is 9 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@ Coverage Diff @@## main #2850 +/- ##
==========================================
+ Coverage 89.18% 90.02% +0.84% 
==========================================
Files 115 115 Lines 93379 98265 +4886 Branches 93379 98265 +4886 ==========================================
+ Hits 83276 88466 +5190 + Misses 7575 7373 -202 + Partials 2528 2426 -102

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Slightly reducing the amount of data we read to do things.

To potentially get more test coverage

The whole point of full_stack_target is to just expose our entire API to the fuzzer and see what happens. Sadly, we're really only exposing a small subset of our API. This improves that by exposing a handful of other assorted methods from ChannelManager and PeerManager.

This will make test_no_existing_test_breakage marginally easier to update.

TheBlueMatt · 2024-02-07T02:33:27Z

Fixed silent rebase conflict and added coverage of channel config updating.

TheBlueMatt · 2024-02-09T00:49:29Z

Diff is fuzz-only and mostly additive so not really worth getting a second review on it.

TheBlueMatt · 2024-01-24T22:05:35Z

Based on #2810, this adds coverage in the full_stack_target which would have caught #2842, both directly (using node announcement generation) and indirectly (with a new test case which tests gossip forwarding).

coderabbitai · 2024-01-24T22:05:59Z

Warning

Rate Limit Exceeded

@TheBlueMatt has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 29 minutes and 40 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 7c94636 and 440a3ea.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

codecov-commenter · 2024-01-24T22:12:06Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e64342a) 89.18% compared to head (7aa06d2) 90.02%.
Report is 9 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@ Coverage Diff @@## main #2850 +/- ##
==========================================
+ Coverage 89.18% 90.02% +0.84% 
==========================================
Files 115 115 Lines 93379 98265 +4886 Branches 93379 98265 +4886 ==========================================
+ Hits 83276 88466 +5190 + Misses 7575 7373 -202 + Partials 2528 2426 -102

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Slightly reducing the amount of data we read to do things.

To potentially get more test coverage

The whole point of full_stack_target is to just expose our entire API to the fuzzer and see what happens. Sadly, we're really only exposing a small subset of our API. This improves that by exposing a handful of other assorted methods from ChannelManager and PeerManager.

This will make test_no_existing_test_breakage marginally easier to update.

TheBlueMatt · 2024-02-07T02:33:27Z

Fixed silent rebase conflict and added coverage of channel config updating.

TheBlueMatt · 2024-02-09T00:49:29Z

Diff is fuzz-only and mostly additive so not really worth getting a second review on it.

TheBlueMatt · 2024-01-24T22:05:35Z

Based on #2810, this adds coverage in the full_stack_target which would have caught #2842, both directly (using node announcement generation) and indirectly (with a new test case which tests gossip forwarding).

coderabbitai · 2024-01-24T22:05:59Z

Warning

Rate Limit Exceeded

@TheBlueMatt has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 29 minutes and 40 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 7c94636 and 440a3ea.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

codecov-commenter · 2024-01-24T22:12:06Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e64342a) 89.18% compared to head (7aa06d2) 90.02%.
Report is 9 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@ Coverage Diff @@## main #2850 +/- ##
==========================================
+ Coverage 89.18% 90.02% +0.84% 
==========================================
Files 115 115 Lines 93379 98265 +4886 Branches 93379 98265 +4886 ==========================================
+ Hits 83276 88466 +5190 + Misses 7575 7373 -202 + Partials 2528 2426 -102

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Slightly reducing the amount of data we read to do things.

To potentially get more test coverage

The whole point of full_stack_target is to just expose our entire API to the fuzzer and see what happens. Sadly, we're really only exposing a small subset of our API. This improves that by exposing a handful of other assorted methods from ChannelManager and PeerManager.

This will make test_no_existing_test_breakage marginally easier to update.

TheBlueMatt · 2024-02-07T02:33:27Z

Fixed silent rebase conflict and added coverage of channel config updating.

TheBlueMatt · 2024-02-09T00:49:29Z

Diff is fuzz-only and mostly additive so not really worth getting a second review on it.

TheBlueMatt force-pushed the 2024-01-fuzz-gossip branch 4 times, most recently from 4944c83 to 440a3eaCompare February 2, 2024 18:06

TheBlueMatt added 2 commits February 5, 2024 23:54

[fuzz] Reduce size of payments_sent in full_stack_target
d1bb0cb
Slightly reducing the amount of data we read to do things.

[fuzz] Fix misc warnings in full_stack_target
a3c4fe9

TheBlueMatt force-pushed the 2024-01-fuzz-gossip branch from 440a3ea to b703226Compare February 5, 2024 23:54

wpaulino reviewed Feb 6, 2024
View reviewed changes

Comment threadfuzz/src/full_stack.rs
Comment threadfuzz/src/full_stack.rs

TheBlueMatt added 5 commits February 7, 2024 02:32

[fuzz] Use batch funding in full_stack_target
a17df4f
To potentially get more test coverage

[fuzz] De-dup hex in test_no_existing_test_breakage
207fbb0
This will make test_no_existing_test_breakage marginally easier to update.

[fuzz] Add a second full_stack_target seed test for gossip
e63fc65

[fuzz] Add fst coverage for ChannelManager::update_channel_config
7aa06d2

TheBlueMatt force-pushed the 2024-01-fuzz-gossip branch from b703226 to 7aa06d2Compare February 7, 2024 02:33

wpaulino approved these changes Feb 7, 2024
View reviewed changes

TheBlueMatt merged commit d70124c into lightningdevkit:mainFeb 9, 2024