Uh oh!
There was an error while loading. Please reload this page.
Add support for parsing the dns_resolver feature bit - #3346
Conversation
This feature bit is used to indicate that a node will make DNS queries on behalf of onion message senders, returning DNSSEC TXT proofs for the requested names. It is used to signal support for bLIP 32 resolution and can be used to find nodes from which we can try to resolve BIP 32 HRNs.
A `DNSResolverMessageHandler` which handles resolution requests should want the `NodeFeatures` included in the node's `node_announcement` to include `dns_resolver` to indicate to the world that it provides that service. Here we enable this by requesting extra feature flags from the `DNSResolverMessageHandler` in the features `OnionMessenger`, in turn, provides to `PeerManager` (which builds the `node_announcement`).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #3346 +/- ##
==========================================
- Coverage 89.59% 89.56% -0.03%
==========================================
Files 127 127 Lines 103438 103441 +3 Branches 103438 103441 +3 ==========================================
- Hits 92672 92651 -21 - Misses 8049 8066 +17 - Partials 2717 2724 +7 ☔ View full report in Codecov by Sentry. |
vincenzopalazzo
left a comment
There was a problem hiding this comment.
Small question otherwise LGMT
| // Byte 7 | ||
| Trampoline, | ||
| // Byte 8 - 31 | ||
| ,,,,,,,,,,,,,,,,,,,,,,,, |
There was a problem hiding this comment.
what ,,,,,,,,,,,,,,,,,,,,,,,, means in this case?
There was a problem hiding this comment.
These are used by define_context! to form KNOWN_FEATURE_MASK, which needs bytes 8-31 zeroed.
| // Byte 7 | ||
| Trampoline, | ||
| // Byte 8 - 31 | ||
| ,,,,,,,,,,,,,,,,,,,,,,,, |
There was a problem hiding this comment.
These are used by define_context! to form KNOWN_FEATURE_MASK, which needs bytes 8-31 zeroed.
dunxen
commented
Oct 8, 2024
Matches what's in bLIPs repo. LGTM |
This feature bit is used to indicate that a node will make DNS
queries on behalf of onion message senders, returning DNSSEC TXT
proofs for the requested names.
It is used to signal support for bLIP 32 resolution and can be used
to find nodes from which we can try to resolve BIP 32 HRNs.
#3283 will want to use this, so after both PRs are merged we'll need one more commit to set the feature flag, but #3283 is already getting kinda big so keeping this separate.