Skip to content

Add support for parsing the dns_resolver feature bit#3346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheBlueMatt merged 2 commits into from
Oct 8, 2024
Merged

Add support for parsing the dns_resolver feature bit #3346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1abbe2a
Add support for parsing the `dns_resolver` feature bit
TheBlueMatt Oct 2, 2024
457b634
Allow a `DNSResolverMessageHandler` to set `dns_resolver` feature
TheBlueMatt Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions lightning-types/src/features.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -68,6 +68,8 @@
//! (see the [`Keysend` feature assignment proposal](https://github.com/lightning/bolts/issues/605#issuecomment-606679798) for more information).
//! - `Trampoline` - supports receiving and forwarding Trampoline payments
//! (see the [`Trampoline` feature proposal](https://github.com/lightning/bolts/pull/836) for more information).
//! - `DnsResolver` - supports resolving DNS names to TXT DNSSEC proofs for BIP 353 payments
//! (see [bLIP 32](https://github.com/lightning/blips/blob/master/blip-0032.md) for more information).
//!
//! LDK knows about the following features, but does not support them:
//! - `AnchorsNonzeroFeeHtlcTx` - the initial version of anchor outputs, which was later found to be
Expand DownExpand Up@@ -177,6 +179,10 @@ mod sealed {
ZeroConf | Keysend,
// Byte 7
Trampoline,
// Byte 8 - 31
,,,,,,,,,,,,,,,,,,,,,,,,

@vincenzopalazzovincenzopalazzoOct 8, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what ,,,,,,,,,,,,,,,,,,,,,,,, means in this case?

@jkczyzjkczyzOct 8, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are used by define_context! to form KNOWN_FEATURE_MASK, which needs bytes 8-31 zeroed.

// Byte 32
DnsResolver,
]
);
define_context!(ChannelContext, []);
Expand DownExpand Up@@ -565,6 +571,17 @@ mod sealed {
supports_trampoline_routing,
requires_trampoline_routing
);
define_feature!(
259,
DnsResolver,
[NodeContext],
"Feature flags for DNS resolving.",
set_dns_resolution_optional,
set_dns_resolution_required,
supports_dns_resolution,
requires_dns_resolution
);

// Note: update the module-level docs when a new feature bit is added!

#[cfg(any(test, feature = "_test_utils"))]
Expand Down
9 changes: 9 additions & 0 deletions lightning/src/onion_message/dns_resolution.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,8 @@ use dnssec_prover::validation::verify_rr_stream;

use dnssec_prover::rr::Name;

use lightning_types::features::NodeFeatures;

use crate::blinded_path::message::DNSResolverContext;
use crate::io;
#[cfg(feature = "dnssec")]
Expand DownExpand Up@@ -67,6 +69,13 @@ pub trait DNSResolverMessageHandler {
/// With this, we should be able to validate the DNS record we requested.
fn handle_dnssec_proof(&self, message: DNSSECProof, context: DNSResolverContext);

/// Gets the node feature flags which this handler itself supports. Useful for setting the
/// `dns_resolver` flag if this handler supports returning [`DNSSECProof`] messages in response
/// to [`DNSSECQuery`] messages.
fn provided_node_features(&self) -> NodeFeatures {
NodeFeatures::empty()
}

/// Release any [`DNSResolverMessage`]s that need to be sent.
fn release_pending_messages(&self) -> Vec<(DNSResolverMessage, MessageSendInstructions)> {
vec![]
Expand Down
2 changes: 1 addition & 1 deletion lightning/src/onion_message/messenger.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1778,7 +1778,7 @@ where
fn provided_node_features(&self) -> NodeFeatures {
let mut features = NodeFeatures::empty();
features.set_onion_messages_optional();
features
features | self.dns_resolver_handler.provided_node_features()
}

fn provided_init_features(&self, _their_node_id: PublicKey) -> InitFeatures {
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Add support for parsing the dns_resolver feature bit by TheBlueMatt · Pull Request #3346 · lightningdevkit/rust-lightning · GitHub
Skip to content
Add support for parsing the dns_resolver feature bit#3346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TheBlueMatt
merged 2 commits into

from

Oct 8, 2024
 Merged


Add support for parsing the dns_resolver feature bit
#3346
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
1abbe2a

Add support for parsing the `dns_resolver` feature bit


TheBlueMatt Oct 2, 2024
457b634

Allow a `DNSResolverMessageHandler` to set `dns_resolver` feature


TheBlueMatt Oct 2, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


17 changes: 17 additions & 0 deletions
lightning-types/src/features.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -68,6 +68,8 @@
//! (see the [`Keysend` feature assignment proposal](https://github.com/lightning/bolts/issues/605#issuecomment-606679798) for more information).
//! - `Trampoline` - supports receiving and forwarding Trampoline payments
//! (see the [`Trampoline` feature proposal](https://github.com/lightning/bolts/pull/836) for more information).
//! - `DnsResolver` - supports resolving DNS names to TXT DNSSEC proofs for BIP 353 payments
//! (see [bLIP 32](https://github.com/lightning/blips/blob/master/blip-0032.md) for more information).
//!
//! LDK knows about the following features, but does not support them:
//! - `AnchorsNonzeroFeeHtlcTx` - the initial version of anchor outputs, which was later found to be
Expand DownExpand Up@@ -177,6 +179,10 @@ mod sealed {
 ZeroConf | Keysend,
 // Byte 7
 Trampoline,
 // Byte 8 - 31
 ,,,,,,,,,,,,,,,,,,,,,,,,
@vincenzopalazzovincenzopalazzoOct 8, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what ,,,,,,,,,,,,,,,,,,,,,,,, means in this case?
@jkczyzjkczyzOct 8, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are used by define_context! to form KNOWN_FEATURE_MASK, which needs bytes 8-31 zeroed.
 // Byte 32
 DnsResolver,
 ]
	);
	define_context!(ChannelContext, []);
Expand DownExpand Up@@ -565,6 +571,17 @@ mod sealed {
 supports_trampoline_routing,
 requires_trampoline_routing
	);
	define_feature!(
 259,
 DnsResolver,
 [NodeContext],
 "Feature flags for DNS resolving.",
 set_dns_resolution_optional,
 set_dns_resolution_required,
 supports_dns_resolution,
 requires_dns_resolution
	);

	// Note: update the module-level docs when a new feature bit is added!

	#[cfg(any(test, feature = "_test_utils"))]
Expand Down

9 changes: 9 additions & 0 deletions
lightning/src/onion_message/dns_resolution.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,8 @@ use dnssec_prover::validation::verify_rr_stream;

use dnssec_prover::rr::Name;

use lightning_types::features::NodeFeatures;

use crate::blinded_path::message::DNSResolverContext;
use crate::io;
#[cfg(feature = "dnssec")]
Expand DownExpand Up@@ -67,6 +69,13 @@ pub trait DNSResolverMessageHandler {
	/// With this, we should be able to validate the DNS record we requested.
	fn handle_dnssec_proof(&self, message: DNSSECProof, context: DNSResolverContext);

	/// Gets the node feature flags which this handler itself supports. Useful for setting the
	/// `dns_resolver` flag if this handler supports returning [`DNSSECProof`] messages in response
	/// to [`DNSSECQuery`] messages.
	fn provided_node_features(&self) -> NodeFeatures {
 NodeFeatures::empty()
	}

	/// Release any [`DNSResolverMessage`]s that need to be sent.
	fn release_pending_messages(&self) -> Vec<(DNSResolverMessage, MessageSendInstructions)> {
 vec![]
Expand Down

2 changes: 1 addition & 1 deletion
lightning/src/onion_message/messenger.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1778,7 +1778,7 @@ where
	fn provided_node_features(&self) -> NodeFeatures {
 let mut features = NodeFeatures::empty();
 features.set_onion_messages_optional();
 features
 features | self.dns_resolver_handler.provided_node_features()
	}

	fn provided_init_features(&self, _their_node_id: PublicKey) -> InitFeatures {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add support for parsing the dns_resolver feature bit by TheBlueMatt · Pull Request #3346 · lightningdevkit/rust-lightning · GitHub
Skip to content
Add support for parsing the dns_resolver feature bit#3346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TheBlueMatt
merged 2 commits into

from

Oct 8, 2024
 Merged


Add support for parsing the dns_resolver feature bit
#3346
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
1abbe2a

Add support for parsing the `dns_resolver` feature bit


TheBlueMatt Oct 2, 2024
457b634

Allow a `DNSResolverMessageHandler` to set `dns_resolver` feature


TheBlueMatt Oct 2, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


17 changes: 17 additions & 0 deletions
lightning-types/src/features.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -68,6 +68,8 @@
//! (see the [`Keysend` feature assignment proposal](https://github.com/lightning/bolts/issues/605#issuecomment-606679798) for more information).
//! - `Trampoline` - supports receiving and forwarding Trampoline payments
//! (see the [`Trampoline` feature proposal](https://github.com/lightning/bolts/pull/836) for more information).
//! - `DnsResolver` - supports resolving DNS names to TXT DNSSEC proofs for BIP 353 payments
//! (see [bLIP 32](https://github.com/lightning/blips/blob/master/blip-0032.md) for more information).
//!
//! LDK knows about the following features, but does not support them:
//! - `AnchorsNonzeroFeeHtlcTx` - the initial version of anchor outputs, which was later found to be
Expand DownExpand Up@@ -177,6 +179,10 @@ mod sealed {
 ZeroConf | Keysend,
 // Byte 7
 Trampoline,
 // Byte 8 - 31
 ,,,,,,,,,,,,,,,,,,,,,,,,
@vincenzopalazzovincenzopalazzoOct 8, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what ,,,,,,,,,,,,,,,,,,,,,,,, means in this case?
@jkczyzjkczyzOct 8, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are used by define_context! to form KNOWN_FEATURE_MASK, which needs bytes 8-31 zeroed.
 // Byte 32
 DnsResolver,
 ]
	);
	define_context!(ChannelContext, []);
Expand DownExpand Up@@ -565,6 +571,17 @@ mod sealed {
 supports_trampoline_routing,
 requires_trampoline_routing
	);
	define_feature!(
 259,
 DnsResolver,
 [NodeContext],
 "Feature flags for DNS resolving.",
 set_dns_resolution_optional,
 set_dns_resolution_required,
 supports_dns_resolution,
 requires_dns_resolution
	);

	// Note: update the module-level docs when a new feature bit is added!

	#[cfg(any(test, feature = "_test_utils"))]
Expand Down

9 changes: 9 additions & 0 deletions
lightning/src/onion_message/dns_resolution.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,8 @@ use dnssec_prover::validation::verify_rr_stream;

use dnssec_prover::rr::Name;

use lightning_types::features::NodeFeatures;

use crate::blinded_path::message::DNSResolverContext;
use crate::io;
#[cfg(feature = "dnssec")]
Expand DownExpand Up@@ -67,6 +69,13 @@ pub trait DNSResolverMessageHandler {
	/// With this, we should be able to validate the DNS record we requested.
	fn handle_dnssec_proof(&self, message: DNSSECProof, context: DNSResolverContext);

	/// Gets the node feature flags which this handler itself supports. Useful for setting the
	/// `dns_resolver` flag if this handler supports returning [`DNSSECProof`] messages in response
	/// to [`DNSSECQuery`] messages.
	fn provided_node_features(&self) -> NodeFeatures {
 NodeFeatures::empty()
	}

	/// Release any [`DNSResolverMessage`]s that need to be sent.
	fn release_pending_messages(&self) -> Vec<(DNSResolverMessage, MessageSendInstructions)> {
 vec![]
Expand Down

2 changes: 1 addition & 1 deletion
lightning/src/onion_message/messenger.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1778,7 +1778,7 @@ where
	fn provided_node_features(&self) -> NodeFeatures {
 let mut features = NodeFeatures::empty();
 features.set_onion_messages_optional();
 features
 features | self.dns_resolver_handler.provided_node_features()
	}

	fn provided_init_features(&self, _their_node_id: PublicKey) -> InitFeatures {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add support for parsing the dns_resolver feature bit by TheBlueMatt · Pull Request #3346 · lightningdevkit/rust-lightning · GitHub
Skip to content
Add support for parsing the dns_resolver feature bit#3346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TheBlueMatt
merged 2 commits into

from

Oct 8, 2024
 Merged


Add support for parsing the dns_resolver feature bit
#3346
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
1abbe2a

Add support for parsing the `dns_resolver` feature bit


TheBlueMatt Oct 2, 2024
457b634

Allow a `DNSResolverMessageHandler` to set `dns_resolver` feature


TheBlueMatt Oct 2, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


17 changes: 17 additions & 0 deletions
lightning-types/src/features.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -68,6 +68,8 @@
//! (see the [`Keysend` feature assignment proposal](https://github.com/lightning/bolts/issues/605#issuecomment-606679798) for more information).
//! - `Trampoline` - supports receiving and forwarding Trampoline payments
//! (see the [`Trampoline` feature proposal](https://github.com/lightning/bolts/pull/836) for more information).
//! - `DnsResolver` - supports resolving DNS names to TXT DNSSEC proofs for BIP 353 payments
//! (see [bLIP 32](https://github.com/lightning/blips/blob/master/blip-0032.md) for more information).
//!
//! LDK knows about the following features, but does not support them:
//! - `AnchorsNonzeroFeeHtlcTx` - the initial version of anchor outputs, which was later found to be
Expand DownExpand Up@@ -177,6 +179,10 @@ mod sealed {
 ZeroConf | Keysend,
 // Byte 7
 Trampoline,
 // Byte 8 - 31
 ,,,,,,,,,,,,,,,,,,,,,,,,
@vincenzopalazzovincenzopalazzoOct 8, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what ,,,,,,,,,,,,,,,,,,,,,,,, means in this case?
@jkczyzjkczyzOct 8, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are used by define_context! to form KNOWN_FEATURE_MASK, which needs bytes 8-31 zeroed.
 // Byte 32
 DnsResolver,
 ]
	);
	define_context!(ChannelContext, []);
Expand DownExpand Up@@ -565,6 +571,17 @@ mod sealed {
 supports_trampoline_routing,
 requires_trampoline_routing
	);
	define_feature!(
 259,
 DnsResolver,
 [NodeContext],
 "Feature flags for DNS resolving.",
 set_dns_resolution_optional,
 set_dns_resolution_required,
 supports_dns_resolution,
 requires_dns_resolution
	);

	// Note: update the module-level docs when a new feature bit is added!

	#[cfg(any(test, feature = "_test_utils"))]
Expand Down

9 changes: 9 additions & 0 deletions
lightning/src/onion_message/dns_resolution.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,8 @@ use dnssec_prover::validation::verify_rr_stream;

use dnssec_prover::rr::Name;

use lightning_types::features::NodeFeatures;

use crate::blinded_path::message::DNSResolverContext;
use crate::io;
#[cfg(feature = "dnssec")]
Expand DownExpand Up@@ -67,6 +69,13 @@ pub trait DNSResolverMessageHandler {
	/// With this, we should be able to validate the DNS record we requested.
	fn handle_dnssec_proof(&self, message: DNSSECProof, context: DNSResolverContext);

	/// Gets the node feature flags which this handler itself supports. Useful for setting the
	/// `dns_resolver` flag if this handler supports returning [`DNSSECProof`] messages in response
	/// to [`DNSSECQuery`] messages.
	fn provided_node_features(&self) -> NodeFeatures {
 NodeFeatures::empty()
	}

	/// Release any [`DNSResolverMessage`]s that need to be sent.
	fn release_pending_messages(&self) -> Vec<(DNSResolverMessage, MessageSendInstructions)> {
 vec![]
Expand Down

2 changes: 1 addition & 1 deletion
lightning/src/onion_message/messenger.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1778,7 +1778,7 @@ where
	fn provided_node_features(&self) -> NodeFeatures {
 let mut features = NodeFeatures::empty();
 features.set_onion_messages_optional();
 features
 features | self.dns_resolver_handler.provided_node_features()
	}

	fn provided_init_features(&self, _their_node_id: PublicKey) -> InitFeatures {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Add support for parsing the dns_resolver feature bit by TheBlueMatt · Pull Request #3346 · lightningdevkit/rust-lightning · GitHub
Skip to content
Add support for parsing the dns_resolver feature bit#3346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TheBlueMatt
merged 2 commits into

from

Oct 8, 2024
 Merged


Add support for parsing the dns_resolver feature bit
#3346
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
1abbe2a

Add support for parsing the `dns_resolver` feature bit


TheBlueMatt Oct 2, 2024
457b634

Allow a `DNSResolverMessageHandler` to set `dns_resolver` feature


TheBlueMatt Oct 2, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


17 changes: 17 additions & 0 deletions
lightning-types/src/features.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -68,6 +68,8 @@
//! (see the [`Keysend` feature assignment proposal](https://github.com/lightning/bolts/issues/605#issuecomment-606679798) for more information).
//! - `Trampoline` - supports receiving and forwarding Trampoline payments
//! (see the [`Trampoline` feature proposal](https://github.com/lightning/bolts/pull/836) for more information).
//! - `DnsResolver` - supports resolving DNS names to TXT DNSSEC proofs for BIP 353 payments
//! (see [bLIP 32](https://github.com/lightning/blips/blob/master/blip-0032.md) for more information).
//!
//! LDK knows about the following features, but does not support them:
//! - `AnchorsNonzeroFeeHtlcTx` - the initial version of anchor outputs, which was later found to be
Expand DownExpand Up@@ -177,6 +179,10 @@ mod sealed {
 ZeroConf | Keysend,
 // Byte 7
 Trampoline,
 // Byte 8 - 31
 ,,,,,,,,,,,,,,,,,,,,,,,,
@vincenzopalazzovincenzopalazzoOct 8, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what ,,,,,,,,,,,,,,,,,,,,,,,, means in this case?
@jkczyzjkczyzOct 8, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are used by define_context! to form KNOWN_FEATURE_MASK, which needs bytes 8-31 zeroed.
 // Byte 32
 DnsResolver,
 ]
	);
	define_context!(ChannelContext, []);
Expand DownExpand Up@@ -565,6 +571,17 @@ mod sealed {
 supports_trampoline_routing,
 requires_trampoline_routing
	);
	define_feature!(
 259,
 DnsResolver,
 [NodeContext],
 "Feature flags for DNS resolving.",
 set_dns_resolution_optional,
 set_dns_resolution_required,
 supports_dns_resolution,
 requires_dns_resolution
	);

	// Note: update the module-level docs when a new feature bit is added!

	#[cfg(any(test, feature = "_test_utils"))]
Expand Down

9 changes: 9 additions & 0 deletions
lightning/src/onion_message/dns_resolution.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,8 @@ use dnssec_prover::validation::verify_rr_stream;

use dnssec_prover::rr::Name;

use lightning_types::features::NodeFeatures;

use crate::blinded_path::message::DNSResolverContext;
use crate::io;
#[cfg(feature = "dnssec")]
Expand DownExpand Up@@ -67,6 +69,13 @@ pub trait DNSResolverMessageHandler {
	/// With this, we should be able to validate the DNS record we requested.
	fn handle_dnssec_proof(&self, message: DNSSECProof, context: DNSResolverContext);

	/// Gets the node feature flags which this handler itself supports. Useful for setting the
	/// `dns_resolver` flag if this handler supports returning [`DNSSECProof`] messages in response
	/// to [`DNSSECQuery`] messages.
	fn provided_node_features(&self) -> NodeFeatures {
 NodeFeatures::empty()
	}

	/// Release any [`DNSResolverMessage`]s that need to be sent.
	fn release_pending_messages(&self) -> Vec<(DNSResolverMessage, MessageSendInstructions)> {
 vec![]
Expand Down

2 changes: 1 addition & 1 deletion
lightning/src/onion_message/messenger.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1778,7 +1778,7 @@ where
	fn provided_node_features(&self) -> NodeFeatures {
 let mut features = NodeFeatures::empty();
 features.set_onion_messages_optional();
 features
 features | self.dns_resolver_handler.provided_node_features()
	}

	fn provided_init_features(&self, _their_node_id: PublicKey) -> InitFeatures {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add support for parsing the dns_resolver feature bit by TheBlueMatt · Pull Request #3346 · lightningdevkit/rust-lightning · GitHub
Skip to content
Add support for parsing the dns_resolver feature bit#3346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TheBlueMatt
merged 2 commits into

from

Oct 8, 2024
 Merged


Add support for parsing the dns_resolver feature bit
#3346
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
1abbe2a

Add support for parsing the `dns_resolver` feature bit


TheBlueMatt Oct 2, 2024
457b634

Allow a `DNSResolverMessageHandler` to set `dns_resolver` feature


TheBlueMatt Oct 2, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


17 changes: 17 additions & 0 deletions
lightning-types/src/features.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -68,6 +68,8 @@
//! (see the [`Keysend` feature assignment proposal](https://github.com/lightning/bolts/issues/605#issuecomment-606679798) for more information).
//! - `Trampoline` - supports receiving and forwarding Trampoline payments
//! (see the [`Trampoline` feature proposal](https://github.com/lightning/bolts/pull/836) for more information).
//! - `DnsResolver` - supports resolving DNS names to TXT DNSSEC proofs for BIP 353 payments
//! (see [bLIP 32](https://github.com/lightning/blips/blob/master/blip-0032.md) for more information).
//!
//! LDK knows about the following features, but does not support them:
//! - `AnchorsNonzeroFeeHtlcTx` - the initial version of anchor outputs, which was later found to be
Expand DownExpand Up@@ -177,6 +179,10 @@ mod sealed {
 ZeroConf | Keysend,
 // Byte 7
 Trampoline,
 // Byte 8 - 31
 ,,,,,,,,,,,,,,,,,,,,,,,,
@vincenzopalazzovincenzopalazzoOct 8, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what ,,,,,,,,,,,,,,,,,,,,,,,, means in this case?
@jkczyzjkczyzOct 8, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are used by define_context! to form KNOWN_FEATURE_MASK, which needs bytes 8-31 zeroed.
 // Byte 32
 DnsResolver,
 ]
	);
	define_context!(ChannelContext, []);
Expand DownExpand Up@@ -565,6 +571,17 @@ mod sealed {
 supports_trampoline_routing,
 requires_trampoline_routing
	);
	define_feature!(
 259,
 DnsResolver,
 [NodeContext],
 "Feature flags for DNS resolving.",
 set_dns_resolution_optional,
 set_dns_resolution_required,
 supports_dns_resolution,
 requires_dns_resolution
	);

	// Note: update the module-level docs when a new feature bit is added!

	#[cfg(any(test, feature = "_test_utils"))]
Expand Down

9 changes: 9 additions & 0 deletions
lightning/src/onion_message/dns_resolution.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,8 @@ use dnssec_prover::validation::verify_rr_stream;

use dnssec_prover::rr::Name;

use lightning_types::features::NodeFeatures;

use crate::blinded_path::message::DNSResolverContext;
use crate::io;
#[cfg(feature = "dnssec")]
Expand DownExpand Up@@ -67,6 +69,13 @@ pub trait DNSResolverMessageHandler {
	/// With this, we should be able to validate the DNS record we requested.
	fn handle_dnssec_proof(&self, message: DNSSECProof, context: DNSResolverContext);

	/// Gets the node feature flags which this handler itself supports. Useful for setting the
	/// `dns_resolver` flag if this handler supports returning [`DNSSECProof`] messages in response
	/// to [`DNSSECQuery`] messages.
	fn provided_node_features(&self) -> NodeFeatures {
 NodeFeatures::empty()
	}

	/// Release any [`DNSResolverMessage`]s that need to be sent.
	fn release_pending_messages(&self) -> Vec<(DNSResolverMessage, MessageSendInstructions)> {
 vec![]
Expand Down

2 changes: 1 addition & 1 deletion
lightning/src/onion_message/messenger.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1778,7 +1778,7 @@ where
	fn provided_node_features(&self) -> NodeFeatures {
 let mut features = NodeFeatures::empty();
 features.set_onion_messages_optional();
 features
 features | self.dns_resolver_handler.provided_node_features()
	}

	fn provided_init_features(&self, _their_node_id: PublicKey) -> InitFeatures {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add support for parsing the dns_resolver feature bit by TheBlueMatt · Pull Request #3346 · lightningdevkit/rust-lightning · GitHub
Skip to content
Add support for parsing the dns_resolver feature bit#3346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TheBlueMatt
merged 2 commits into

from

Oct 8, 2024
 Merged


Add support for parsing the dns_resolver feature bit
#3346
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
1abbe2a

Add support for parsing the `dns_resolver` feature bit


TheBlueMatt Oct 2, 2024
457b634

Allow a `DNSResolverMessageHandler` to set `dns_resolver` feature


TheBlueMatt Oct 2, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


17 changes: 17 additions & 0 deletions
lightning-types/src/features.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -68,6 +68,8 @@
//! (see the [`Keysend` feature assignment proposal](https://github.com/lightning/bolts/issues/605#issuecomment-606679798) for more information).
//! - `Trampoline` - supports receiving and forwarding Trampoline payments
//! (see the [`Trampoline` feature proposal](https://github.com/lightning/bolts/pull/836) for more information).
//! - `DnsResolver` - supports resolving DNS names to TXT DNSSEC proofs for BIP 353 payments
//! (see [bLIP 32](https://github.com/lightning/blips/blob/master/blip-0032.md) for more information).
//!
//! LDK knows about the following features, but does not support them:
//! - `AnchorsNonzeroFeeHtlcTx` - the initial version of anchor outputs, which was later found to be
Expand DownExpand Up@@ -177,6 +179,10 @@ mod sealed {
 ZeroConf | Keysend,
 // Byte 7
 Trampoline,
 // Byte 8 - 31
 ,,,,,,,,,,,,,,,,,,,,,,,,
@vincenzopalazzovincenzopalazzoOct 8, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what ,,,,,,,,,,,,,,,,,,,,,,,, means in this case?
@jkczyzjkczyzOct 8, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are used by define_context! to form KNOWN_FEATURE_MASK, which needs bytes 8-31 zeroed.
 // Byte 32
 DnsResolver,
 ]
	);
	define_context!(ChannelContext, []);
Expand DownExpand Up@@ -565,6 +571,17 @@ mod sealed {
 supports_trampoline_routing,
 requires_trampoline_routing
	);
	define_feature!(
 259,
 DnsResolver,
 [NodeContext],
 "Feature flags for DNS resolving.",
 set_dns_resolution_optional,
 set_dns_resolution_required,
 supports_dns_resolution,
 requires_dns_resolution
	);

	// Note: update the module-level docs when a new feature bit is added!

	#[cfg(any(test, feature = "_test_utils"))]
Expand Down

9 changes: 9 additions & 0 deletions
lightning/src/onion_message/dns_resolution.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,8 @@ use dnssec_prover::validation::verify_rr_stream;

use dnssec_prover::rr::Name;

use lightning_types::features::NodeFeatures;

use crate::blinded_path::message::DNSResolverContext;
use crate::io;
#[cfg(feature = "dnssec")]
Expand DownExpand Up@@ -67,6 +69,13 @@ pub trait DNSResolverMessageHandler {
	/// With this, we should be able to validate the DNS record we requested.
	fn handle_dnssec_proof(&self, message: DNSSECProof, context: DNSResolverContext);

	/// Gets the node feature flags which this handler itself supports. Useful for setting the
	/// `dns_resolver` flag if this handler supports returning [`DNSSECProof`] messages in response
	/// to [`DNSSECQuery`] messages.
	fn provided_node_features(&self) -> NodeFeatures {
 NodeFeatures::empty()
	}

	/// Release any [`DNSResolverMessage`]s that need to be sent.
	fn release_pending_messages(&self) -> Vec<(DNSResolverMessage, MessageSendInstructions)> {
 vec![]
Expand Down

2 changes: 1 addition & 1 deletion
lightning/src/onion_message/messenger.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1778,7 +1778,7 @@ where
	fn provided_node_features(&self) -> NodeFeatures {
 let mut features = NodeFeatures::empty();
 features.set_onion_messages_optional();
 features
 features | self.dns_resolver_handler.provided_node_features()
	}

	fn provided_init_features(&self, _their_node_id: PublicKey) -> InitFeatures {
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Add support for parsing the dns_resolver feature bit by TheBlueMatt · Pull Request #3346 · lightningdevkit/rust-lightning · GitHub
Skip to content
Add support for parsing the dns_resolver feature bit#3346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TheBlueMatt
merged 2 commits into

from

Oct 8, 2024
 Merged


Add support for parsing the dns_resolver feature bit
#3346
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
1abbe2a

Add support for parsing the `dns_resolver` feature bit


TheBlueMatt Oct 2, 2024
457b634

Allow a `DNSResolverMessageHandler` to set `dns_resolver` feature


TheBlueMatt Oct 2, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


17 changes: 17 additions & 0 deletions
lightning-types/src/features.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -68,6 +68,8 @@
//! (see the [`Keysend` feature assignment proposal](https://github.com/lightning/bolts/issues/605#issuecomment-606679798) for more information).
//! - `Trampoline` - supports receiving and forwarding Trampoline payments
//! (see the [`Trampoline` feature proposal](https://github.com/lightning/bolts/pull/836) for more information).
//! - `DnsResolver` - supports resolving DNS names to TXT DNSSEC proofs for BIP 353 payments
//! (see [bLIP 32](https://github.com/lightning/blips/blob/master/blip-0032.md) for more information).
//!
//! LDK knows about the following features, but does not support them:
//! - `AnchorsNonzeroFeeHtlcTx` - the initial version of anchor outputs, which was later found to be
Expand DownExpand Up@@ -177,6 +179,10 @@ mod sealed {
 ZeroConf | Keysend,
 // Byte 7
 Trampoline,
 // Byte 8 - 31
 ,,,,,,,,,,,,,,,,,,,,,,,,
@vincenzopalazzovincenzopalazzoOct 8, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what ,,,,,,,,,,,,,,,,,,,,,,,, means in this case?
@jkczyzjkczyzOct 8, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are used by define_context! to form KNOWN_FEATURE_MASK, which needs bytes 8-31 zeroed.
 // Byte 32
 DnsResolver,
 ]
	);
	define_context!(ChannelContext, []);
Expand DownExpand Up@@ -565,6 +571,17 @@ mod sealed {
 supports_trampoline_routing,
 requires_trampoline_routing
	);
	define_feature!(
 259,
 DnsResolver,
 [NodeContext],
 "Feature flags for DNS resolving.",
 set_dns_resolution_optional,
 set_dns_resolution_required,
 supports_dns_resolution,
 requires_dns_resolution
	);

	// Note: update the module-level docs when a new feature bit is added!

	#[cfg(any(test, feature = "_test_utils"))]
Expand Down

9 changes: 9 additions & 0 deletions
lightning/src/onion_message/dns_resolution.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,8 @@ use dnssec_prover::validation::verify_rr_stream;

use dnssec_prover::rr::Name;

use lightning_types::features::NodeFeatures;

use crate::blinded_path::message::DNSResolverContext;
use crate::io;
#[cfg(feature = "dnssec")]
Expand DownExpand Up@@ -67,6 +69,13 @@ pub trait DNSResolverMessageHandler {
	/// With this, we should be able to validate the DNS record we requested.
	fn handle_dnssec_proof(&self, message: DNSSECProof, context: DNSResolverContext);

	/// Gets the node feature flags which this handler itself supports. Useful for setting the
	/// `dns_resolver` flag if this handler supports returning [`DNSSECProof`] messages in response
	/// to [`DNSSECQuery`] messages.
	fn provided_node_features(&self) -> NodeFeatures {
 NodeFeatures::empty()
	}

	/// Release any [`DNSResolverMessage`]s that need to be sent.
	fn release_pending_messages(&self) -> Vec<(DNSResolverMessage, MessageSendInstructions)> {
 vec![]
Expand Down

2 changes: 1 addition & 1 deletion
lightning/src/onion_message/messenger.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1778,7 +1778,7 @@ where
	fn provided_node_features(&self) -> NodeFeatures {
 let mut features = NodeFeatures::empty();
 features.set_onion_messages_optional();
 features
 features | self.dns_resolver_handler.provided_node_features()
	}

	fn provided_init_features(&self, _their_node_id: PublicKey) -> InitFeatures {
Expand Down