Skip to content

Fix fuzz CI failures - #3521

Merged
tnull merged 1 commit into
lightningdevkit:mainfrom
TheBlueMatt:2025-01-fix-pin
Jan 13, 2025
Merged

Fix fuzz CI failures#3521
tnull merged 1 commit into
lightningdevkit:mainfrom
TheBlueMatt:2025-01-fix-pin

Conversation

@TheBlueMatt

Copy link
Copy Markdown
Collaborator

No description provided.

@codecov

codecovBot commented Jan 10, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.02%. Comparing base (463e432) to head (9bb6358).
Report is 15 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #3521 +/- ##
==========================================
+ Coverage 88.34% 89.02% +0.68% 
==========================================
Files 149 149 Lines 112915 116871 +3956 Branches 112915 116871 +3956 ==========================================
+ Hits 99753 104044 +4291 + Misses 10685 10406 -279 + Partials 2477 2421 -56 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tnull

Copy link
Copy Markdown
Contributor

Let's just finally figure out a secondary MSRV target for lightning-transaction-sync and affected crates instead? In the next few days I intend to take a look at potential candidates and propose a target that would make sense for LDK Node, and hopefully it would find adoption by affected BDK crates, too.

@TheBlueMatt

Copy link
Copy Markdown
CollaboratorAuthor

Sure, we could do that too. We should get that fixed ASAP, though, because it'd be nice to have passing CI to release 0.1...

@TheBlueMattTheBlueMatt added this to the 0.1 milestone Jan 12, 2025
@tnull

tnull commented Jan 13, 2025

Copy link
Copy Markdown
Contributor

Sure, we could do that too. We should get that fixed ASAP, though, because it'd be nice to have passing CI to release 0.1...

Alright, now opened a respective/alternative PR here: #3528

If we move forward with that I'll also land lightningdevkit/ldk-node#429, and when recently talking to BDK, they seemed happy to more or less follow whatever MSRV bump we propose. Also see bitcoindevkit/bdk#1750.

@TheBlueMattTheBlueMatt changed the title Detect the current version of rustls before pinningFix fuzz CI failuresJan 13, 2025
@TheBlueMatt

Copy link
Copy Markdown
CollaboratorAuthor

Okay, will only fix fuzz CI failures here, though I still want to do that.

@tnull
tnull merged commit c835e80 into lightningdevkit:mainJan 13, 2025
@TheBlueMattTheBlueMatt mentioned this pull request Jan 14, 2025
@TheBlueMatt

Copy link
Copy Markdown
CollaboratorAuthor

Backported in #3536.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TheBlueMatt@tnull@wpaulino