Move lightning-transaction-sync tests to dedicated script

[tnull]

.. and bump its MSRV to 1.75.

Recently, rustls bumped their MSRV to v1.71. As we depend on them and don't want to continuously pin this security-critical dependency back, we have no choice left but to bump the MSRV for lightning-transaction-sync to a version >= v1.71, too.

Here, we hence move the lightning-transaction-sync tests to a dedicated script and propose to introduce a secondary MSRV of 1.75.

We chose this particular version, because:

a) it's > 1 year old
b) it provides a buffer on top of v1.71, i.e., if some crate bumped to a version > 1.71, there is a chance we don't immediately have to react again
c) it stabilized async fns in traits (see https://blog.rust-lang.org/2023/12/21/async-fn-rpit-in-traits.html), which might become handy for related (BDK) crates, which hopefully will adopt the same target.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.36%. Comparing base (f92c4dc) to head (b732e76).
Report is 4 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #3528 +/- ##
==========================================
- Coverage 88.36% 88.36% -0.01% 
==========================================
Files 149 149 Lines 112875 113053 +178 Branches 112875 113053 +178 ==========================================
+ Hits 99742 99899 +157 - Misses 10653 10672 +19 - Partials 2480 2482 +2 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[TheBlueMatt]

Grr, can you fix CI?

error: package home v0.5.11 cannot be built because it requires rustc 1.81 or newer, while the currently active rustc version is 1.63.0

[tnull]

Grr, can you fix CI?

error: package home v0.5.11 cannot be built because it requires rustc 1.81 or newer, while the currently active rustc version is 1.63.0

Jup, just pushed a fix.

[TheBlueMatt]

CI is still failing with error: package tinystr v0.7.6 cannot be built because it requires rustc 1.67 or newer, while the currently active rustc version is 1.63.0. I believe moving lightning-transaction-sync out of the workspace will fix it.

[tnull]

CI is still failing with error: package tinystr v0.7.6 cannot be built because it requires rustc 1.67 or newer, while the currently active rustc version is 1.63.0. I believe moving lightning-transaction-sync out of the workspace will fix it.

Ah, missed that it was explicitly added as a dependency to no-std-check. Dropping it from there should be sufficient.

[tnull]

Went ahead and squashed the fixups as my hope is up that this will finally pass, and I want to enable landing it whenever it does:

> git diff-tree -U2 a43805e85 b732e763b>

[TheBlueMatt]

I'd kinda prefer to remove it from the workspace as well so that cargo check passes on our MSRV. Is there a reason not to?

[tnull]

Is there a reason not to?

Well, essentially the same argument: I'd prefer to have it included in usual tests via cargo check -p ../cargo test -p ...

I'd kinda prefer to remove it from the workspace as well so that cargo check passes on our MSRV

Even without moving it out of the workspace, cargo check on MSRV works just fine for me (as any dependencies conflicting with the MSRV are hidden behind features anyways):

> rustup override set 1.63
info: override toolchain for 'rust-lightning' set to '1.63-aarch64-apple-darwin'
> cargo check
...
Checking lightning-transaction-sync v0.0.124 (rust-lightning/lightning-transaction-sync)
...
Finished dev [optimized + debuginfo] target(s) in 5.59s

In any case, now went ahead and included a fixup that moves it out as per your preference. Let me know if I should squash or drop it.

[tnull]

👀👀👀

[TheBlueMatt]

I'd prefer to leave it out of the workspace. At least personally I use the workspace on our MSRV all the time, and the ability to run cargo test --all-features without it vomiting would be nice.

[tnull]

I'd prefer to leave it out of the workspace. At least personally I use the workspace on our MSRV all the time, and the ability to run cargo test --all-features without it vomiting would be nice.

Alright, now squashed with the following additional changes (reverting the hunk mentioned above):

> git diff-tree -U2 7ee287bd0 cd5b4f763diff --git a/ci/ci-tests.sh b/ci/ci-tests.sh
index 393ce18f5..f4987569f 100755
--- a/ci/ci-tests.sh+++ b/ci/ci-tests.sh@@ -87,7 +87,5 @@ echo -e "\n\nTesting c_bindings builds"
# Note that because `$RUSTFLAGS` is not passed through to doctest builds we cannot selectively
# disable doctests in `c_bindings` so we skip doctests entirely here.
-for DIR in "${WORKSPACE_MEMBERS[@]}"; do- RUSTFLAGS="$RUSTFLAGS --cfg=c_bindings" cargo test -p "$DIR" --verbose --color always --lib --bins --tests-done+RUSTFLAGS="$RUSTFLAGS --cfg=c_bindings" cargo test --verbose --color always --lib --bins --tests
for DIR in lightning-invoice lightning-rapid-gossip-sync; do

[TheBlueMatt]

Just gonna land this. The changes are all straightforward moves/copies, and CI (finally) passes 🎉

[TheBlueMatt]

Backported in #3536.