Uh oh!
There was an error while loading. Please reload this page.
Add compliance context to transactions - #823
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
lightspark-bot
commented
Aug 12, 2026
✱ Stainless preview builds for gridThis PR will update the cli go kotlin openapi php python ruby typescript ✅ grid-rubystudio · code
|
Greptile SummaryRaise the compliance gates—let the transaction schemas thunder. This PR extends transaction metadata with optional pending-context and new compliance-rejection failure reasons.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| openapi/components/schemas/transactions/TransactionPendingReason.yaml | Adds the shared enum describing customer-action and compliance-review pending reasons. |
| openapi/components/schemas/transactions/Transaction.yaml | Adds the optional pendingReason property to the shared transaction schema. |
| openapi/components/schemas/transactions/IncomingTransactionFailureReason.yaml | Adds COMPLIANCE_REJECTED for incoming transactions. |
| openapi/components/schemas/transactions/OutgoingTransactionFailureReason.yaml | Adds COMPLIANCE_REJECTED for outgoing transactions. |
| openapi.yaml | Regenerates the bundled OpenAPI contract from the modular source. |
| mintlify/openapi.yaml | Synchronizes Mintlify’s generated OpenAPI bundle. |
Reviews (2): Last reviewed commit: "docs(openapi): clarify pending reason sc..." | Re-trigger Greptile
Uh oh!
There was an error while loading. Please reload this page.
@greptile review |
Co-Authored-By: jklein24 <jklein24@users.noreply.github.com>
0920c58 to
91de3c2CompareRebased onto current |
| - MISSING_MANDATORY_PAYEE_DATA | ||
| - QUOTE_EXPIRED | ||
| - QUOTE_EXECUTION_FAILED | ||
| - COMPLIANCE_REJECTED |
There was a problem hiding this comment.
i think jason just added this so might need a rebase, rest lgtm
There was a problem hiding this comment.
There was a problem hiding this comment.
Looks like he did for Outgoing, but this is Incoming.
There was a problem hiding this comment.
Correct — #689 owns the outgoing contract, while this PR still needs COMPLIANCE_REJECTED on incoming deposits. The rebased diff now reflects exactly that split.
There was a problem hiding this comment.
Rebased and resolved — the current diff now preserves #689’s complete outgoing contract and keeps only the incoming compliance rejection plus shared pending context from this PR.
Uh oh!
There was an error while loading. Please reload this page.
Upstream #823 added COMPLIANCE_REJECTED to IncomingTransactionFailureReason; this branch adds COLLECTION_FAILED. Both are additive enum members — the merged description explains each. Bundles regenerated via lint:openapi (0 errors). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DLYJSn6VRoZeLV15wcuZHy

Summary
pendingReasonfield to all transactions.COMPLIANCE_REJECTEDto incoming transaction failure reasons.Test plan
make buildmake lint-openapi(0 errors)Original PR: #822