Uh oh!
There was an error while loading. Please reload this page.
fix: correct regex syntax in governance hook for linked-issues detection - #1494
Conversation
Fixes critical regex bug in hooks/pr-merge-governance-validator.sh line 102. The hook used `\s+` (POSIX character class) which is NOT supported by grep -E (ERE regex). The correct syntax for ERE is `[[:space:]]+`. This bug prevented the governance hook from detecting linked issues (Fixes #XXX, Relates to #XXX) and incorrectly blocked valid PR merges. Impact: Governance validation now correctly detects issue references and allows valid PRs with linked issues to merge. Fixes#1489 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Warning Review limit reached
Next review available in:51 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏱️ Aging and SLA annotation
Maintained by project-meta-sync workflow. |
Tick the box to add this pull request to the merge queue (same as
|
Uh oh!
There was an error while loading. Please reload this page.
🔍 Reviewer Summary for PR #1494CI Status: ✅ Recommendations
|
Linked issues
Fixes#1489
Context
Reproduction
The governance validation hook fails to detect issue references:
Root Cause
Line 102 of
hooks/pr-merge-governance-validator.shuses\s+(POSIX character class) which is NOT supported bygrep -E(ERE regex). The correct ERE syntax is[[:space:]]+.Fix Summary
\s+with ERE-compatible[[:space:]]+in regex patternVerification
Changelog
Fixed
[[:space:]]+instead of unsupported\s+(Fixesfix: PR #1488 governance validation hook has regex bug + process workflow gaps #1489)Checklist (Global DoD / PR)