fix: correct regex syntax in governance hook for linked-issues detection by ashleyshaw · Pull Request #1490 · lightspeedwp/.github

ashleyshaw · 2026-08-04T12:32:39Z

Linked issues

Context

Severity/Impact: High (blocks valid PR merges)
Affected versions/environments: develop branch

Reproduction

The governance hook fails to detect issue references like "Fixesfix: PR #1488 governance validation hook has regex bug + process workflow gaps #1489"
Valid PRs with linked issues are incorrectly blocked
Expected: Hook validates issue references correctly
Actual: Regex syntax error prevents validation

Root Cause

Line 102 of hooks/pr-merge-governance-validator.sh uses \s+ (POSIX character class) which is NOT supported by grep -E (ERE regex). Correct syntax is [[:space:]]+ for space/tab/newline matching in ERE.

Fix Summary

Replace unsupported \s+ with ERE-compatible [[:space:]]+ in regex pattern
Enables proper detection of "Fixes #XXX", "Relates to #XXX", "Closes #XXX" patterns in PR bodies
Validates locally: echo "Fixes #1376" | grep -qiE "(fixes|resolves|closes|relates to)[[:space:]]+#[0-9]+" && echo "PASS" || echo "FAIL"

Verification

Regex fix verified locally with multiple test cases
Hook logic remains unchanged (only regex syntax fixed)
No impact on other validation rules

Risk & Rollback

Risk level: Low (isolated regex syntax fix in validation hook)
Rollback plan: Revert commit if needed

Changelog

Fixed

Fixed regex syntax in PR merge governance hook to use ERE-compatible [[:space:]]+ instead of unsupported \s+ (Fixesfix: PR #1488 governance validation hook has regex bug + process workflow gaps #1489)

Added

Changed

Removed

Checklist (Global DoD / PR)

…p for debugging

…og output

…ithub-script logging

…on issue

…ogging and proper error handling

… avoid script syntax breaking

…b-script complexity

…ging

…lestone assignment

…bles to avoid special character issues

…ad of inline

…simpler and more reliable

…y-run 15)

…p (dry-run 16)

…tput (dry-run 17)

…tion (test from develop)

…tone assignment

…ailure

…ests, 100% coverage of 6 assignment rules)

Add portable governance guardrail to block PR merges that violate: 1. PR template requirements (based on branch prefix per AGENTS.md) 2. Linked issue requirement (Fixes #XXX or Relates to #XXX) Hook runs before gh pr merge succeeds, providing clear error messages with actionable fixes. Prevents repeated governance violations that were costing tokens and undermining issue tracking. References: - AGENTS.md: PR template routing by branch prefix - CLAUDE.md: Repository structure and governance rules - docs/BRANCHING_STRATEGY.md: Branch naming discipline Hook location: hooks/pr-merge-governance-validator.sh (portable asset) Configuration: .claude/settings.json PreToolUse hook on Bash(gh pr merge *) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

Merges latest develop changes while preserving feature branch commits. Resolves conflicts by taking feature branch version of workflow file (feat branch has the final correct Node.js script solution). Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

Replace semicolon-separated shell commands with pipe-delimited multiline syntax to avoid YAML parser errors. Preserves set +e behavior for error handling in milestone assignment step. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

Replace unsupported \s+ (POSIX character class) with [[:space:]]+ (ERE-compatible) in grep -qiE pattern. Previous syntax would fail to detect 'Fixes#123' patterns and incorrectly block valid PR merges. Fixes issue #1489 (code review finding from PR #1488). Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

coderabbitai · 2026-08-04T12:32:52Z

Warning

Review limit reached

@ashleyshaw, you've reached your PR review limit, so we couldn't start this review.

Next review available in:2 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 1ec5117b-5e6c-4458-a9a0-fe8ee1b50daf

📥 Commits

Reviewing files that changed from the base of the PR and between c27fa3b and f25dba4.

📒 Files selected for processing (3)

.github/workflows/gitleaks-update.yml
CHANGELOG.md
hooks/pr-merge-governance-validator.sh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-08-04T12:32:53Z

✅ Template check passed after update. Thanks for fixing the PR description.

…ompt Add CONTINUATION_PROMPT_2026-08-04.md documenting: - Critical regex bug fix (PR #1490) - Governance process violations in #1489 - Pre-commit validation hook implementation plan - Root cause analysis and long-term improvements Update README with Phase 2 AI governance process work. Related to issue #1489, PR #1490. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

Keep fix branch version with [[:space:]]+ (ERE-compatible). Develop still has old \s+ syntax. Fix takes precedence. Resolves merge conflict in PR #1490. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

github-actions · 2026-08-04T13:43:07Z

🔍 Reviewer Summary for PR #1490

CI Status: ❌ success
Files changed: 3
Risk Distribution: 1 critical, 0 high, 0 medium, 2 low

Recommendations

⚠️ 1 critical-risk file(s) modified (workflows, secrets)
⚠️ Security-sensitive files modified (review carefully)

github-actions · 2026-08-04T13:51:22Z

⏱️ Aging and SLA annotation

Age: 0 day(s)
SLA state: Within SLA
Thresholds: warn at 7 days, breach at 14 days
Last updated: 2026-08-04T13:56:21.154Z

Maintained by project-meta-sync workflow.

mergify · 2026-08-04T13:51:39Z

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

Queue this pull request

ashleyshaw · 2026-08-04T13:53:20Z

@Mergifyio queue

mergify · 2026-08-04T13:53:45Z

queue

⚠️ Configuration not compatible with a branch protection setting

Details

The branch protection setting Require branches to be up to date before merging is not compatible with draft PR checks. To keep this branch protection enabled, update your Mergify configuration to enable in-place checks: set merge_queue.max_parallel_checks: 1, set every queue rule batch_size: 1, and avoid two-step CI (make merge_conditions identical to queue_conditions). Otherwise, disable this branch protection.

Copilot

🟡 Not ready to approve

The linked-issues regex can still yield false positives by matching keywords inside longer words, weakening the governance check.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Pull request overview

This PR restores linked-issue detection in the PR merge governance hook by replacing a grep -E-incompatible regex escape with an ERE-compatible whitespace class, unblocking valid merges on develop.

Changes:

Fix linked-issues grep -E pattern by switching from \s+ to [[:space:]]+.
Minor Markdown whitespace tweak in CHANGELOG.md.
Normalise YAML quoting for the scheduled cron expression in gitleaks-update.yml.

File summaries

File	Description
hooks/pr-merge-governance-validator.sh	Updates the linked-issues detection regex to be compatible with `grep -E`.
CHANGELOG.md	Adjusts spacing around the Unreleased sections.
.github/workflows/gitleaks-update.yml	Normalises cron quoting style in the workflow schedule.

Review details

Files reviewed: 3/3 changed files
Comments generated: 1
Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

 has_linked_issues=false

-if echo "$pr_body" | grep -qiE "(fixes|resolves|closes|relates to)\s+#[0-9]+"; then
+if echo "$pr_body" | grep -qiE "(fixes|resolves|closes|relates to)[[:space:]]+#[0-9]+"; then


Add word boundary check by requiring keywords to be preceded by either start-of-line or whitespace. This prevents matching keywords inside longer words (e.g., 'prefixes #123' no longer matches 'fixes'). Maintains support for case-insensitive matching and flexible whitespace in 'relates to' pattern. Fixes Copilot review feedback on PR #1490. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

ashleyshaw

Fixed: Improved regex to require keywords at start-of-line or after whitespace to prevent false positives like 'prefixes #123' matching 'fixes'. Pattern now: (^|[[:space:]])(fixes|resolves|closes|relates[[:space:]]+to)[[:space:]]+#[0-9]+. Verified against test cases (6 positive, 6 negative).

🤖 Addressed by Claude Code

ashleyshaw · 2026-08-04T14:07:17Z

@copilot-pull-request-reviewer review

ashleyshaw · 2026-08-04T14:24:46Z

Work continued in clean PRs #1494 (regex fix) and #1495 (ESLint config). Closing in favor of those streamlined PRs.

What was done in #1490:

Regex fix: \s+ → [[:space:]]+ (in merged PR fix: correct regex syntax in governance hook for linked-issues detection #1494)
Template updates (can be reused as reference)

Why moving to clean PRs:

PR fix: correct regex syntax in governance hook for linked-issues detection #1490 had merge artifacts from multiple commits and conflicts
Fresh PRs provide cleaner commit history
Easier to review and merge independently

Related: #1489 (governance validation improvements)

ashleyshawand others added 26 commits August 4, 2026 12:32

fix(workflows): add better error handling to milestone assignment ste…
65a782b
…p for debugging

fix(workflows): improve milestone assignment debugging with console.l…
36618f5
…og output

fix(workflows): use core.info() instead of console.log() for proper g…
2bee0ee
…ithub-script logging

test(workflows): simplify to one-liner test to isolate script executi…
11ede40
…on issue

fix(workflows): restore full milestone assignment with step-by-step l…
acda60b
…ogging and proper error handling

fix(workflows): use env variables instead of template substitution to…
7832b84
… avoid script syntax breaking

refactor(workflows): move to standalone Node.js script to avoid githu…
7848b5b
…b-script complexity

fix(scripts): use process.cwd() for absolute paths and add better log…
89774c2
…ging

debug(workflows): add explicit path checking and error capture for mi…
90df5e3
…lestone assignment

refactor(workflows): use file-based JSON passing instead of env varia…
5f0be82
…bles to avoid special character issues

fix(workflows): correct env variable syntax - move to env block inste…
dca9da0
…ad of inline

refactor(workflows): switch to GitHub CLI for milestone assignment - …
ab2c43c
…simpler and more reliable

chore: add diagnostic debugging to Assign milestones step (dry-run 14)
e6a2576

fix: restore milestone assignment agent with env variable passing (dr…
38f1e97
…y-run 15)

chore: add granular console.log debugging to milestone assignment ste…
b458a65
…p (dry-run 16)

fix: use core.info/core.error instead of console for github-script ou…
1e48fe1
…tput (dry-run 17)

fix: simplify if condition and add env fetch diagnostics (dry-run 18)
c5c514b

test: minimal github-script test to confirm output capture (dry-run 19)
66d80ac

fix: restore full milestone assignment with simpler template substitu…
387d8a6
…tion (test from develop)

fix: use standalone Node.js script instead of github-script for miles…
b637798
…tone assignment

fix: disable bash -e flag and add exit code logging to debug script f…
3d668d3
…ailure

test: add comprehensive unit tests for MilestoneAssignmentAgent (28 t…
35d8c92
…ests, 100% coverage of 6 assignment rules)

ashleyshaw mentioned this pull request Aug 4, 2026
fix: PR #1488 governance validation hook has regex bug + process workflow gaps #1489
Open
30 tasks

ashleyshaw added the area:governance label Aug 4, 2026

Merge develop: resolve regex conflict in governance hook
886c86f
Keep fix branch version with [[:space:]]+ (ERE-compatible). Develop still has old \s+ syntax. Fix takes precedence. Resolves merge conflict in PR #1490. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

ashleyshaw enabled auto-merge (squash) August 4, 2026 13:42

github-actionsBot removed the priority:normal Default priority label Aug 4, 2026

github-actionsBot added the priority:normal Default priority label Aug 4, 2026

ashleyshaw requested a lite review from Copilot August 4, 2026 14:02

Copilotstarted reviewing on behalf of ashleyshaw August 4, 2026 14:03 View session

CopilotAI reviewed Aug 4, 2026
View reviewed changes

ashleyshaw commented Aug 4, 2026
View reviewed changes

github-actionsBot removed the priority:normal Default priority label Aug 4, 2026

Copilotstarted work on behalf of ashleyshaw August 4, 2026 14:08 View session

Copilotfinished work on behalf of ashleyshaw August 4, 2026 14:09

ashleyshaw closed this Aug 4, 2026

auto-merge was automatically disabled August 4, 2026 14:24
Pull request was closed

Navigation Menu

Uh oh!

fix: correct regex syntax in governance hook for linked-issues detection - #1490

fix: correct regex syntax in governance hook for linked-issues detection#1490
ashleyshaw wants to merge 28 commits into
developfrom
fix/governance-hook-regex-bug

ashleyshaw commented Aug 4, 2026•
edited
Loading

Uh oh!

coderabbitaiBot commented Aug 4, 2026•
edited
Loading

Review limit reached

Uh oh!

github-actionsBot commented Aug 4, 2026•
edited
Loading

Uh oh!

github-actionsBot commented Aug 4, 2026

Uh oh!

github-actionsBot commented Aug 4, 2026•
edited
Loading

Uh oh!

mergifyBot commented Aug 4, 2026

Uh oh!

ashleyshaw commented Aug 4, 2026

Uh oh!

mergifyBot commented Aug 4, 2026

Uh oh!

CopilotAI left a comment

Uh oh!

ashleyshaw left a comment

Uh oh!

ashleyshaw commented Aug 4, 2026

Uh oh!

ashleyshaw commented Aug 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

ashleyshaw commented Aug 4, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Linked issues

Context

Reproduction

Root Cause

Fix Summary

Verification

Risk & Rollback

Changelog

Fixed

Added

Changed

Removed

Checklist (Global DoD / PR)

Uh oh!

coderabbitaiBot commented Aug 4, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

github-actionsBot commented Aug 4, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Aug 4, 2026

🔍 Reviewer Summary for PR #1490

Recommendations

Uh oh!

github-actionsBot commented Aug 4, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⏱️ Aging and SLA annotation

Uh oh!

mergifyBot commented Aug 4, 2026

Uh oh!

ashleyshaw commented Aug 4, 2026

Uh oh!

mergifyBot commented Aug 4, 2026

⚠️ Configuration not compatible with a branch protection setting

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

🟡 Not ready to approve

Uh oh!

ashleyshaw left a comment

Choose a reason for hiding this comment

Uh oh!

ashleyshaw commented Aug 4, 2026

Uh oh!

ashleyshaw commented Aug 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ashleyshaw commented Aug 4, 2026•
edited
Loading

coderabbitaiBot commented Aug 4, 2026•
edited
Loading

github-actionsBot commented Aug 4, 2026•
edited
Loading

github-actionsBot commented Aug 4, 2026•
edited
Loading