Skip to content

chore: exclude shell scripts from ESLint linting - #1495

Merged
ashleyshaw merged 1 commit into
developfrom
chore/exclude-shells-scripts-from-eslint
Aug 4, 2026
Merged

chore: exclude shell scripts from ESLint linting#1495
ashleyshaw merged 1 commit into
developfrom
chore/exclude-shells-scripts-from-eslint

Conversation

@ashleyshaw

@ashleyshawashleyshaw commented Aug 4, 2026

Copy link
Copy Markdown
Member

Linked issues

Relates to #1489

Context

Shell scripts in the hooks/ directory are not JavaScript and should not be linted by ESLint. This prevents ESLint from attempting to process them and causing linting failures.

Changes

  • Add hooks/** to ESLint ignore patterns in eslint.config.cjs

Impact

  • Fixes linting failures on portable shell scripts (hooks/pr-checklist-validator.sh, hooks/pr-merge-governance-validator.sh, etc.)
  • Unblocks PRs that add or modify shell scripts in hooks/

Changelog

Changed

  • ESLint configuration now properly excludes shell scripts from linting

Checklist (Global DoD / PR)

  • All AC met and demonstrated
  • Tests added/updated (N/A - config change)
  • Docs updated (if user-facing)
  • Code quality verified
  • CI passing

@ashleyshaw@claude
chore: exclude shell scripts from ESLint linting
e028d13
Shell scripts in the hooks/ directory are not JavaScript and should not
be linted by ESLint. Add hooks/** to the ignore patterns so ESLint
doesn't attempt to process them.
This prevents linting failures on portable shell scripts like
hooks/pr-checklist-validator.sh and hooks/pr-merge-governance-validator.sh
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@coderabbitai

coderabbitaiBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@ashleyshaw, you've reached your PR review limit, so we couldn't start this review.

Next review available in:48 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 3268826f-4909-4435-9f99-3684a4eeabcc

📥 Commits

Reviewing files that changed from the base of the PR and between 300e500 and e028d13.

📒 Files selected for processing (1)
  • eslint.config.cjs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added the status:needs-review Awaiting code review label Aug 4, 2026
@ashleyshawashleyshaw added the meta:no-changelog No changelog needed label Aug 4, 2026
@github-actionsgithub-actionsBot added type:chore Chore / small hygiene change priority:normal Default priority meta:needs-changelog Requires a changelog entry before merge labels Aug 4, 2026
@ashleyshawashleyshaw mentioned this pull request Aug 4, 2026
Closed
13 tasks
@ashleyshawashleyshaw added this to the v1.0 milestone Aug 4, 2026
@github-actions

github-actionsBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

🔍 Reviewer Summary for PR #1495

CI Status: ✅ success
Files changed: 1
Risk Distribution: 0 critical, 0 high, 0 medium, 1 low

Recommendations

  • Ready to proceed pending human review

@github-actions

github-actionsBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

⏱️ Aging and SLA annotation

  • Age: 0 day(s)
  • SLA state: Within SLA
  • Thresholds: warn at 7 days, breach at 14 days
  • Last updated: 2026-08-04T14:25:06.252Z

Maintained by project-meta-sync workflow.

@ashleyshawashleyshaw mentioned this pull request Aug 4, 2026
Open
30 tasks
@mergify

mergifyBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@ashleyshaw
ashleyshaw merged commit 1aeac72 into developAug 4, 2026
21 of 24 checks passed
@ashleyshaw
ashleyshaw deleted the chore/exclude-shells-scripts-from-eslint branch August 4, 2026 14:25
@ashleyshawashleyshaw linked an issue Aug 4, 2026 that may be closed by this pull request
fix: PR #1488 governance validation hook has regex bug + process workflow gaps #1489
Open
30 tasks
@ashleyshawashleyshaw mentioned this pull request Aug 4, 2026
Closed
5 tasks
ashleyshaw added a commit that referenced this pull request Aug 4, 2026
@ashleyshaw@claude
docs: clarify optional/manual setup for pre-commit validation hook
1770530
Address Copilot review feedback:
- AGENTS.md line 278: Clarify UserPromptSubmit hook is optional, not automatic
- CONTRIBUTING.md lines 84 & 93: Emphasize hook requires manual configuration
- Remove duplicate eslint.config.cjs change (already merged in PR #1495)
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
ashleyshaw added a commit that referenced this pull request Aug 4, 2026
@ashleyshaw@claude
docs: clarify optional/manual setup for pre-commit validation hook
f2cfa5d
Address Copilot review feedback:
- AGENTS.md line 278: Clarify UserPromptSubmit hook is optional, not automatic
- CONTRIBUTING.md lines 84 & 93: Emphasize hook requires manual configuration
- Remove duplicate eslint.config.cjs change (already merged in PR #1495)
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

meta:needs-changelogRequires a changelog entry before mergemeta:no-changelogNo changelog neededpriority:normalDefault prioritystatus:needs-reviewAwaiting code reviewtype:choreChore / small hygiene change

Projects

None yet

Milestone

v1.0

Development

Successfully merging this pull request may close these issues.

fix: PR #1488 governance validation hook has regex bug + process workflow gaps

1 participant

@ashleyshaw