Skip to content

fix: Resolve infrastructure bugs #1928, #1930, #1938 - #2010

Closed
ashleyshaw wants to merge 1 commit into
developfrom
fix/infrastructure-bugs-1928-1930-1938
Closed

fix: Resolve infrastructure bugs #1928, #1930, #1938#2010
ashleyshaw wants to merge 1 commit into
developfrom
fix/infrastructure-bugs-1928-1930-1938

Conversation

@ashleyshaw

Copy link
Copy Markdown
Member

Summary

This PR resolves three critical infrastructure bugs affecting CI/CD validation and branch naming enforcement.

  • Fixes gitleaks false positive in OPENSPEC_TEMPLATE.md example code
  • Fixes PR template validator missing 'Global DoD Checklist' detection
  • Fixes branch name validator permitting invalid characters (uppercase, dots, underscores)

Linked issues

Fixes#1928
Fixes#1930
Fixes#1938

Changes

Bug #1928 - Gitleaks False Positive

  • Added gitleaks ignore comments around example curl command in OPENSPEC_TEMPLATE.md
  • Prevents security scanner from flagging valid example bearer tokens

Bug #1930 - PR Template Validator

  • Fixed regex in sectionBody() to match all heading levels (###) not just ##
  • Pattern changed from /^##\s+.+$/m to /^#+\s+.+$/m
  • Now correctly detects 'Changelog' and 'Global DoD Checklist' sections

Bug #1938 - Branch Name Validator

  • Enforced strict kebab-case validation (lowercase, hyphens only)
  • Changed regex from [a-zA-Z0-9._-]+ to [a-z0-9-]+
  • Updated test cases to reflect proper validation rules
  • Complies with CLAUDE.md requirement for lowercase, kebab-case branch names

Test Plan

  • All existing tests pass with updated branch validation rules
  • PR template validator correctly detects all required sections
  • Gitleaks ignores example code in OPENSPEC_TEMPLATE.md
  • Branch validation rejects uppercase letters, dots, and underscores

Changelog

  • Fixed gitleaks false positive in OPENSPEC_TEMPLATE.md
  • Fixed PR template validator false negatives on required sections
  • Fixed branch name validator to enforce strict kebab-case

Checklist (Global DoD / PR)

  • All AC met and demonstrated
  • Tests added/updated (unit/E2E as appropriate)
  • Code/design reviews approved
  • CI green; linked issues closed

🤖 Generated with Claude Code

**#1928 - Gitleaks false positive in OPENSPEC_TEMPLATE.md**
- Added gitleaks ignore comments around example curl command
- Prevents security scanner from flagging valid example bearer tokens
**#1930 - PR template validator false negatives**
- Fixed regex in sectionBody() to match any heading level (#, ##, ###)
- Changed pattern from /^##\s+.+$/m to /^#+\s+.+$/m
- Now correctly detects 'Changelog' and 'Global DoD Checklist' sections
**#1938 - Branch name validator false negative**
- Enforced strict kebab-case (lowercase, hyphens only)
- Changed regex from [a-zA-Z0-9._-]+ to [a-z0-9-]+
- Updated tests to reject uppercase letters, dots, and underscores
- Complies with CLAUDE.md requirement for lowercase, kebab-case branch names
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added status:needs-review Awaiting code review type:bug Bug or defect priority:normal Default priority type:chore Chore / small hygiene change meta:needs-changelog Requires a changelog entry before merge labels Aug 18, 2026
ashleyshaw pushed a commit that referenced this pull request Aug 21, 2026
…-08-21)
Issue status review documenting:
- Closed#1930: PR template validator false negative (via #2007, #2010)
- Closed#2051: Frontmatter freshness CI issues (via #2180)
- Enhanced #2186: Template validation script false positives with DoR/DoD
- Enhanced #2147: Phase 1 validation tests with progress tracking
- Verified #2049: OpenSpec Labels Phase 2-3 epic (complete)
All high-priority issues now have complete Definition of Ready and Definition
of Done sections reflecting merged work into develop branch.
References: #2186, #1930, #2051, #2147, #2049
Related PRs: #2193, #2180, #2183, #2173, #2153, #2210, #2221
mergifyBot added a commit that referenced this pull request Aug 21, 2026
* docs: Issue status review — DoR/DoD completion audit (2026-08-21)
- Closed#1930: PR template validator false negative (merged via #2007, #2010)
- Closed#2051: Frontmatter freshness CI issues (merged via #2180)
- Updated #2186: Template validation script false positives with DoR/DoD
- Updated #2147: Phase 1 validation tests progress tracking with DoR/DoD framework
- Verified #2049: OpenSpec Labels Phase 2-3 epic (complete, merged)
All high-priority issues now have complete Definition of Ready and Definition of Done sections reflecting merged work into develop branch.
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018MoY39EXD6tnbbjs3JVUqT
* revert: remove misplaced issue status review from root
---------
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta:needs-changelogRequires a changelog entry before mergepriority:normalDefault prioritystatus:needs-reviewAwaiting code reviewtype:bugBug or defecttype:choreChore / small hygiene change

Projects

None yet

1 participant

@ashleyshaw