Uh oh!
There was an error while loading. Please reload this page.
fix: Restore frontmatter validator CLI flag parsing - #2193
Merged
Conversation
The validate-frontmatter-changed script was using positional arguments (process.argv[2], process.argv[3]) instead of properly parsing --base and --head flags passed by the CI workflow. This caused the validator to fail when the workflow called: npm run validate:frontmatter:changed -- --base <sha> --head <sha> Restored the minimist-based flag parsing that correctly interprets --base and --head arguments, allowing the frontmatter validation to work properly in CI pipelines. Fixes remaining validator issue from #1966. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QC3sD7K5tPp6oyffUkiTsR
Added proper blank lines around: - Headings (MD022) - Lists (MD032) - Code fences (MD031) - Removed trailing spaces (MD009) Fixed in: - .github/agentic-workflows/README.md - .github/agents/release.agent.md - .github/instructions/README.md - .github/metrics/README.md Addresses issue #1961 - CI markdown linting job failures. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QC3sD7K5tPp6oyffUkiTsR
…009) - Added blank lines after headings (MD022) - Added blank lines around lists (MD032) - Added blank lines around code fences (MD031) - Removed trailing spaces (MD009) - Fixed 5 files with 300+ linting errors: - PHASE_4_FAQ.md: 118 errors - PHASE_4_TROUBLESHOOTING.md: 60 errors - zendesk-support-agent/README.md: 69 errors - AGENTIC_RELEASE_TEAM_TRAINING.md: 42 errors - chat-closure-agent/troubleshooting-faq.md: 57 errors Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QC3sD7K5tPp6oyffUkiTsR
Contributor
Warning Review limit reached
Next review available in:41 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (87)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
✅ Template check passed after update. Thanks for fixing the PR description. |
- Fixed typo: .githu./.github/reports/** → .github/reports/** - Ensures .github/reports/ is properly excluded from markdown linting rules Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QC3sD7K5tPp6oyffUkiTsR
Contributor
🔗 Project Linking ValidationProjects Checked: 67 ✅ All projects have Related Issues sectionsDetailed issue link validation is deferred to Phase 4. Validation Date: 2026-08-20T18:31:36.737Z |
Contributor
🔍 Reviewer Summary for PR #2193CI Status: ❌ Recommendations
|
Contributor
⏱️ Aging and SLA annotation
Maintained by project-meta-sync workflow. |
Contributor
🔗 Project Linking ValidationProjects Checked: 67 ✅ All projects have Related Issues sectionsDetailed issue link validation is deferred to Phase 4. Validation Date: 2026-08-20T18:32:41.855Z |
Contributor
🎨 Mermaid Diagram Validation❌ One or more Mermaid diagram checks failed.
|
- Updated lint-md-changed.cjs to filter changed files against .markdownlintignore patterns before linting - Prevents CI failures from markdown formatting issues in excluded report and project files - Fixed 77 instances of typo .githu./ → .github/ across documentation and config files This ensures that: 1. Files in .github/reports/** are excluded from linting (generated reports, audits) 2. Files in .github/projects/** are excluded from linting (project artifacts) 3. The lint-md-changed script respects ignore patterns before passing files to markdownlint-cli2 4. CI markdown validation only checks relevant source files, not generated content Fixes: #1961, #1966 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QC3sD7K5tPp6oyffUkiTsR
…cript - Replaced minimatch import with built-in glob pattern matching - Uses simple regex-based pattern matching for .markdownlintignore patterns - Reduces external dependencies while maintaining compatibility with glob syntax - Properly handles **, *, and ? wildcards in ignore patterns Fixes lint-md-changed.cjs to correctly filter changed files before passing to markdownlint-cli2. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QC3sD7K5tPp6oyffUkiTsR
ashleyshaw
enabled auto-merge
August 20, 2026 18:42
- Fixed pattern matching to correctly handle **/ prefix patterns - **/ now properly makes the intermediate path optional (matches 0+ directories) - All glob patterns (.md files under .github/reports/**, .github/projects/**/*.md, etc.) now work correctly Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QC3sD7K5tPp6oyffUkiTsR
- Fixed duplicate path in checks.yml: .github//.github/reports/** → .github/reports/** - Ensures workflow correctly ignores report files from CI triggers Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QC3sD7K5tPp6oyffUkiTsR
Uh oh!
There was an error while loading. Please reload this page.
Contributor
🔗 Project Linking ValidationProjects Checked: 67 ✅ All projects have Related Issues sectionsDetailed issue link validation is deferred to Phase 4. Validation Date: 2026-08-20T18:47:45.334Z |
Contributor
Milestone Allocation |
This was referenced Aug 20, 2026
ashleyshaw pushed a commit
that referenced
this pull request
Aug 21, 2026
…-08-21) Issue status review documenting: - Closed#1930: PR template validator false negative (via #2007, #2010) - Closed#2051: Frontmatter freshness CI issues (via #2180) - Enhanced #2186: Template validation script false positives with DoR/DoD - Enhanced #2147: Phase 1 validation tests with progress tracking - Verified #2049: OpenSpec Labels Phase 2-3 epic (complete) All high-priority issues now have complete Definition of Ready and Definition of Done sections reflecting merged work into develop branch. References: #2186, #1930, #2051, #2147, #2049 Related PRs: #2193, #2180, #2183, #2173, #2153, #2210, #2221
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issues
Fixes#1961
Fixes#1966
Context
The
validate-frontmatter-changed.jsscript was using positional arguments instead of parsing CLI flags properly, causing all frontmatter validation checks to fail in CI.Fix Summary
Restored minimist-based CLI flag parsing to properly interpret
--baseand--headflags from the CI workflow.Test Plan
npm run validate:frontmatter:changed -- --base HEAD~5 --head HEADpassesChangelog
--baseand--headargumentsChecklist (Global DoD / PR)