fix(deps): bump protocol for the merged simulation overall_score - #976
Merged
Merged
Conversation
theomonnom
approved these changes
Sep 15, 2026
SimulationRun.JobMetrics and RunMetrics now carry overall_score in place of accuracy_score and experience_score (livekit/protocol#1800, merged as 3c0fcdbd). The CLI marshals the whole message for --json output, so the field follows the protocol with no code change. Also drop the stale commented-out local protocol replace directive.
u9g
force-pushed
the
jason/overall-score
branch
from
September 15, 2026 18:27
444bae1 to
18bc0db
Compare
u9g
marked this pull request as ready for review
September 15, 2026 18:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up livekit/protocol#1800, which replaces
accuracy_scoreandexperience_scoreonSimulationRun.JobMetricsandRunMetricswith a singleoverall_score. The CLI never reads those fields by name:lk agent simulate --jsonmarshals the whole run message, so its output drops the two old keys and gainsoverallScoreonce the worker ships (https://github.com/livekit/agents-private/pull/456). No code change.The generated OpenAPI client in
pkg/public/oapi/oapi.gen.gostill names the old fields; it regenerates from the deployed API spec, so that is a follow-up once the API is live.The pin now points at the merged protocol commit livekit/protocol@3c0fcdb (
v1.51.1-0.20260915182407-3c0fcdbd25df).