agent simulation: merge accuracy_score and experience_score into overall_score - #1800
Merged
Merged
Conversation
…all_score Both composites were weighted means over disjoint member sets with no consumer comparing one against the other. One weighted mean over the union of members replaces them on JobMetrics and RunMetrics; the old field numbers and names are reserved.
🦋 Changeset detectedLatest commit: b53f1d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
theomonnom
approved these changes
Sep 15, 2026
u9g
added a commit
to livekit/livekit-cli
that referenced
this pull request
Sep 15, 2026
SimulationRun.JobMetrics and RunMetrics now carry overall_score in place of accuracy_score and experience_score (livekit/protocol#1800, merged as 3c0fcdbd). The CLI marshals the whole message for --json output, so the field follows the protocol with no code change. Also drop the stale commented-out local protocol replace directive.
This was referenced Sep 15, 2026
u9g
added a commit
to livekit/livekit-cli
that referenced
this pull request
Sep 16, 2026
SimulationRun.JobMetrics and RunMetrics now carry overall_score in place of accuracy_score and experience_score (livekit/protocol#1800, merged as 3c0fcdbd). The CLI marshals the whole message for --json output, so the field follows the protocol with no code change. Also drop the stale commented-out local protocol replace directive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both headline composites were weighted means over disjoint member sets, and nothing compared one against the other, so
SimulationRun.JobMetricsandSimulationRun.RunMetricsnow carry a singleoverall_scorein place ofaccuracy_scoreandexperience_score. The old field numbers and names are reserved.Producer: livekit/agents-private (follow-up PR). Consumers: livekit/web, livekit/livekit-cli (follow-up PRs). Runs stored before the producer ships will read as not scored for the headline; their member metrics are unaffected.