[FIX] Undefined behaviour on comparison of NaN and float at particlemgr.cpp

[celisej567]

At particlemgr.cpp in class CParticleEffectBinding there is a variable named float m_flParticleCullRadius that (as i think valve expected to happen) are 0.0f -ed in constructor by calling SetParticleCullRadius(0.0f), but looks like they didnt know that if ( m_flParticleCullRadius != flMaxParticleRadius ) that happens in SetParticleCullRadius working with float NaN, which is Undefined Behaviour, and results of this thing are declared by individual compilers realization.

As the result of the problem some particles like explosions, sparks, smoke and dust may not appear at all. There even where no drawcall at this conditions.

Its not a problem when you use same compiler version, on same system version, on same computer configuration. But it is if its a multiplatform open-source project.

Hopefully it can be fixed easely, by manually 0.0f -ing m_flParticleCullRadius in constructor.

[celisej567]

In fact you can manually execute this by doing m_flParticleCullRadius = nanf(""); instead of m_flParticleCullRadius = 0.0f;

how you can see in this example video there is no sparks from metal, no explosions and no dust from the wall.

[celisej567]

also ubuntu build script is broken i think, he cant copy any .so file that he makes

[Blixibon]

This line is still missing a semicolon

[celisej567]

look at second commit

[celisej567]

At particlemgr.cpp in class CParticleEffectBinding there is a variable named float m_flParticleCullRadius that (as i think valve expected to happen) are 0.0f -ed in constructor by calling SetParticleCullRadius(0.0f), but looks like they didnt know that if ( m_flParticleCullRadius != flMaxParticleRadius ) that happens in SetParticleCullRadius working with float NaN, which is Undefined Behaviour, and results of this thing are declared by individual compilers realization.

As the result of the problem some particles like explosions, sparks, smoke and dust may not appear at all. There even where no drawcall at this conditions.

Its not a problem when you use same compiler version, on same system version, on same computer configuration. But it is if its a multiplatform open-source project.

Hopefully it can be fixed easely, by manually 0.0f -ing m_flParticleCullRadius in constructor.

[celisej567]

In fact you can manually execute this by doing m_flParticleCullRadius = nanf(""); instead of m_flParticleCullRadius = 0.0f;

how you can see in this example video there is no sparks from metal, no explosions and no dust from the wall.

[celisej567]

also ubuntu build script is broken i think, he cant copy any .so file that he makes

[Blixibon]

This line is still missing a semicolon

[celisej567]

look at second commit

[celisej567]

At particlemgr.cpp in class CParticleEffectBinding there is a variable named float m_flParticleCullRadius that (as i think valve expected to happen) are 0.0f -ed in constructor by calling SetParticleCullRadius(0.0f), but looks like they didnt know that if ( m_flParticleCullRadius != flMaxParticleRadius ) that happens in SetParticleCullRadius working with float NaN, which is Undefined Behaviour, and results of this thing are declared by individual compilers realization.

As the result of the problem some particles like explosions, sparks, smoke and dust may not appear at all. There even where no drawcall at this conditions.

Its not a problem when you use same compiler version, on same system version, on same computer configuration. But it is if its a multiplatform open-source project.

Hopefully it can be fixed easely, by manually 0.0f -ing m_flParticleCullRadius in constructor.

[celisej567]

In fact you can manually execute this by doing m_flParticleCullRadius = nanf(""); instead of m_flParticleCullRadius = 0.0f;

how you can see in this example video there is no sparks from metal, no explosions and no dust from the wall.

[celisej567]

also ubuntu build script is broken i think, he cant copy any .so file that he makes

[Blixibon]

This line is still missing a semicolon

[celisej567]

look at second commit

[celisej567]

At particlemgr.cpp in class CParticleEffectBinding there is a variable named float m_flParticleCullRadius that (as i think valve expected to happen) are 0.0f -ed in constructor by calling SetParticleCullRadius(0.0f), but looks like they didnt know that if ( m_flParticleCullRadius != flMaxParticleRadius ) that happens in SetParticleCullRadius working with float NaN, which is Undefined Behaviour, and results of this thing are declared by individual compilers realization.

As the result of the problem some particles like explosions, sparks, smoke and dust may not appear at all. There even where no drawcall at this conditions.

Its not a problem when you use same compiler version, on same system version, on same computer configuration. But it is if its a multiplatform open-source project.

Hopefully it can be fixed easely, by manually 0.0f -ing m_flParticleCullRadius in constructor.

[celisej567]

In fact you can manually execute this by doing m_flParticleCullRadius = nanf(""); instead of m_flParticleCullRadius = 0.0f;

how you can see in this example video there is no sparks from metal, no explosions and no dust from the wall.

[celisej567]

also ubuntu build script is broken i think, he cant copy any .so file that he makes

[Blixibon]

This line is still missing a semicolon

[celisej567]

look at second commit

[celisej567]

At particlemgr.cpp in class CParticleEffectBinding there is a variable named float m_flParticleCullRadius that (as i think valve expected to happen) are 0.0f -ed in constructor by calling SetParticleCullRadius(0.0f), but looks like they didnt know that if ( m_flParticleCullRadius != flMaxParticleRadius ) that happens in SetParticleCullRadius working with float NaN, which is Undefined Behaviour, and results of this thing are declared by individual compilers realization.

As the result of the problem some particles like explosions, sparks, smoke and dust may not appear at all. There even where no drawcall at this conditions.

Its not a problem when you use same compiler version, on same system version, on same computer configuration. But it is if its a multiplatform open-source project.

Hopefully it can be fixed easely, by manually 0.0f -ing m_flParticleCullRadius in constructor.

[celisej567]

In fact you can manually execute this by doing m_flParticleCullRadius = nanf(""); instead of m_flParticleCullRadius = 0.0f;

how you can see in this example video there is no sparks from metal, no explosions and no dust from the wall.

[celisej567]

also ubuntu build script is broken i think, he cant copy any .so file that he makes

[Blixibon]

This line is still missing a semicolon

[celisej567]

look at second commit

[celisej567]

At particlemgr.cpp in class CParticleEffectBinding there is a variable named float m_flParticleCullRadius that (as i think valve expected to happen) are 0.0f -ed in constructor by calling SetParticleCullRadius(0.0f), but looks like they didnt know that if ( m_flParticleCullRadius != flMaxParticleRadius ) that happens in SetParticleCullRadius working with float NaN, which is Undefined Behaviour, and results of this thing are declared by individual compilers realization.

As the result of the problem some particles like explosions, sparks, smoke and dust may not appear at all. There even where no drawcall at this conditions.

Its not a problem when you use same compiler version, on same system version, on same computer configuration. But it is if its a multiplatform open-source project.

Hopefully it can be fixed easely, by manually 0.0f -ing m_flParticleCullRadius in constructor.

[celisej567]

In fact you can manually execute this by doing m_flParticleCullRadius = nanf(""); instead of m_flParticleCullRadius = 0.0f;

how you can see in this example video there is no sparks from metal, no explosions and no dust from the wall.

[celisej567]

also ubuntu build script is broken i think, he cant copy any .so file that he makes

[Blixibon]

This line is still missing a semicolon

[celisej567]

look at second commit

[celisej567]

At particlemgr.cpp in class CParticleEffectBinding there is a variable named float m_flParticleCullRadius that (as i think valve expected to happen) are 0.0f -ed in constructor by calling SetParticleCullRadius(0.0f), but looks like they didnt know that if ( m_flParticleCullRadius != flMaxParticleRadius ) that happens in SetParticleCullRadius working with float NaN, which is Undefined Behaviour, and results of this thing are declared by individual compilers realization.

As the result of the problem some particles like explosions, sparks, smoke and dust may not appear at all. There even where no drawcall at this conditions.

Its not a problem when you use same compiler version, on same system version, on same computer configuration. But it is if its a multiplatform open-source project.

Hopefully it can be fixed easely, by manually 0.0f -ing m_flParticleCullRadius in constructor.

[celisej567]

In fact you can manually execute this by doing m_flParticleCullRadius = nanf(""); instead of m_flParticleCullRadius = 0.0f;

how you can see in this example video there is no sparks from metal, no explosions and no dust from the wall.

[celisej567]

also ubuntu build script is broken i think, he cant copy any .so file that he makes

[Blixibon]

This line is still missing a semicolon

[celisej567]

look at second commit

[celisej567]

At particlemgr.cpp in class CParticleEffectBinding there is a variable named float m_flParticleCullRadius that (as i think valve expected to happen) are 0.0f -ed in constructor by calling SetParticleCullRadius(0.0f), but looks like they didnt know that if ( m_flParticleCullRadius != flMaxParticleRadius ) that happens in SetParticleCullRadius working with float NaN, which is Undefined Behaviour, and results of this thing are declared by individual compilers realization.

As the result of the problem some particles like explosions, sparks, smoke and dust may not appear at all. There even where no drawcall at this conditions.

Its not a problem when you use same compiler version, on same system version, on same computer configuration. But it is if its a multiplatform open-source project.

Hopefully it can be fixed easely, by manually 0.0f -ing m_flParticleCullRadius in constructor.

[celisej567]

In fact you can manually execute this by doing m_flParticleCullRadius = nanf(""); instead of m_flParticleCullRadius = 0.0f;

how you can see in this example video there is no sparks from metal, no explosions and no dust from the wall.

[celisej567]

also ubuntu build script is broken i think, he cant copy any .so file that he makes

[Blixibon]

This line is still missing a semicolon

[celisej567]

look at second commit