Uh oh!
There was an error while loading. Please reload this page.
fix inline code regex - #1337
Conversation
styfle
commented
Sep 16, 2018
Which issue is this fixing? |
UziTech
commented
Sep 16, 2018
The slack issue |
I'm not confident that this change will address the Slack issue. I will ponder it tomorrow. |
UziTech
commented
Sep 16, 2018
When I tested this change the POC went from 9s to a few ms |
davisjam
commented
Sep 16, 2018
@UziTech Acknowledged. I am thinking about whether variations will still lead to the problem. |
UziTech
commented
Sep 17, 2018
I updated the regex to pass more of the code span spec. @davisjam check if the new regex is safe. |
UziTech
commented
Sep 18, 2018
I rebased and fixed the merge conflicts after #1338 |
davisjam
commented
Sep 20, 2018
I have reviewed the regexes. LGTM. |
joshbruce
commented
Sep 23, 2018
Releasing |
UziTech
commented
Sep 23, 2018
@joshbruce I really think we should merge #1331 before a new release |
joshbruce
commented
Sep 23, 2018
Oh. I thought it was already merged. Still good to go, yeah? (From 17 days ago, my bad.) |
UziTech
commented
Sep 23, 2018
Yup should be good to go |
Marked version: 0.5.0
Description
fixes#1218
Contributor
Committer
In most cases, this should be a different person than the contributor.