Skip to content

Fix auto-linking email - #1338

Merged
styfle merged 4 commits into
markedjs:masterfrom
Feder1co5oave:fix-1218
Sep 18, 2018
Merged

Fix auto-linking email#1338
styfle merged 4 commits into
markedjs:masterfrom
Feder1co5oave:fix-1218

Conversation

@Feder1co5oave

@Feder1co5oaveFeder1co5oave commented Sep 18, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

Markdown flavor: GitHub Flavored

Description

Fixes#1218 (see comment)
Fixes#1307
Fixes#1327

I believe this complies better with the gfm spec.

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR)

@styfle

styfle commented Sep 18, 2018•
edited
Loading

Copy link
Copy Markdown
Member

This looks like a duplicate of PR #1337
I think I prefer #1337 because it fixes several bugs. And because it's LEET 😃

@Feder1co5oave

Feder1co5oave commented Sep 18, 2018

Copy link
Copy Markdown
ContributorAuthor

@styfle see #1218 (comment)

@Feder1co5oave

Feder1co5oave commented Sep 18, 2018

Copy link
Copy Markdown
ContributorAuthor

updated fix list

UziTech
UziTech approved these changes Sep 18, 2018
View reviewed changes

@UziTechUziTech left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1337 fix for this was just to move code span precedence above autolink but I like this solution better. We could merge this and I will fix merge conflicts in #1337

@styfle

styfle commented Sep 18, 2018•
edited
Loading

Copy link
Copy Markdown
Member

I didn't realize this fixes the strike-though and bold bugs too! Let me take a look again.

styfle
styfle reviewed Sep 18, 2018
View reviewed changes
Comment threadlib/marked.js
@styflestyfle changed the title Fix 1218Fix auto-linking emailSep 18, 2018
@styfle

styfle commented Sep 18, 2018

Copy link
Copy Markdown
Member

Alright I'll go ahead and merge this

@styfle
styfle merged commit 2a94e20 into markedjs:masterSep 18, 2018
@Feder1co5oave
Feder1co5oave deleted the fix-1218 branch September 18, 2018 21:22
@UziTechUziTech mentioned this pull request Sep 18, 2018
Merged
4 tasks
@styflestyfle mentioned this pull request Sep 24, 2018
Merged
12 tasks
@UziTechUziTech mentioned this pull request Sep 25, 2018
Closed
@snyk-botsnyk-bot mentioned this pull request Aug 19, 2019
Open
This was referenced Aug 30, 2019
Open
Open
@snyk-botsnyk-bot mentioned this pull request Sep 24, 2019
Open
This was referenced Oct 26, 2019
Open
Open
Open
Closed
Open
@snyk-botsnyk-bot mentioned this pull request Nov 4, 2019
Open
@snyk-botsnyk-bot mentioned this pull request Nov 18, 2019
Open
@yogansnykgityogansnykgit mentioned this pull request Oct 25, 2024
Open
@shad0w92shad0w92 mentioned this pull request Oct 26, 2024
Open
@shyamaaronshyamaaron mentioned this pull request Oct 26, 2024
Open
@Gowtham3223108Gowtham3223108 mentioned this pull request Oct 26, 2024
Open
@udayreddy026udayreddy026 mentioned this pull request Oct 26, 2024
Open
@moamed-syedmoamed-syed mentioned this pull request Oct 27, 2024
Open
@ManPrivateManPrivate mentioned this pull request Oct 27, 2024
Closed
@tdsnyktdsnyk mentioned this pull request Oct 28, 2024
Open
@sri-sankarisri-sankari mentioned this pull request Oct 28, 2024
Open
@mohankumar931mohankumar931 mentioned this pull request Oct 28, 2024
Open
@sound25sound25 mentioned this pull request Oct 29, 2024
Open
@Latha-lgtmLatha-lgtm mentioned this pull request Oct 29, 2024
Open
@GOWTHAMAKURINJIVEANDANGOWTHAMAKURINJIVEANDAN mentioned this pull request Oct 29, 2024
Open
@Dejah2024Dejah2024 mentioned this pull request Oct 30, 2024
Open
@ThiruVaithiyaThiruVaithiya mentioned this pull request Oct 30, 2024
Open
@Suriya0802Suriya0802 mentioned this pull request Oct 30, 2024
Open
@Shriv12Shriv12 mentioned this pull request Oct 30, 2024
Open
@Magali0007Magali0007 mentioned this pull request Oct 31, 2024
Open
@Ganesh13349Ganesh13349 mentioned this pull request Oct 31, 2024
Open
@sinnakkrishnansinnakkrishnan mentioned this pull request Nov 1, 2024
Open
@krithika-manoharkrithika-manohar mentioned this pull request Nov 1, 2024
Open
@SAGAYANELSON55SAGAYANELSON55 mentioned this pull request Nov 1, 2024
Open
@swathi-raswathi-ra mentioned this pull request Nov 2, 2024
Open
@HUGO-AppSecHUGO-AppSec mentioned this pull request Nov 3, 2024
Open
@danielsb74danielsb74 mentioned this pull request Nov 5, 2024
Open
@selvaganesh26selvaganesh26 mentioned this pull request Nov 5, 2024
Open
@merkeldevmerkeldev mentioned this pull request Nov 5, 2024
Open
@joedean-gitjoedean-git mentioned this pull request Nov 9, 2024
Open
@MimiDas-SnykMimiDas-Snyk mentioned this pull request Nov 10, 2024
Open
@BenDrKoBenDrKo mentioned this pull request Nov 11, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UziTechUziTechUziTech approved these changes
@styflestyflestyfle approved these changes

Assignees

No one assigned

Labels

category: links

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Feder1co5oave@styfle@UziTech