Uh oh!
There was an error while loading. Please reload this page.
fix emphasis closing by single _ (part of left-flanking run) - #1351
Conversation
fixes CommonMark: 456, 355, 451, 354, 356
styfle
commented
Oct 8, 2018
Hi @RomanGotsiy thanks for the PR! It looks like the links to the demo have a slightly different input than what you put in this PR. That being said, the fix the the link appears to work so I added a couple more reviewers. |
RomanHotsiy
commented
Oct 8, 2018
@styfle yes, updated the comment |
styfle
commented
Oct 17, 2018
Thanks Roman! 🎉 |
RomanHotsiy
commented
Oct 17, 2018
Thanks for merging! |
styfle
commented
Oct 17, 2018
No not yet. We could probably do a patch release soon. Keep an eye out for a release PR...it will probably be from @UziTech |
kaelig
commented
Nov 20, 2018
This seems to have caused a regression. Expected: https://spec.commonmark.org/dingus/?text=_foo_%2C%20_bar_ Should I open an issue? |
styfle
commented
Nov 21, 2018
Yes please! And if you could determine which CommonMark test this is violating that would be helpful 😃 This PR added many more passing CM spec tests so there must be one in there we were ignoring and now regressed. |
Marked version:
0.5.1
Markdown flavor: CommonMark
Description
Fixes CommonMark: 456, 355, 451, 354, 356
Also, the concrete use case:
Expectation
CommonMark playground link)
Result
Marked playground link)
Contributor
Committer
In most cases, this should be a different person than the contributor.