Skip to content

Fix emphasis followed by a punctuation - #1383

Merged
styfle merged 3 commits into
markedjs:masterfrom
RomanHotsiy:master
Dec 5, 2018
Merged

Fix emphasis followed by a punctuation#1383
styfle merged 3 commits into
markedjs:masterfrom
RomanHotsiy:master

Conversation

@RomanHotsiy

@RomanHotsiyRomanHotsiy commented Dec 5, 2018•
edited by styfle
Loading

Copy link
Copy Markdown
Contributor

Marked version:

0.5.2

Markdown flavor: CommonMark

Description

My previous PR #1351 caused a regression for some emphasis use cases. There is no specific CommonMark test to catch that. @styfle could you suggest me where to put the test for this specific use case so it won't break in the future?

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

UziTech
UziTech reviewed Dec 5, 2018
View reviewed changes
Comment threadlib/marked.js Outdated
UziTech
UziTech requested changes Dec 5, 2018
View reviewed changes

@UziTechUziTech left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me if all the tests pass

@UziTech@RomanHotsiy
Remove trailing space
1386867
Co-Authored-By: RomanGotsiy <gotsijroman@gmail.com>
@UziTech

UziTech commented Dec 5, 2018

Copy link
Copy Markdown
Member

@RomanGotsiy you can add a test in https://github.com/markedjs/marked/blob/master/test/specs/marked/marked.json

@RomanHotsiy

RomanHotsiy commented Dec 5, 2018

Copy link
Copy Markdown
ContributorAuthor

@UziTech Added a few extra tests and fixed lint issue.

styfle
styfle approved these changes Dec 5, 2018
View reviewed changes

@styflestyfle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wonderful, thanks!

@styflestyfle changed the title Fix emphasis followed by a punctuation (fixes #1378)Fix emphasis followed by a punctuationDec 5, 2018
@styfle
styfle merged commit f8d556a into markedjs:masterDec 5, 2018
@RomanHotsiyRomanHotsiy mentioned this pull request Dec 6, 2018
Merged
@lpincalpinca mentioned this pull request Jan 2, 2019
Merged
RomanHotsiy pushed a commit to Redocly/redoc that referenced this pull request Jan 17, 2019
@lpinca@RomanHotsiy
chore: update marked to version 0.6.0 (#768)
02f6e18
The new release includes markedjs/marked#1383.
@snyk-botsnyk-bot mentioned this pull request Aug 19, 2019
Open
This was referenced Aug 30, 2019
Open
Open
@snyk-botsnyk-bot mentioned this pull request Sep 24, 2019
Open
This was referenced Oct 26, 2019
Open
Open
Open
Closed
Open
@snyk-botsnyk-bot mentioned this pull request Nov 4, 2019
Open
This was referenced Nov 18, 2019
Open
Open
Open
Open
@yogansnykgityogansnykgit mentioned this pull request Oct 25, 2024
Open
@shad0w92shad0w92 mentioned this pull request Oct 26, 2024
Open
@shyamaaronshyamaaron mentioned this pull request Oct 26, 2024
Open
@Gowtham3223108Gowtham3223108 mentioned this pull request Oct 26, 2024
Open
@udayreddy026udayreddy026 mentioned this pull request Oct 26, 2024
Open
@moamed-syedmoamed-syed mentioned this pull request Oct 27, 2024
Open
@ManPrivateManPrivate mentioned this pull request Oct 27, 2024
Closed
@tdsnyktdsnyk mentioned this pull request Oct 28, 2024
Open
@sri-sankarisri-sankari mentioned this pull request Oct 28, 2024
Open
@mohankumar931mohankumar931 mentioned this pull request Oct 28, 2024
Open
@sound25sound25 mentioned this pull request Oct 29, 2024
Open
@Latha-lgtmLatha-lgtm mentioned this pull request Oct 29, 2024
Open
@GOWTHAMAKURINJIVEANDANGOWTHAMAKURINJIVEANDAN mentioned this pull request Oct 29, 2024
Open
@Dejah2024Dejah2024 mentioned this pull request Oct 30, 2024
Open
@ThiruVaithiyaThiruVaithiya mentioned this pull request Oct 30, 2024
Open
@Suriya0802Suriya0802 mentioned this pull request Oct 30, 2024
Open
@Shriv12Shriv12 mentioned this pull request Oct 30, 2024
Open
@Magali0007Magali0007 mentioned this pull request Oct 31, 2024
Open
@Ganesh13349Ganesh13349 mentioned this pull request Oct 31, 2024
Open
@sinnakkrishnansinnakkrishnan mentioned this pull request Nov 1, 2024
Open
@krithika-manoharkrithika-manohar mentioned this pull request Nov 1, 2024
Open
@SAGAYANELSON55SAGAYANELSON55 mentioned this pull request Nov 1, 2024
Open
@swathi-raswathi-ra mentioned this pull request Nov 2, 2024
Open
@HUGO-AppSecHUGO-AppSec mentioned this pull request Nov 3, 2024
Open
@danielsb74danielsb74 mentioned this pull request Nov 5, 2024
Open
@selvaganesh26selvaganesh26 mentioned this pull request Nov 5, 2024
Open
@merkeldevmerkeldev mentioned this pull request Nov 5, 2024
Open
@joedean-gitjoedean-git mentioned this pull request Nov 9, 2024
Open
@MimiDas-SnykMimiDas-Snyk mentioned this pull request Nov 10, 2024
Open
@BenDrKoBenDrKo mentioned this pull request Nov 11, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UziTechUziTechUziTech approved these changes
@styflestyflestyfle approved these changes

Assignees

No one assigned

Labels

category: inline elements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RomanHotsiy@UziTech@styfle