Uh oh!
There was an error while loading. Please reload this page.
Knot theory fixes - #1199
Conversation
rocky
commented
Mar 25, 2021
@mmatera think I understand how to write the type table-lookup code I was describing in a rough way. What would help though is are some useful tests that come up. |
| # Wrap types in a list (if it isn't already one) | ||
| if not types.has_form("List", None): | ||
| if types.get_head_name() == "System`Hold": |
There was a problem hiding this comment.
This seems hoaky since the specification of Read[] seems to allow any function and not just Hold[] right?
rocky
left a comment
There was a problem hiding this comment.
Please let's start splitting this up into the individual pieces and create separate PRs for this.
For example Setting System`Notebooks is a thing in of itself and not even needed for Feyncalc.
That could be merged in by itself.
The problem with these growing grab-bag PRs is that they are impossible to review and the quality can suffer because we can't focus on individual features.
And then they are continually merged (when rebasing instead of merging would lead to more comprehensible results)
| <dd>splits $s$ at the delimiter $d$. | ||
| <dt>'StringSplit[$s$, {"$d1$", "$d2$", ...}]' | ||
| <dd>splits $s$ using multiple delimiters. | ||
| <dt>'StringSplit[{$s_1$, $s_2, $\ldots$}, {"$d1$", "$d2$", ...}]' |
There was a problem hiding this comment.
Note that ldots doesn't render in the Django interface.
fix duplicated DirectedInfinity entry restoring tests Fix Positive/Negative tests clean and working comment out debuggin prints clean and improved tests fix duplicated DirectedInfinity entry clean and improved tests fix duplicated DirectedInfinity entry restoring tests Fix Positive/Negative tests clean and working reverting changes in modules splitting working and not working tests... split in working, possible working with small changes, and not working
fix comparison all tests in green
mmatera
commented
Apr 1, 2021
Spli
|
rocky
commented
Apr 3, 2021
Superceded by other PRs. |
No description provided.