Skip to content

StringSplit: adding support for handling lists as a first argument - #1216

Merged
rocky merged 6 commits into
masterfrom
improvestringsplit
Apr 3, 2021
Merged

StringSplit: adding support for handling lists as a first argument#1216
rocky merged 6 commits into
masterfrom
improvestringsplit

Conversation

@mmatera

Copy link
Copy Markdown
Contributor

From #1199

@mmaterammatera changed the title adding support for handling lists as a first argumentStringSplit: adding support for handling lists as a first argumentMar 31, 2021
using `...` instead ldots
@mmaterammatera mentioned this pull request Apr 1, 2021
Comment threadCHANGES.rst Outdated
as a Python function.
* ``Equal[]`` now compares complex against other numbers properly.
* Improvements in handling products with infinite factors: ``0 Infinity``-> ``Indeterminate``, and ``expr Infinity``-> ``DirectedInfinite[expr]``
* `StringSplit` not support lists as a first argument.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not support -> now supports

Comment threadCHANGES.rst
* Improvements in handling products with infinite factors: ``0 Infinity``-> ``Indeterminate``, and ``expr Infinity``-> ``DirectedInfinite[expr]``
* `StringSplit` not support lists as a first argument.
* `StringSplit` now supports lists as a first argument.
* ``SetDelayed`` now accept several conditions impossed both at LHS as well as RHS.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh - just noticed that this should be two backquotes not one. (This kind of stuff I'd probably catch in reviewing release notes though).

@rockyrocky mentioned this pull request Apr 3, 2021
@rocky
rocky requested review from rocky and removed request for rockyApril 3, 2021 08:41

@rockyrocky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks! (I'll correct the CHANGES.rst formatting after merge)

@rocky
rocky merged commit eb2835d into masterApr 3, 2021
rocky added a commit that referenced this pull request Apr 3, 2021
`StringSplit`: adding support for handling lists as a first argument
@rocky
rocky deleted the improvestringsplit branch April 3, 2021 12:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mmatera@rocky