Uh oh!
There was an error while loading. Please reload this page.
Fixcomparison rebase - #1256
Closed
rocky wants to merge 11 commits into
Closed
Conversation
fix duplicated DirectedInfinity entry restoring tests Fix Positive/Negative tests clean and working comment out debuggin prints clean and improved tests fix duplicated DirectedInfinity entry clean and improved tests fix duplicated DirectedInfinity entry restoring tests Fix Positive/Negative tests clean and working reverting changes in modules splitting working and not working tests... split in working, possible working with small changes, and not working
fix comparison all tests in green
blacken clean appendicial comment changes
do_comparison -> equal2 l1, l2 -> lhs, rhs Use newer test helper and Compress/Uncompress test
rockyforce-pushed
the
fixcomparison-rebase
branch
from
April 11, 2021 00:18
19a452d to
a047b46Comparerockyforce-pushed
the
fixcomparison-rebase
branch
from
April 11, 2021 00:22
a047b46 to
32d130aComparerocky
marked this pull request as draft
April 11, 2021 00:38
Resolve merge conflicts with master
rocky
marked this pull request as ready for review
April 11, 2021 14:43
rocky
marked this pull request as draft
April 11, 2021 14:44
rockyforce-pushed
the
fixcomparison-rebase
branch
from
April 11, 2021 17:39
b51f400 to
517f5ecCompareNote that comparison expectations for Compiled code is different. test_compare.py passes. More simplification is needed.
until I understand *why* this isn't False.
rockyforce-pushed
the
fixcomparison-rebase
branch
from
April 12, 2021 00:17
517f5ec to
282646dComparemmatera
commented
Apr 14, 2021
Contributor
merged in #1209 |
rocky added a commit
that referenced
this pull request
May 2, 2021
* we were not using the psutil return values in reporting values * make psutil mandatory rather than optional: it appears to work on all the platforms we support. Fixes#1256
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for testing mergabiity with master separately from mergability with the fixcomparison branch.
It will not be merged directly, but the fixcomparison branch with this and further changes is intended to be merged.