Add handling for exceptions raised by requests library by non-Jedi · Pull Request #123 · matrix-org/matrix-python-sdk

non-Jedi · 2017-04-24T01:29:29Z

Use of requests is an implementation detail, so we shouldn't let exceptions raised by requests leak through to any application developers.

Technically this may need a major version bump since someone may have been manually handling exceptions raised by requests. But I doubt it.

matrixbot · 2017-04-24T01:29:30Z

Can one of the admins verify this patch?

Half-Shot · 2017-04-25T17:35:34Z

ok to test

Half-Shot · 2017-04-25T17:36:37Z

I feel like this could perhaps do more. Do you think it would be possible for the exception to contain more details about the request that failed? Perhaps the endpoint that it tried to request?

Other than that, this looks fine.

non-Jedi · 2017-05-04T18:59:07Z

Done. Let me know if you'd like even more info than that included. Given that the circumstances where requests would raise an exception for one matrix endpoint but not another are relatively rare, I think this should be sufficient along with the traceback for debugging.

Half-Shot · 2017-05-15T00:43:19Z

+ )
+ except requests.exceptions.RequestException as e:
+ raise MatrixHttpLibError(
+ "Something went wrong in {} requesting {}".format(method, endpoint), e


Personal preference is to pass in method and endpoint as parameters to the exception and format it inside the constructor, in case I might want to disassemble it as a handler down the line.

Half-Shot · 2017-05-15T00:43:55Z

Other than that, LGTM 👍

4nd3r · 2017-10-17T08:15:19Z

can we merge this?

using this sdk, without able to catch exceptions by requests library, is really annoying :<

lugino-emeritus · 2017-10-18T17:47:01Z

We should also add the request-timeout to this pull request (see #157)

non-Jedi · 2017-10-22T18:43:42Z

@4nd3r apologies if absence of this is affecting things for you. I'll prioritize this one. As it stands right now, you could directly catch exceptions raised by requests.

Signed-off-by: Adam Beckmeyer <adam_git@thebeckmeyers.xyz>

non-Jedi · 2017-04-24T01:29:29Z

Use of requests is an implementation detail, so we shouldn't let exceptions raised by requests leak through to any application developers.

Technically this may need a major version bump since someone may have been manually handling exceptions raised by requests. But I doubt it.

matrixbot · 2017-04-24T01:29:30Z

Can one of the admins verify this patch?

Half-Shot · 2017-04-25T17:35:34Z

ok to test

Half-Shot · 2017-04-25T17:36:37Z

I feel like this could perhaps do more. Do you think it would be possible for the exception to contain more details about the request that failed? Perhaps the endpoint that it tried to request?

Other than that, this looks fine.

non-Jedi · 2017-05-04T18:59:07Z

Done. Let me know if you'd like even more info than that included. Given that the circumstances where requests would raise an exception for one matrix endpoint but not another are relatively rare, I think this should be sufficient along with the traceback for debugging.

Half-Shot · 2017-05-15T00:43:19Z

+ )
+ except requests.exceptions.RequestException as e:
+ raise MatrixHttpLibError(
+ "Something went wrong in {} requesting {}".format(method, endpoint), e


Personal preference is to pass in method and endpoint as parameters to the exception and format it inside the constructor, in case I might want to disassemble it as a handler down the line.

Half-Shot · 2017-05-15T00:43:55Z

Other than that, LGTM 👍

4nd3r · 2017-10-17T08:15:19Z

can we merge this?

using this sdk, without able to catch exceptions by requests library, is really annoying :<

lugino-emeritus · 2017-10-18T17:47:01Z

We should also add the request-timeout to this pull request (see #157)

non-Jedi · 2017-10-22T18:43:42Z

@4nd3r apologies if absence of this is affecting things for you. I'll prioritize this one. As it stands right now, you could directly catch exceptions raised by requests.

Signed-off-by: Adam Beckmeyer <adam_git@thebeckmeyers.xyz>

non-Jedi · 2017-04-24T01:29:29Z

Use of requests is an implementation detail, so we shouldn't let exceptions raised by requests leak through to any application developers.

Technically this may need a major version bump since someone may have been manually handling exceptions raised by requests. But I doubt it.

matrixbot · 2017-04-24T01:29:30Z

Can one of the admins verify this patch?

Half-Shot · 2017-04-25T17:35:34Z

ok to test

Half-Shot · 2017-04-25T17:36:37Z

I feel like this could perhaps do more. Do you think it would be possible for the exception to contain more details about the request that failed? Perhaps the endpoint that it tried to request?

Other than that, this looks fine.

non-Jedi · 2017-05-04T18:59:07Z

Done. Let me know if you'd like even more info than that included. Given that the circumstances where requests would raise an exception for one matrix endpoint but not another are relatively rare, I think this should be sufficient along with the traceback for debugging.

Half-Shot · 2017-05-15T00:43:19Z

+ )
+ except requests.exceptions.RequestException as e:
+ raise MatrixHttpLibError(
+ "Something went wrong in {} requesting {}".format(method, endpoint), e


Personal preference is to pass in method and endpoint as parameters to the exception and format it inside the constructor, in case I might want to disassemble it as a handler down the line.

Half-Shot · 2017-05-15T00:43:55Z

Other than that, LGTM 👍

4nd3r · 2017-10-17T08:15:19Z

can we merge this?

using this sdk, without able to catch exceptions by requests library, is really annoying :<

lugino-emeritus · 2017-10-18T17:47:01Z

We should also add the request-timeout to this pull request (see #157)

non-Jedi · 2017-10-22T18:43:42Z

@4nd3r apologies if absence of this is affecting things for you. I'll prioritize this one. As it stands right now, you could directly catch exceptions raised by requests.

Signed-off-by: Adam Beckmeyer <adam_git@thebeckmeyers.xyz>

non-Jedi · 2017-04-24T01:29:29Z

Use of requests is an implementation detail, so we shouldn't let exceptions raised by requests leak through to any application developers.

Technically this may need a major version bump since someone may have been manually handling exceptions raised by requests. But I doubt it.

matrixbot · 2017-04-24T01:29:30Z

Can one of the admins verify this patch?

Half-Shot · 2017-04-25T17:35:34Z

ok to test

Half-Shot · 2017-04-25T17:36:37Z

I feel like this could perhaps do more. Do you think it would be possible for the exception to contain more details about the request that failed? Perhaps the endpoint that it tried to request?

Other than that, this looks fine.

non-Jedi · 2017-05-04T18:59:07Z

Done. Let me know if you'd like even more info than that included. Given that the circumstances where requests would raise an exception for one matrix endpoint but not another are relatively rare, I think this should be sufficient along with the traceback for debugging.

Half-Shot · 2017-05-15T00:43:19Z

+ )
+ except requests.exceptions.RequestException as e:
+ raise MatrixHttpLibError(
+ "Something went wrong in {} requesting {}".format(method, endpoint), e


Personal preference is to pass in method and endpoint as parameters to the exception and format it inside the constructor, in case I might want to disassemble it as a handler down the line.

Half-Shot · 2017-05-15T00:43:55Z

Other than that, LGTM 👍

4nd3r · 2017-10-17T08:15:19Z

can we merge this?

using this sdk, without able to catch exceptions by requests library, is really annoying :<

lugino-emeritus · 2017-10-18T17:47:01Z

We should also add the request-timeout to this pull request (see #157)

non-Jedi · 2017-10-22T18:43:42Z

@4nd3r apologies if absence of this is affecting things for you. I'll prioritize this one. As it stands right now, you could directly catch exceptions raised by requests.

Signed-off-by: Adam Beckmeyer <adam_git@thebeckmeyers.xyz>

non-Jedi · 2017-04-24T01:29:29Z

Use of requests is an implementation detail, so we shouldn't let exceptions raised by requests leak through to any application developers.

Technically this may need a major version bump since someone may have been manually handling exceptions raised by requests. But I doubt it.

matrixbot · 2017-04-24T01:29:30Z

Can one of the admins verify this patch?

Half-Shot · 2017-04-25T17:35:34Z

ok to test

Half-Shot · 2017-04-25T17:36:37Z

I feel like this could perhaps do more. Do you think it would be possible for the exception to contain more details about the request that failed? Perhaps the endpoint that it tried to request?

Other than that, this looks fine.

non-Jedi · 2017-05-04T18:59:07Z

Done. Let me know if you'd like even more info than that included. Given that the circumstances where requests would raise an exception for one matrix endpoint but not another are relatively rare, I think this should be sufficient along with the traceback for debugging.

Half-Shot · 2017-05-15T00:43:19Z

+ )
+ except requests.exceptions.RequestException as e:
+ raise MatrixHttpLibError(
+ "Something went wrong in {} requesting {}".format(method, endpoint), e


Personal preference is to pass in method and endpoint as parameters to the exception and format it inside the constructor, in case I might want to disassemble it as a handler down the line.

Half-Shot · 2017-05-15T00:43:55Z

Other than that, LGTM 👍

4nd3r · 2017-10-17T08:15:19Z

can we merge this?

using this sdk, without able to catch exceptions by requests library, is really annoying :<

lugino-emeritus · 2017-10-18T17:47:01Z

We should also add the request-timeout to this pull request (see #157)

non-Jedi · 2017-10-22T18:43:42Z

@4nd3r apologies if absence of this is affecting things for you. I'll prioritize this one. As it stands right now, you could directly catch exceptions raised by requests.

Signed-off-by: Adam Beckmeyer <adam_git@thebeckmeyers.xyz>

non-Jedi · 2017-04-24T01:29:29Z

Use of requests is an implementation detail, so we shouldn't let exceptions raised by requests leak through to any application developers.

Technically this may need a major version bump since someone may have been manually handling exceptions raised by requests. But I doubt it.

matrixbot · 2017-04-24T01:29:30Z

Can one of the admins verify this patch?

Half-Shot · 2017-04-25T17:35:34Z

ok to test

Half-Shot · 2017-04-25T17:36:37Z

I feel like this could perhaps do more. Do you think it would be possible for the exception to contain more details about the request that failed? Perhaps the endpoint that it tried to request?

Other than that, this looks fine.

non-Jedi · 2017-05-04T18:59:07Z

Done. Let me know if you'd like even more info than that included. Given that the circumstances where requests would raise an exception for one matrix endpoint but not another are relatively rare, I think this should be sufficient along with the traceback for debugging.

Half-Shot · 2017-05-15T00:43:19Z

+ )
+ except requests.exceptions.RequestException as e:
+ raise MatrixHttpLibError(
+ "Something went wrong in {} requesting {}".format(method, endpoint), e


Personal preference is to pass in method and endpoint as parameters to the exception and format it inside the constructor, in case I might want to disassemble it as a handler down the line.

Half-Shot · 2017-05-15T00:43:55Z

Other than that, LGTM 👍

4nd3r · 2017-10-17T08:15:19Z

can we merge this?

using this sdk, without able to catch exceptions by requests library, is really annoying :<

lugino-emeritus · 2017-10-18T17:47:01Z

We should also add the request-timeout to this pull request (see #157)

non-Jedi · 2017-10-22T18:43:42Z

@4nd3r apologies if absence of this is affecting things for you. I'll prioritize this one. As it stands right now, you could directly catch exceptions raised by requests.

Signed-off-by: Adam Beckmeyer <adam_git@thebeckmeyers.xyz>

non-Jedi · 2017-04-24T01:29:29Z

Use of requests is an implementation detail, so we shouldn't let exceptions raised by requests leak through to any application developers.

Technically this may need a major version bump since someone may have been manually handling exceptions raised by requests. But I doubt it.

matrixbot · 2017-04-24T01:29:30Z

Can one of the admins verify this patch?

Half-Shot · 2017-04-25T17:35:34Z

ok to test

Half-Shot · 2017-04-25T17:36:37Z

I feel like this could perhaps do more. Do you think it would be possible for the exception to contain more details about the request that failed? Perhaps the endpoint that it tried to request?

Other than that, this looks fine.

non-Jedi · 2017-05-04T18:59:07Z

Done. Let me know if you'd like even more info than that included. Given that the circumstances where requests would raise an exception for one matrix endpoint but not another are relatively rare, I think this should be sufficient along with the traceback for debugging.

Half-Shot · 2017-05-15T00:43:19Z

+ )
+ except requests.exceptions.RequestException as e:
+ raise MatrixHttpLibError(
+ "Something went wrong in {} requesting {}".format(method, endpoint), e


Personal preference is to pass in method and endpoint as parameters to the exception and format it inside the constructor, in case I might want to disassemble it as a handler down the line.

Half-Shot · 2017-05-15T00:43:55Z

Other than that, LGTM 👍

4nd3r · 2017-10-17T08:15:19Z

can we merge this?

using this sdk, without able to catch exceptions by requests library, is really annoying :<

lugino-emeritus · 2017-10-18T17:47:01Z

We should also add the request-timeout to this pull request (see #157)

non-Jedi · 2017-10-22T18:43:42Z

@4nd3r apologies if absence of this is affecting things for you. I'll prioritize this one. As it stands right now, you could directly catch exceptions raised by requests.

Signed-off-by: Adam Beckmeyer <adam_git@thebeckmeyers.xyz>

non-Jedi · 2017-04-24T01:29:29Z

Use of requests is an implementation detail, so we shouldn't let exceptions raised by requests leak through to any application developers.

Technically this may need a major version bump since someone may have been manually handling exceptions raised by requests. But I doubt it.

matrixbot · 2017-04-24T01:29:30Z

Can one of the admins verify this patch?

Half-Shot · 2017-04-25T17:35:34Z

ok to test

Half-Shot · 2017-04-25T17:36:37Z

I feel like this could perhaps do more. Do you think it would be possible for the exception to contain more details about the request that failed? Perhaps the endpoint that it tried to request?

Other than that, this looks fine.

non-Jedi · 2017-05-04T18:59:07Z

Done. Let me know if you'd like even more info than that included. Given that the circumstances where requests would raise an exception for one matrix endpoint but not another are relatively rare, I think this should be sufficient along with the traceback for debugging.

Half-Shot · 2017-05-15T00:43:19Z

+ )
+ except requests.exceptions.RequestException as e:
+ raise MatrixHttpLibError(
+ "Something went wrong in {} requesting {}".format(method, endpoint), e


Personal preference is to pass in method and endpoint as parameters to the exception and format it inside the constructor, in case I might want to disassemble it as a handler down the line.

Half-Shot · 2017-05-15T00:43:55Z

Other than that, LGTM 👍

4nd3r · 2017-10-17T08:15:19Z

can we merge this?

using this sdk, without able to catch exceptions by requests library, is really annoying :<

lugino-emeritus · 2017-10-18T17:47:01Z

We should also add the request-timeout to this pull request (see #157)

non-Jedi · 2017-10-22T18:43:42Z

@4nd3r apologies if absence of this is affecting things for you. I'll prioritize this one. As it stands right now, you could directly catch exceptions raised by requests.

Signed-off-by: Adam Beckmeyer <adam_git@thebeckmeyers.xyz>

Half-Shot added the Awaiting Changes label Apr 29, 2017

Half-Shot removed the Awaiting Changes label May 5, 2017

Half-Shot self-requested a review May 5, 2017 07:53

Half-Shot reviewed May 15, 2017
View reviewed changes

non-Jedi mentioned this pull request Sep 16, 2017
Make MatrixClient asynchronous #145
Closed

non-Jedi added the Awaiting Changes label Sep 22, 2017

non-Jedi self-assigned this Sep 22, 2017

lugino-emeritus mentioned this pull request Oct 23, 2017
Adding request timeout #157
Open

non-Jedi added 2 commits October 23, 2017 21:20

Add handling for exceptions raised by requests library
99aa557
Signed-off-by: Adam Beckmeyer <adam_git@thebeckmeyers.xyz>

Add more info when MatrixHttpLibError is raised
10db977
Signed-off-by: Adam Beckmeyer <adam_git@thebeckmeyers.xyz>

non-Jedi force-pushed the handle_requests_exceptions branch from 8081c31 to 10db977Compare October 24, 2017 01:20

Construct error message inside of error instead of outside
3982688

non-Jedi merged commit 3982688 into matrix-org:masterOct 25, 2017

jahschwa mentioned this pull request Nov 30, 2017
matrix: HANDLE EXCEPTIONS OMG jahschwa/sibyl#4
Closed

Half-Shot added the Awaiting Changes label Apr 29, 2017

Half-Shot removed the Awaiting Changes label May 5, 2017

Half-Shot self-requested a review May 5, 2017 07:53

Half-Shot reviewed May 15, 2017
View reviewed changes

non-Jedi mentioned this pull request Sep 16, 2017
Make MatrixClient asynchronous #145
Closed

non-Jedi added the Awaiting Changes label Sep 22, 2017

non-Jedi self-assigned this Sep 22, 2017

lugino-emeritus mentioned this pull request Oct 23, 2017
Adding request timeout #157
Open

non-Jedi added 2 commits October 23, 2017 21:20

Add handling for exceptions raised by requests library
99aa557
Signed-off-by: Adam Beckmeyer <adam_git@thebeckmeyers.xyz>

Add more info when MatrixHttpLibError is raised
10db977
Signed-off-by: Adam Beckmeyer <adam_git@thebeckmeyers.xyz>

non-Jedi force-pushed the handle_requests_exceptions branch from 8081c31 to 10db977Compare October 24, 2017 01:20

Construct error message inside of error instead of outside
3982688

non-Jedi merged commit 3982688 into matrix-org:masterOct 25, 2017

jahschwa mentioned this pull request Nov 30, 2017
matrix: HANDLE EXCEPTIONS OMG jahschwa/sibyl#4
Closed

Half-Shot added the Awaiting Changes label Apr 29, 2017

Half-Shot removed the Awaiting Changes label May 5, 2017

Half-Shot self-requested a review May 5, 2017 07:53

Half-Shot reviewed May 15, 2017
View reviewed changes

non-Jedi mentioned this pull request Sep 16, 2017
Make MatrixClient asynchronous #145
Closed

non-Jedi added the Awaiting Changes label Sep 22, 2017

non-Jedi self-assigned this Sep 22, 2017

lugino-emeritus mentioned this pull request Oct 23, 2017
Adding request timeout #157
Open

non-Jedi added 2 commits October 23, 2017 21:20

Add handling for exceptions raised by requests library
99aa557
Signed-off-by: Adam Beckmeyer <adam_git@thebeckmeyers.xyz>

Add more info when MatrixHttpLibError is raised
10db977
Signed-off-by: Adam Beckmeyer <adam_git@thebeckmeyers.xyz>

non-Jedi force-pushed the handle_requests_exceptions branch from 8081c31 to 10db977Compare October 24, 2017 01:20

Construct error message inside of error instead of outside
3982688

non-Jedi merged commit 3982688 into matrix-org:masterOct 25, 2017

jahschwa mentioned this pull request Nov 30, 2017
matrix: HANDLE EXCEPTIONS OMG jahschwa/sibyl#4
Closed

Half-Shot added the Awaiting Changes label Apr 29, 2017

Half-Shot removed the Awaiting Changes label May 5, 2017

Half-Shot self-requested a review May 5, 2017 07:53

Half-Shot reviewed May 15, 2017
View reviewed changes

non-Jedi mentioned this pull request Sep 16, 2017
Make MatrixClient asynchronous #145
Closed

non-Jedi added the Awaiting Changes label Sep 22, 2017

non-Jedi self-assigned this Sep 22, 2017

lugino-emeritus mentioned this pull request Oct 23, 2017
Adding request timeout #157
Open

non-Jedi added 2 commits October 23, 2017 21:20

Add handling for exceptions raised by requests library
99aa557
Signed-off-by: Adam Beckmeyer <adam_git@thebeckmeyers.xyz>

Add more info when MatrixHttpLibError is raised
10db977
Signed-off-by: Adam Beckmeyer <adam_git@thebeckmeyers.xyz>

non-Jedi force-pushed the handle_requests_exceptions branch from 8081c31 to 10db977Compare October 24, 2017 01:20

Construct error message inside of error instead of outside
3982688

non-Jedi merged commit 3982688 into matrix-org:masterOct 25, 2017

jahschwa mentioned this pull request Nov 30, 2017
matrix: HANDLE EXCEPTIONS OMG jahschwa/sibyl#4
Closed

Half-Shot added the Awaiting Changes label Apr 29, 2017

Half-Shot removed the Awaiting Changes label May 5, 2017

Half-Shot self-requested a review May 5, 2017 07:53

Half-Shot reviewed May 15, 2017
View reviewed changes

non-Jedi mentioned this pull request Sep 16, 2017
Make MatrixClient asynchronous #145
Closed

non-Jedi added the Awaiting Changes label Sep 22, 2017

non-Jedi self-assigned this Sep 22, 2017

lugino-emeritus mentioned this pull request Oct 23, 2017
Adding request timeout #157
Open

non-Jedi added 2 commits October 23, 2017 21:20

Add handling for exceptions raised by requests library
99aa557
Signed-off-by: Adam Beckmeyer <adam_git@thebeckmeyers.xyz>

Add more info when MatrixHttpLibError is raised
10db977
Signed-off-by: Adam Beckmeyer <adam_git@thebeckmeyers.xyz>

non-Jedi force-pushed the handle_requests_exceptions branch from 8081c31 to 10db977Compare October 24, 2017 01:20

Construct error message inside of error instead of outside
3982688

non-Jedi merged commit 3982688 into matrix-org:masterOct 25, 2017

jahschwa mentioned this pull request Nov 30, 2017
matrix: HANDLE EXCEPTIONS OMG jahschwa/sibyl#4
Closed

Half-Shot added the Awaiting Changes label Apr 29, 2017

Half-Shot removed the Awaiting Changes label May 5, 2017

Half-Shot self-requested a review May 5, 2017 07:53

Half-Shot reviewed May 15, 2017
View reviewed changes

non-Jedi mentioned this pull request Sep 16, 2017
Make MatrixClient asynchronous #145
Closed

non-Jedi added the Awaiting Changes label Sep 22, 2017

non-Jedi self-assigned this Sep 22, 2017

lugino-emeritus mentioned this pull request Oct 23, 2017
Adding request timeout #157
Open

non-Jedi added 2 commits October 23, 2017 21:20

Add handling for exceptions raised by requests library
99aa557
Signed-off-by: Adam Beckmeyer <adam_git@thebeckmeyers.xyz>

Add more info when MatrixHttpLibError is raised
10db977
Signed-off-by: Adam Beckmeyer <adam_git@thebeckmeyers.xyz>

non-Jedi force-pushed the handle_requests_exceptions branch from 8081c31 to 10db977Compare October 24, 2017 01:20

Construct error message inside of error instead of outside
3982688

non-Jedi merged commit 3982688 into matrix-org:masterOct 25, 2017

jahschwa mentioned this pull request Nov 30, 2017
matrix: HANDLE EXCEPTIONS OMG jahschwa/sibyl#4
Closed

Half-Shot added the Awaiting Changes label Apr 29, 2017

Half-Shot removed the Awaiting Changes label May 5, 2017

Half-Shot self-requested a review May 5, 2017 07:53

Half-Shot reviewed May 15, 2017
View reviewed changes

non-Jedi mentioned this pull request Sep 16, 2017
Make MatrixClient asynchronous #145
Closed

non-Jedi added the Awaiting Changes label Sep 22, 2017

non-Jedi self-assigned this Sep 22, 2017

lugino-emeritus mentioned this pull request Oct 23, 2017
Adding request timeout #157
Open

non-Jedi added 2 commits October 23, 2017 21:20

Add handling for exceptions raised by requests library
99aa557
Signed-off-by: Adam Beckmeyer <adam_git@thebeckmeyers.xyz>

Add more info when MatrixHttpLibError is raised
10db977
Signed-off-by: Adam Beckmeyer <adam_git@thebeckmeyers.xyz>

non-Jedi force-pushed the handle_requests_exceptions branch from 8081c31 to 10db977Compare October 24, 2017 01:20

Construct error message inside of error instead of outside
3982688

non-Jedi merged commit 3982688 into matrix-org:masterOct 25, 2017

jahschwa mentioned this pull request Nov 30, 2017
matrix: HANDLE EXCEPTIONS OMG jahschwa/sibyl#4
Closed

Half-Shot added the Awaiting Changes label Apr 29, 2017

Half-Shot removed the Awaiting Changes label May 5, 2017

Half-Shot self-requested a review May 5, 2017 07:53

Half-Shot reviewed May 15, 2017
View reviewed changes

non-Jedi mentioned this pull request Sep 16, 2017
Make MatrixClient asynchronous #145
Closed

non-Jedi added the Awaiting Changes label Sep 22, 2017

non-Jedi self-assigned this Sep 22, 2017

lugino-emeritus mentioned this pull request Oct 23, 2017
Adding request timeout #157
Open

non-Jedi added 2 commits October 23, 2017 21:20

Add handling for exceptions raised by requests library
99aa557
Signed-off-by: Adam Beckmeyer <adam_git@thebeckmeyers.xyz>

Add more info when MatrixHttpLibError is raised
10db977
Signed-off-by: Adam Beckmeyer <adam_git@thebeckmeyers.xyz>

non-Jedi force-pushed the handle_requests_exceptions branch from 8081c31 to 10db977Compare October 24, 2017 01:20

Construct error message inside of error instead of outside
3982688

non-Jedi merged commit 3982688 into matrix-org:masterOct 25, 2017

jahschwa mentioned this pull request Nov 30, 2017
matrix: HANDLE EXCEPTIONS OMG jahschwa/sibyl#4
Closed

Uh oh!

Conversation

non-Jedi commented Apr 24, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matrixbot commented Apr 24, 2017

Uh oh!

Half-Shot commented Apr 25, 2017

Uh oh!

Half-Shot commented Apr 25, 2017

Uh oh!

non-Jedi commented May 4, 2017

Uh oh!

Half-ShotMay 15, 2017

Choose a reason for hiding this comment

Uh oh!

Half-Shot commented May 15, 2017

Uh oh!

4nd3r commented Oct 17, 2017

Uh oh!

lugino-emeritus commented Oct 18, 2017

Uh oh!

non-Jedi commented Oct 22, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

non-Jedi commented Apr 24, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matrixbot commented Apr 24, 2017

Uh oh!

Half-Shot commented Apr 25, 2017

Uh oh!

Half-Shot commented Apr 25, 2017

Uh oh!

non-Jedi commented May 4, 2017

Uh oh!

Half-ShotMay 15, 2017

Choose a reason for hiding this comment

Uh oh!

Half-Shot commented May 15, 2017

Uh oh!

4nd3r commented Oct 17, 2017

Uh oh!

lugino-emeritus commented Oct 18, 2017

Uh oh!

non-Jedi commented Oct 22, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

non-Jedi commented Apr 24, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matrixbot commented Apr 24, 2017

Uh oh!

Half-Shot commented Apr 25, 2017

Uh oh!

Half-Shot commented Apr 25, 2017

Uh oh!

non-Jedi commented May 4, 2017

Uh oh!

Half-ShotMay 15, 2017

Choose a reason for hiding this comment

Uh oh!

non-Jedi commented Apr 24, 2017•
edited
Loading

non-Jedi commented Apr 24, 2017•
edited
Loading

non-Jedi commented Apr 24, 2017•
edited
Loading

non-Jedi commented Apr 24, 2017•
edited
Loading