Uh oh!
There was an error while loading. Please reload this page.
Make MatrixClient asynchronous - #145
Conversation
matrixbot
commented
Sep 16, 2017
Can one of the admins verify this patch? |
3727fcd to
65d3160CompareReorg of these changes into a set of commits that actually makes sense is still coming; don't worry.
3944a4f to
4548443CompareThis PR is substantially ready. It's worked in all manual testing I've done, and
The following will be handled in a later PR.
Additionally, I have the following question that maybe @Half-Shot or, I dunno,
|
could this PR pave road to automatic (in SDK) connection retrying to HS after connection loss? or #123? |
@4nd3r this could definitely make that easier. #123 was a typo that I've now But if what you're looking for is automatic retry for all requests, yes, |
non-Jedi
commented
Sep 24, 2017
Note that this will make fixing #6 significantly easier. |
subins2000
commented
Nov 10, 2017
Any updates on this ? |
non-Jedi
commented
Nov 10, 2017
@subins2000 so kind of the state of the project right now: I'm waiting on @Half-Shot (or anyone else familiar with the layout of the project) to review #160. After that, I'm planning on doing a 0.1.0 release, and then after the release, I'll be polishing this up (getting rid of merge conflicts), adding some tests, and then getting this reviewed to potentially merge. |
non-Jedi
commented
May 14, 2018
I don't think this is the right approach any more. Would prefer to build async on top of #168 once that's merged and make it exclusive to 3.5+. |
I haven't tested this yet, and I plan on splitting out the monster commit into
actual bite-size digestible commits, but I'm not entirely sure when I'll get
back working on this again, and there's a chance someone might find it useful.
Also, this is kind of a monstrous PR in scope, so I thought I should let
@Half-Shot know that it was incoming.
I'll sign off on this properly, too once I split out that single commit; don't
worry.
Closes#127