Skip to content

build(deps-dev): update VS Code types and minimum engine to 1.136 #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
helly25 merged 3 commits into from
Sep 10, 2026
Merged

build(deps-dev): update VS Code types and minimum engine to 1.136 #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e35ddd0
build(deps-dev): bump @types/vscode in /extension
dependabot[bot] Sep 10, 2026
8c5fc57
fix: align VS Code engine with 1.136 type definitions
helly25 Sep 10, 2026
c2f09c9
Merge remote-tracking branch 'origin/main' into dependabot/npm_and_ya…
helly25 Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,19 @@ jobs:
working-directory: extension
run: npm install --no-audit --no-fund

- name: test_vscode_types_version_supported_by_engine
working-directory: extension
run: |
node <<'JS'
const assert = require('node:assert/strict');
const pkg = require('./package.json');
const version = value => value.replace(/^[~^]/, '').split('.').map(Number);
const engine = version(pkg.engines.vscode);
const types = version(pkg.devDependencies['@types/vscode']);
const difference = types.map((part, i) => part - engine[i]).find(part => part !== 0) || 0;
assert.ok(difference <= 0, '@types/vscode must not exceed engines.vscode');
JS

- name: tsc --noEmit
working-directory: extension
run: npx tsc --noEmit -p ./
Expand Down
10 changes: 5 additions & 5 deletions extension/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions extension/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"homepage": "https://mboworks.github.io/coderef/",
"bugs": "https://github.com/mboworks/coderef/issues",
"engines": {
"vscode": "^1.134.0"
"vscode": "^1.136.0"
},
"categories": ["Linters", "Other"],
"activationEvents": [
Expand Down Expand Up @@ -178,7 +178,7 @@
"@eslint/js": "^10.0.1",
"@types/mocha": "^10.0.10",
"@types/node": "^22.19.19",
"@types/vscode": "^1.134.0",
"@types/vscode": "^1.136.0",
"@typescript-eslint/eslint-plugin": "^8.60.0",
"@typescript-eslint/parser": "^8.68.0",
"@vscode/test-cli": "^0.0.15",
Expand Down