Skip to content
This repository was archived by the owner on Mar 21, 2024. It is now read-only.

DOC: Update installation guide in /docs/WSL.md - #769

Merged
Peter Hessey (peterhessey) merged 7 commits into
microsoft:mainfrom
arsenkhy:main
Aug 1, 2022
Merged

DOC: Update installation guide in /docs/WSL.md#769
Peter Hessey (peterhessey) merged 7 commits into
microsoft:mainfrom
arsenkhy:main

Conversation

@arsenkhy

@arsenkhyarsenkhy (arsenkhy) commented Jul 21, 2022

Copy link
Copy Markdown
Contributor
  • Removed long installation guide
  • Included new shorter guide to install WSL

Fixes#766

@arsenkhy
Update installation guide in WSL.md
44ac20e
- Removed long installation guide
- Included new shorter guide to install WSL
@ghost

Deleted user (ghost) commented Jul 21, 2022•
edited by ghost
Loading

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

ant0nsc
Anton Schwaighofer (ant0nsc) approved these changes Jul 22, 2022
View reviewed changes

@ant0nscAnton Schwaighofer (ant0nsc) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks very much arsenkhy (@arsenkhy) for that contribution. Some small updates requested before merging, but I'm approving already.

Comment threaddocs/WSL.md Outdated
Comment threaddocs/WSL.md
@peterhessey

Peter Hessey (peterhessey) commented Jul 22, 2022

Copy link
Copy Markdown
Contributor

LGTM once the changes Anton has requested have been added - will run workflows and approve after then :)

ant0nsc
Anton Schwaighofer (ant0nsc) reviewed Jul 23, 2022
View reviewed changes
Comment threaddocs/WSL.md Outdated
ant0nsc
Anton Schwaighofer (ant0nsc) reviewed Jul 23, 2022
View reviewed changes
Comment threaddocs/WSL.md Outdated
ant0nsc
Anton Schwaighofer (ant0nsc) reviewed Jul 23, 2022
View reviewed changes
Comment threaddocs/WSL.md Outdated
ant0nsc
Anton Schwaighofer (ant0nsc) approved these changes Jul 23, 2022
View reviewed changes

@ant0nscAnton Schwaighofer (ant0nsc) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now! I fixed minor typos.

@peterhessey

Peter Hessey (peterhessey) commented Jul 25, 2022

Copy link
Copy Markdown
Contributor

arsenkhy (@arsenkhy) you'll need to trim trailing whitespace from the file to pass CI checks (easily done using VS Code )

@arsenkhy
Trim trailing whitespace in WSL.md
b6b8fe4
- Trimmed trailing whitespace to pass the CI checks
@ant0nsc

Anton Schwaighofer (ant0nsc) commented Jul 26, 2022

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

azure-pipelinesBot commented Jul 26, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ant0nsc

Anton Schwaighofer (ant0nsc) commented Jul 26, 2022

Copy link
Copy Markdown
Contributor

arsenkhy (@arsenkhy) , I had to manually start the PR build, once that has come back as green, feel free to merge!

@peterhessey

Peter Hessey (peterhessey) commented Jul 29, 2022

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

azure-pipelinesBot commented Jul 29, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@peterhessey

Peter Hessey (peterhessey) commented Jul 29, 2022

Copy link
Copy Markdown
Contributor

Not sure why this is timing out, running again one more time and will investigate more thoroughly if it fails!

@peterhessey

Peter Hessey (peterhessey) commented Jul 29, 2022

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

azure-pipelinesBot commented Jul 29, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@peterhessey
Peter Hessey (peterhessey) merged commit 4e12cec into microsoft:mainAug 1, 2022
Fernando Pérez-García (fepegar) added a commit that referenced this pull request Aug 1, 2022
@fepegar
STYLE: Enable pre-commit autofixes
048897d
This will avoid e.g. #769 (comment).
Draft
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@ant0nscAnton Schwaighofer (ant0nsc)ant0nsc approved these changes
@peterhesseyPeter Hessey (peterhessey)peterhessey approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

WSL instructions can be updated

3 participants

@arsenkhy@peterhessey@ant0nsc