provision-image.ps1: Fix Windows Driver Kit installation

[StephanTLavavej]

In the toolset update #1451, I attempted to install the Windows Driver Kit when preparing the Virtual Machine Scale Set, needed for #1289. I wrote:

STL/azure-devops/provision-image.ps1

Lines 251 to 252 in ea156e7

	$proc = Start-Process -FilePath $installerPath -ArgumentList `
	@('/quiet', '/features', 'OptionId.WindowsDriverKitComplete') -Wait -PassThru

I didn't actually test this manually, I just verified the successful return code. On Discord, ben-craig reports that running wdksetup.exe isn't blocking, so we should run:

cmd /c start /wait wdksetup.exe /quiet /features +

[Arzaghi]

I've investigated this issue. I downloaded WDK installer and tried to run this command locally. It perfectly blocks the operation until the installation finished. -wait causes the command to block until the job is completed.
I hope I understand the reported issue correctly. 😕

[StephanTLavavej]

Thanks for verifying, Hamid Reza Arzaghi (@Arzaghi)! Yep, we just need this to block until it's done (otherwise we might shut down and snapshot the VM before the installation finishes). I should be able to update this command in the next toolset update then.

[cbezault]

Hamid Reza Arzaghi (@Arzaghi), did you mean that the existing command works or the updated cmd /c start /wait wdksetup.exe /quiet /features + works?

[Arzaghi]

Hamid Reza Arzaghi (@Arzaghi), did you mean that the existing command works or the updated cmd /c start /wait wdksetup.exe /quiet /features + works?

I mean the existing command works as expected.

[AraHaan]

I mean it might work for some but not for others it depends on their copy of the installer if it's the same or not.

or a bug in their system that might be it as well too Either way I agree we should enforce blocking it in case for some reason it does not block.