Toolset update: VS 2019 16.9 Preview 2 with Clang 11 - #1521
Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits intoDec 10, 2020
Merged
Conversation
Stephan T. Lavavej (StephanTLavavej)
requested a review
from a team
as a code owner
December 9, 2020 07:01
Curtis J Bezault (cbezault)
approved these changes
Dec 9, 2020
Curtis J Bezault (cbezault)
left a comment
Contributor
There was a problem hiding this comment.
The LGTM minus the readability regression that Michael Schellenberger Costa (@miscco) already pointed out in <random>.
* Fix microsoft#1471 by properly waiting for the Windows Driver Kit installation to finish. * Update `azure-pipelines.yml` to use the new pool `StlBuild-2020-12-08`. * Update `README.md` to mention Preview 2. (Its CMake and Ninja versions haven't changed, and we don't directly mention the Clang version.) * Update `yvals_core.h` to require Clang 11. (Note that MSVC's `_MSC_VER` is remaining `1928` for the 16.9 release.) * Remove the workaround for LLVM-37556. (We were treating it as an uncommented perma-workaround, but I remembered.) * Remove many workarounds in `P1502R1_standard_library_header_units`. * Remove the VSO-1225825 workaround in `<iterator>` and `<ranges>`. * Unrelated cleanup in `<valarray>`: `__cpp_aligned_new` implies `if constexpr`. * Update the vcpkg submodule for Boost 1.74.0. This is just their latest commit. * In `CMakeLists.txt`, require Boost 1.74.0. (This, combined with the toolset update, implies that contributors will need to `git submodule update`, clean out the `vcpkg` submodule with `git clean -x -d -f`, and then bootstrap vcpkg and build boost-math.) * Simplify conditional operators in `seed_seq::generate`. + Thanks to @AlexGuteniev for suggesting extracting `_Off` and noticing that `_Myvec[(_Kx - 1) % _Sx]` was unnecessarily complicated. Given `_Kx` in `[1, _Sx]`, then `_Kx - 1` is in `[0, _Sx - 1]`, so `% _Sx` does nothing. * Take advantage of clang-format 11. This sets `AlignOperands: AlignAfterOperator` and `IndentCaseBlocks: true`.
Stephan T. Lavavej (StephanTLavavej)
force-pushed
the
toolset_update
branch
from
December 9, 2020 20:51
7177984 to
7ab8ed2
Compare
Stephan T. Lavavej (StephanTLavavej)
requested a review
from Curtis J Bezault (cbezault)
December 9, 2020 20:51
Member
Author
|
Casey Carter (@CaseyCarter) requested isolating the automated clang-format changes in a separate commit that |
Curtis J Bezault (cbezault)
approved these changes
Dec 9, 2020
Curtis J Bezault (cbezault)
left a comment
Contributor
There was a problem hiding this comment.
The new changes look fine to me.
Casey Carter (CaseyCarter)
approved these changes
Dec 10, 2020
This was referenced Dec 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
azure-pipelines.ymlto use the new poolStlBuild-2020-12-08.StlBuild-2020-12-08-1for Minimize the size of clones in the CI #1513 to use; please be aware of this when merging.README.mdto mention Preview 2. (Its CMake and Ninja versions haven't changed, and we don't directly mention the Clang version.)yvals_core.hto require Clang 11. (Note that MSVC's_MSC_VERis remaining1928for the 16.9 release.)P1502R1_standard_library_header_units.<iterator>and<ranges>.<valarray>:__cpp_aligned_newimpliesif constexpr.CMakeLists.txt, require Boost 1.74.0. (This, combined with the toolset update, implies that contributors will need togit submodule update, clean out thevcpkgsubmodule withgit clean -x -d -f, and then bootstrap vcpkg and build boost-math.)seed_seq::generate._Offand noticing that_Myvec[(_Kx - 1) % _Sx]was unnecessarily complicated. Given_Kxin[1, _Sx], then_Kx - 1is in[0, _Sx - 1], so% _Sxdoes nothing.AlignOperands: AlignAfterOperatorandIndentCaseBlocks: true.