Implement drop_while_view - #1366
Merged
Stephan T. Lavavej (StephanTLavavej) merged 14 commits intoNov 6, 2020
Merged
Conversation
Michael Schellenberger Costa (miscco)
requested a review
from a team
as a code owner
October 13, 2020 12:59
Michael Schellenberger Costa (miscco)
force-pushed
the
drop_while
branch
from
October 13, 2020 13:00
93617eb to
45f296d
Compare
Contributor
Author
|
Addresses #39 Some day i will remember to link it to the issue |
Closed
Casey Carter (CaseyCarter)
suggested changes
Oct 23, 2020
Casey Carter (CaseyCarter)
left a comment
Contributor
There was a problem hiding this comment.
Not a real review, just correcting the problem from #1393. (At least we're consistent.)
Thanks to STLs eagle eyes Co-authored-by: Casey Carter <cartec69@gmail.com>
Michael Schellenberger Costa (miscco)
force-pushed
the
drop_while
branch
from
October 23, 2020 10:04
6a25360 to
0227d5d
Compare
Casey Carter (CaseyCarter)
self-requested a review
October 28, 2020 22:38
Casey Carter (CaseyCarter)
suggested changes
Oct 29, 2020
Casey Carter (CaseyCarter)
approved these changes
Oct 30, 2020
Stephan T. Lavavej (StephanTLavavej)
requested changes
Nov 4, 2020
Stephan T. Lavavej (StephanTLavavej)
left a comment
Member
There was a problem hiding this comment.
Looks good to me - found a small batch of simple issues.
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Nov 4, 2020
Casey Carter (CaseyCarter)
approved these changes
Nov 4, 2020
Stephan T. Lavavej (StephanTLavavej)
added a commit
to StephanTLavavej/STL
that referenced
this pull request
Nov 5, 2020
Stephan T. Lavavej (StephanTLavavej)
added a commit
to StephanTLavavej/STL
that referenced
this pull request
Nov 5, 2020
Member
|
In my view, the remaining work for C++20 ranges will continue to drop while you continue to submit these amazing PRs. 😹 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements drop_while_view.
Is solemnly swear that at some point in the future I will try to fully understand the magic Casey Carter (@CaseyCarter) has build with the Predicate and Semiregular_box stuff
Until then tests are green so ....