Implement ranges::elements_view by miscco · Pull Request #1406 · microsoft/STL

Michael Schellenberger Costa (miscco) · 2020-10-27T12:00:26Z

This is not fully functional as I has hit a roadblock, trying to understand why ranges::view<EV> breaks due to ranges::end not being available.

Casey Carter (@CaseyCarter): any ideas what is going on here?

Co-authored-by: S. B. Tam <cpplearner@outlook.com>

S. B. Tam (cpplearner) · 2020-10-27T14:20:52Z

Note that elements_view as specified in the current WD is broken. See LWG-3406.

Michael Schellenberger Costa (miscco) · 2020-10-27T15:09:38Z

Note that elements_view as specified in the current WD is broken. See LWG-3406.

Awesome, thanks for the heads up 😺

Co-authored-by: Casey Carter <cartec69@gmail.com> Co-authored-by: S. B. Tam <cpplearner@outlook.com>

Casey Carter (CaseyCarter)

Changes look good - I think we're only missing some conditional noexcept test coverage now (#1406 (comment)).

product code: * Define `iterator_concept` so the view can adapt ranges whose iterators have no `iterator_category` (This is how we've dealt with LWG-3289 elsewhere.) * Don't try to modify members of constant iterators * `_Sentinel`'s friends are not friends of `_Iterator` test: * Silence shadowing warnings by using the global `expected_keys` and `expected_values` instead of passing them to `test_one` via parameters with the same names. * Replace references to `EV` with `R` since they name the same type * Don't `forward` the same rvalue input range repeatedly

Casey Carter (CaseyCarter)

Changes look good - I think we're only missing some conditional noexcept test coverage now (#1406 (comment)).

Nice try, but you were wrong. Fixed up a few small issues and I think this is now good to go.

Stephan T. Lavavej (StephanTLavavej)

(This is a very incomplete review; I'll resume reviewing later this week)

Stephan T. Lavavej (StephanTLavavej)

This looks great, thanks! All I found were extremely minor nitpicks so I'll validate and push changes.

Stephan T. Lavavej (StephanTLavavej)

Casey Carter (@CaseyCarter) I pushed small changes after you approved.

... and resolve `common_view` vs. `elements_view` conflict by relocating `common_view` before `reverse_view` where it belongs.

Casey Carter (CaseyCarter) · 2020-11-04T02:29:12Z

Casey Carter (@CaseyCarter) I pushed small changes after you approved.

Stephan T. Lavavej (@StephanTLavavej) I pushed what look like bug changes after you approved: common_view and elements_view conflicted by being at the same point in <ranges>, which I resolved by relocating common_view before reverse_view in proper synopsis order. There are no other changes in that commit, it's just a cut-n-paste job.

Casey Carter (CaseyCarter) · 2020-11-04T02:30:00Z

Stephan T. Lavavej (@StephanTLavavej) I pushed what look like bug changes after you approved: common_view and elements_view conflicted by

Err, "big changes". This is too funny to edit in place, I'm leaving the typo for posterity ;)

Stephan T. Lavavej (StephanTLavavej) · 2020-11-06T12:09:29Z

FYI Casey Carter (@CaseyCarter), I've pushed a fix after you approved, working around an internal compiler assertion in the test that I've reduced and reported.

Stephan T. Lavavej (StephanTLavavej) · 2020-11-06T23:55:47Z

git automatically merged <ranges>; Implement drop_while_view #1366 added drop_while_view next to where this PR moved common_view. I double-checked that they're in that order (synopsis order).
Fixed trivial merge conflicts:
- In tests/std/test.lst, Implement drop_while_view #1366 added P0896R4_views_drop_while[_death] and this PR added P0896R4_views_elements. Accepted both, in that order (sorted order).
- In P0896R4_ranges_range_machinery/test.cpp, Implement drop_while_view #1366 added a line testing drop_while and this PR added a line testing elements<42>. Accepted both, in that order (sorted order).

Stephan T. Lavavej (StephanTLavavej) · 2020-11-07T00:09:51Z

Thanks for implementing these crucial elements of ranges; customers will be able to view them in VS 2019 16.9 Preview 2. 😹

Implement ranges::elements_view

2326dc4

Michael Schellenberger Costa (miscco) requested a review from a team as a code owner October 27, 2020 12:00

S. B. Tam (cpplearner) reviewed Oct 27, 2020

View reviewed changes

Comment thread stl/inc/ranges Outdated

Fix ADL issue

a6e22be

Co-authored-by: S. B. Tam <cpplearner@outlook.com>

Michael Schellenberger Costa (miscco) commented Oct 27, 2020

View reviewed changes

Comment thread stl/inc/ranges

Adopt resolution to LWG-3406

7fc23a4

Michael Schellenberger Costa (miscco) force-pushed the elements_view branch from dc93f24 to 7fc23a4 Compare October 27, 2020 15:34

Stephan T. Lavavej (StephanTLavavej) added cxx20 C++20 feature ranges C++20/23 ranges labels Oct 27, 2020

Casey Carter (CaseyCarter) self-assigned this Oct 27, 2020

Casey Carter (CaseyCarter) suggested changes Oct 28, 2020

View reviewed changes

S. B. Tam (cpplearner) reviewed Oct 28, 2020

View reviewed changes

Comment thread stl/inc/ranges Outdated

Michael Schellenberger Costa (miscco) and others added 2 commits October 28, 2020 07:47

Apply suggestions from code review

f63a85e

Co-authored-by: Casey Carter <cartec69@gmail.com> Co-authored-by: S. B. Tam <cpplearner@outlook.com>

More review comments from Casey

9fd8550

Michael Schellenberger Costa (miscco) force-pushed the elements_view branch from 7148ca2 to 9fd8550 Compare October 28, 2020 07:32

Casey Carter (CaseyCarter) suggested changes Oct 28, 2020

View reviewed changes

Michael Schellenberger Costa (miscco) mentioned this pull request Oct 28, 2020

Improve test coverage of ranges::views #1409

Open

Casey Carter (CaseyCarter) approved these changes Oct 30, 2020

View reviewed changes

Casey Carter (CaseyCarter) removed their assignment Oct 30, 2020

Michael Schellenberger Costa (miscco) and others added 3 commits October 30, 2020 22:19

Also verify views::keys and views::values

4ec4a61

views::{keys, values} are CPOs, not types

cbaff74

Add LWG issue numbers

d6bed47

Stephan T. Lavavej (StephanTLavavej) mentioned this pull request Nov 3, 2020

Fix noexcept(noexcept(is_nothrow_v)) #1417

Merged

Stephan T. Lavavej (StephanTLavavej) reviewed Nov 3, 2020

View reviewed changes

Comment thread stl/inc/ranges Outdated

Comment thread stl/inc/ranges

Comment thread stl/inc/ranges Outdated

Stephan T. Lavavej (StephanTLavavej) self-assigned this Nov 3, 2020

Michael Schellenberger Costa (miscco) and others added 2 commits November 3, 2020 19:57

Fix bug with noexcept specification

d5ad627

Rename _Iterator_base to _Category_base

dc12097

Stephan T. Lavavej (StephanTLavavej) reviewed Nov 4, 2020

View reviewed changes

Comment thread stl/inc/ranges Outdated

Comment thread tests/std/test.lst

Comment thread tests/std/tests/P0896R4_views_elements/test.cpp Outdated

Stephan T. Lavavej (StephanTLavavej) added 2 commits November 3, 2020 17:10

Merge branch 'master' into gh1406_elements_view

87da6fa

Code review feedback.

9f566e6

Stephan T. Lavavej (StephanTLavavej) approved these changes Nov 4, 2020

View reviewed changes

Stephan T. Lavavej (StephanTLavavej) removed their assignment Nov 4, 2020

Casey Carter (CaseyCarter) approved these changes Nov 4, 2020

View reviewed changes

Merge remote-tracking branch 'origin/master' into elements_view

daeb719

... and resolve `common_view` vs. `elements_view` conflict by relocating `common_view` before `reverse_view` where it belongs.

Stephan T. Lavavej (StephanTLavavej) approved these changes Nov 4, 2020

View reviewed changes

Stephan T. Lavavej (StephanTLavavej) added a commit to StephanTLavavej/STL that referenced this pull request Nov 5, 2020

microsoftGH-1406 Implement ranges::elements_view

f39eaf7

Stephan T. Lavavej (StephanTLavavej) self-assigned this Nov 5, 2020

Stephan T. Lavavej (StephanTLavavej) added a commit to StephanTLavavej/STL that referenced this pull request Nov 5, 2020

microsoftGH-1406 Implement ranges::elements_view

f0a9aa8

Work around VSO-1243263, an internal compiler assertion.

fcf52b5

Casey Carter (CaseyCarter) approved these changes Nov 6, 2020

View reviewed changes

Merge branch 'master' into gh1406

0da8675

Stephan T. Lavavej (StephanTLavavej) merged commit 7fd6501 into microsoft:master Nov 7, 2020

Stephan T. Lavavej (StephanTLavavej) mentioned this pull request Nov 7, 2020

P0896R4 <ranges> #39

Closed

Michael Schellenberger Costa (miscco) deleted the elements_view branch November 7, 2020 20:45

Uh oh!

Conversation

Michael Schellenberger Costa (miscco) commented Oct 27, 2020

Uh oh!

Uh oh!

Uh oh!

S. B. Tam (cpplearner) commented Oct 27, 2020

Uh oh!

Michael Schellenberger Costa (miscco) commented Oct 27, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Casey Carter (CaseyCarter) left a comment

Choose a reason for hiding this comment

Uh oh!

Casey Carter (CaseyCarter) left a comment

Choose a reason for hiding this comment

Uh oh!

Stephan T. Lavavej (StephanTLavavej) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Stephan T. Lavavej (StephanTLavavej) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Stephan T. Lavavej (StephanTLavavej) left a comment

Choose a reason for hiding this comment

Uh oh!

Casey Carter (CaseyCarter) commented Nov 4, 2020

Uh oh!

Casey Carter (CaseyCarter) commented Nov 4, 2020

Uh oh!

Stephan T. Lavavej (StephanTLavavej) commented Nov 6, 2020

Uh oh!

Stephan T. Lavavej (StephanTLavavej) commented Nov 6, 2020

Uh oh!

Stephan T. Lavavej (StephanTLavavej) commented Nov 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants