Fix noexcept(noexcept(is_nothrow_v)) - #1417
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit intoNov 7, 2020
Merged
Conversation
Stephan T. Lavavej (StephanTLavavej)
requested a review
from a team
as a code owner
November 3, 2020 09:21
Michael Schellenberger Costa (miscco)
approved these changes
Nov 3, 2020
Michael Schellenberger Costa (miscco)
left a comment
Contributor
There was a problem hiding this comment.
Awesome eagle eyes
Casey Carter (CaseyCarter)
approved these changes
Nov 3, 2020
Curtis J Bezault (cbezault)
approved these changes
Nov 4, 2020
Stephan T. Lavavej (StephanTLavavej)
added a commit
to StephanTLavavej/STL
that referenced
this pull request
Nov 5, 2020
Stephan T. Lavavej (StephanTLavavej)
added a commit
to StephanTLavavej/STL
that referenced
this pull request
Nov 5, 2020
Stephan T. Lavavej (StephanTLavavej)
deleted the
no_noexcept_noexcept_is_nothrow_v
branch
November 7, 2020 00:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed while reviewing #1406.
noexcept(noexcept(is_nothrow_v))is a mistake (it's alwaysnoexcept(true)). We intendednoexcept(is_nothrow_v)here.These appear to be the only occurrences that we've accumulated so far; I searched with all of my regex powers.
(It's unfortunate that the language repurposes the keyword with a different meaning here, and it's unfortunate that neither MSVC nor Clang warn about this.)