Skip to content

<format>: Merge merging_format into feature/format - #1833

Merged
Charlie Barto (barcharcraz) merged 46 commits into
microsoft:feature/formatfrom
StephanTLavavej:merge_back
Apr 13, 2021
Merged

<format>: Merge merging_format into feature/format#1833
Charlie Barto (barcharcraz) merged 46 commits into
microsoft:feature/formatfrom
StephanTLavavej:merge_back

Conversation

@StephanTLavavej

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) commented Apr 13, 2021

Copy link
Copy Markdown
Member

https://github.com/barcharcraz/STL/tree/merging_format for #1821 is now the Source Of Truth for <format>, and has accumulated dozens of additional commits. This PR merges it back into feature/format to provide a foundation for last-minute PRs.

(My merge_back branch points to the same commit as merging_format, "Big rename: _Sign to _Fmt_sign.".)

@StephanTLavavej @miscco
Code review: Adjust newlines.
817069b 
Co-authored-by: Michael Schellenberger Costa <mschellenbergercosta@googlemail.com>
@StephanTLavavej @miscco
Code review: Add const.
4dc999c 
Co-authored-by: Michael Schellenberger Costa <mschellenbergercosta@googlemail.com>
@StephanTLavavej @miscco
Code review: Add noexcept.
b68c1b4 
Co-authored-by: Michael Schellenberger Costa <mschellenbergercosta@googlemail.com>
@StephanTLavavej
Code review: Fix comment typo.
ca581bd
@StephanTLavavej @miscco
Code review: Shrink "clang-format off" region.
7a80958 
Co-authored-by: Michael Schellenberger Costa <mschellenbergercosta@googlemail.com>
@StephanTLavavej @miscco
Code review: Refactor postincrement.
4c2e42e 
Co-authored-by: Michael Schellenberger Costa <mschellenbergercosta@googlemail.com>
@StephanTLavavej @miscco
Code review: Avoid negated condition.
8953f9c 
Co-authored-by: Michael Schellenberger Costa <mschellenbergercosta@googlemail.com>
@StephanTLavavej @miscco
Code review: Early return in _Count_separators().
6d41457 
Co-authored-by: Michael Schellenberger Costa <mschellenbergercosta@googlemail.com>
@StephanTLavavej @miscco
Code review: Rearrange constexpr variables, use auto.
ff0ea8d 
This also uses 10u for clarity.

Co-authored-by: Michael Schellenberger Costa <mschellenbergercosta@googlemail.com>
@StephanTLavavej @miscco
Code review: Move comment.
97b3e6f 
Co-authored-by: Michael Schellenberger Costa <mschellenbergercosta@googlemail.com>
@StephanTLavavej
Code review: Remove perf note, compilers optimize this.
f4fa25f
@StephanTLavavej @miscco
Code review: Explicitly cast from int to unsigned long long.
6ddd77d 
Co-authored-by: Michael Schellenberger Costa <mschellenbergercosta@googlemail.com>
@StephanTLavavej
Code review: Move _Get_format_arg_type_storage_size's definition.
176c603
@StephanTLavavej
Update header-units.json.
339b67a
@StephanTLavavej
Use the plain concepts_matrix.lst when possible.
acd12a7
@StephanTLavavej
Silence "expression is always false" warning.
ddcba05
@StephanTLavavej
Refine the xlocnum workaround.
fe38474
@StephanTLavavej
Defend against macroized signbit, isnan, isinf.
f4c0d09
@StephanTLavavej
Use _THROW.
e1d0081
@StephanTLavavej
Improve locale testing.
7e0c874
@StephanTLavavej
Work around VSO-1309454 (duplicated deduction guides).
fa256ee
@StephanTLavavej
Add const.
a4a56cb
@StephanTLavavej
Add missing _WIDEN(_CharT, '.').
f71dadc
@StephanTLavavej
Add const, verify __d2s_buffered_n() etc. succeeded.
12c3581
@StephanTLavavej
Merge branch 'feature/format' into merging_format
ff016ec
@StephanTLavavej
Include more headers.
7146857
@StephanTLavavej
Rename integral to Integral to avoid shadowing the concept.
c7d570c
@StephanTLavavej
Change _Align and _Sign's underlying type to uint8_t.
bec21d4 
_Align is stored as a data member, so this matters.
@StephanTLavavej
4-bit bitfield requires strictly less than 16.
2e95f19
@StephanTLavavej
Style: Add newlines.
6aad047
@StephanTLavavej
Bugfix: Add missing typedefs.
34a4572
@StephanTLavavej
basic_format_arg::handle should store a __cdecl function pointer.
87755dc
@StephanTLavavej
basic_format_arg::handle::format is const in the Standard.
a0f0c02
@StephanTLavavej
Bugfix: visit_format_arg() must return decltype(auto).
e9e7e43
@StephanTLavavej
Style: constexpr explicit is conventional.
2cd72e6
@StephanTLavavej
Add _NODISCARD to _Find_encoded().
46e8971
@StephanTLavavej
Style: Use braces to construct temporaries.
0f4dd38
@StephanTLavavej
Style: Avoid shadowing, remove unnecessary static_cast.
f2b2a6c
@StephanTLavavej
alignas(_Index_type) _Format_arg_store::_Storage, fix comment.
95958fe
@StephanTLavavej
Improve comments.
8246a76
@StephanTLavavej
Style: Adjust spacing.
110bc90
@StephanTLavavej
Style: When declaring functions, don't mark value params as const.
d1fad54
@StephanTLavavej
Use isfinite for simplicity.
d2b6ebb
@StephanTLavavej
Style: Use _Nx for N (it's not a type, or a number of types).
0acf9ec
@StephanTLavavej
Big rename: _Align to _Fmt_align.
7bbec5b
@StephanTLavavej
Big rename: _Sign to _Fmt_sign.
a04936d
@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) added uncharted Excluded from the Status Chart format C++20/23 format labels Apr 13, 2021
@barcharcraz
Charlie Barto (barcharcraz) merged commit 8127880 into microsoft:feature/format Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@CaseyCarter Casey Carter (CaseyCarter) CaseyCarter approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

format C++20/23 format uncharted Excluded from the Status Chart

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StephanTLavavej @CaseyCarter @barcharcraz