Skip to content

<format>: Merge merging_format into feature/format #1833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Charlie Barto (barcharcraz) merged 46 commits into from
Apr 13, 2021
Merged

<format>: Merge merging_format into feature/format #1833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
817069b
Code review: Adjust newlines.
StephanTLavavej Apr 10, 2021
4dc999c
Code review: Add const.
StephanTLavavej Apr 10, 2021
b68c1b4
Code review: Add noexcept.
StephanTLavavej Apr 10, 2021
ca581bd
Code review: Fix comment typo.
StephanTLavavej Apr 10, 2021
7a80958
Code review: Shrink "clang-format off" region.
StephanTLavavej Apr 10, 2021
4c2e42e
Code review: Refactor postincrement.
StephanTLavavej Apr 10, 2021
8953f9c
Code review: Avoid negated condition.
StephanTLavavej Apr 10, 2021
6d41457
Code review: Early return in _Count_separators().
StephanTLavavej Apr 11, 2021
ff0ea8d
Code review: Rearrange constexpr variables, use auto.
StephanTLavavej Apr 11, 2021
97b3e6f
Code review: Move comment.
StephanTLavavej Apr 11, 2021
f4fa25f
Code review: Remove perf note, compilers optimize this.
StephanTLavavej Apr 11, 2021
6ddd77d
Code review: Explicitly cast from int to unsigned long long.
StephanTLavavej Apr 11, 2021
176c603
Code review: Move _Get_format_arg_type_storage_size's definition.
StephanTLavavej Apr 11, 2021
339b67a
Update header-units.json.
StephanTLavavej Apr 11, 2021
acd12a7
Use the plain concepts_matrix.lst when possible.
StephanTLavavej Apr 11, 2021
ddcba05
Silence "expression is always false" warning.
StephanTLavavej Apr 12, 2021
fe38474
Refine the xlocnum workaround.
StephanTLavavej Apr 12, 2021
f4c0d09
Defend against macroized signbit, isnan, isinf.
StephanTLavavej Apr 12, 2021
e1d0081
Use _THROW.
StephanTLavavej Apr 12, 2021
7e0c874
Improve locale testing.
StephanTLavavej Apr 12, 2021
fa256ee
Work around VSO-1309454 (duplicated deduction guides).
StephanTLavavej Apr 12, 2021
a4a56cb
Add const.
StephanTLavavej Apr 12, 2021
f71dadc
Add missing `_WIDEN(_CharT, '.')`.
StephanTLavavej Apr 12, 2021
12c3581
Add const, verify __d2s_buffered_n() etc. succeeded.
StephanTLavavej Apr 13, 2021
ff016ec
Merge branch 'feature/format' into merging_format
StephanTLavavej Apr 13, 2021
7146857
Include more headers.
StephanTLavavej Apr 13, 2021
c7d570c
Rename integral to Integral to avoid shadowing the concept.
StephanTLavavej Apr 13, 2021
bec21d4
Change _Align and _Sign's underlying type to uint8_t.
StephanTLavavej Apr 13, 2021
2e95f19
4-bit bitfield requires strictly less than 16.
StephanTLavavej Apr 13, 2021
6aad047
Style: Add newlines.
StephanTLavavej Apr 13, 2021
34a4572
Bugfix: Add missing typedefs.
StephanTLavavej Apr 13, 2021
87755dc
basic_format_arg::handle should store a __cdecl function pointer.
StephanTLavavej Apr 13, 2021
a0f0c02
basic_format_arg::handle::format is const in the Standard.
StephanTLavavej Apr 13, 2021
e9e7e43
Bugfix: visit_format_arg() must return decltype(auto).
StephanTLavavej Apr 13, 2021
2cd72e6
Style: constexpr explicit is conventional.
StephanTLavavej Apr 13, 2021
46e8971
Add _NODISCARD to _Find_encoded().
StephanTLavavej Apr 13, 2021
0f4dd38
Style: Use braces to construct temporaries.
StephanTLavavej Apr 13, 2021
f2b2a6c
Style: Avoid shadowing, remove unnecessary static_cast.
StephanTLavavej Apr 13, 2021
95958fe
alignas(_Index_type) _Format_arg_store::_Storage, fix comment.
StephanTLavavej Apr 13, 2021
8246a76
Improve comments.
StephanTLavavej Apr 13, 2021
110bc90
Style: Adjust spacing.
StephanTLavavej Apr 13, 2021
d1fad54
Style: When declaring functions, don't mark value params as const.
StephanTLavavej Apr 13, 2021
d2b6ebb
Use isfinite for simplicity.
StephanTLavavej Apr 13, 2021
0acf9ec
Style: Use _Nx for N (it's not a type, or a number of types).
StephanTLavavej Apr 13, 2021
7bbec5b
Big rename: _Align to _Fmt_align.
StephanTLavavej Apr 13, 2021
a04936d
Big rename: _Sign to _Fmt_sign.
StephanTLavavej Apr 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions stl/inc/chrono
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5187,7 +5187,7 @@ namespace chrono {
&& _Parse_precision_callbacks<_Ty, _CharT>
&& _Width_adapter_callbacks<_Ty, _CharT>
&& _Precision_adapter_callbacks<_Ty, _CharT>
&& requires(_Ty _At, basic_string_view<_CharT> _Sv, _Align _Aln) {
&& requires(_Ty _At, basic_string_view<_CharT> _Sv, _Fmt_align _Aln) {
{ _At._On_conversion_spec(_CharT{}, _CharT{}) } -> same_as<void>;
{ _At._On_lit_char(_CharT{}) } -> same_as<void>;
};
Expand All @@ -5206,7 +5206,7 @@ namespace chrono {
int _Precision = -1;
int _Dynamic_width_index = -1;
int _Dynamic_precision_index = -1;
_Align _Alignment = _Align::_None;
_Fmt_align _Alignment = _Fmt_align::_None;
uint8_t _Fill_length = 1;
// At most one codepoint (so one char32_t or four utf-8 char8_t)
_CharT _Fill[4 / sizeof(_CharT)] = {_CharT{' '}};
Expand All @@ -5221,7 +5221,7 @@ namespace chrono {
constexpr explicit _Chrono_specs_setter(_Chrono_format_specs<_CharT>& _Specs_) : _Specs(_Specs_) {}

// same as _Specs_setter
constexpr void _On_align(_Align _Aln) {
constexpr void _On_align(_Fmt_align _Aln) {
_Specs._Alignment = _Aln;
}

Expand Down Expand Up @@ -5326,7 +5326,7 @@ namespace chrono {
_THROW(format_error("Invalid format string - missing type after %"));
}

_CharT _Next_ch = *(_Begin + 1);
const _CharT _Next_ch = *(_Begin + 1);
switch (_Next_ch) {
case 'n':
_Callbacks._On_lit_char('\n');
Expand Down
Loading