LWG-3422: Issues of seed_seq's constructors - #2260
Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits intoOct 20, 2021
Merged
Conversation
Matt Stephanson (MattStephanson)
requested a review
from a team
as a code owner
October 6, 2021 04:23
Michael Schellenberger Costa (miscco)
approved these changes
Oct 6, 2021
39 tasks
Casey Carter (CaseyCarter)
left a comment
Contributor
There was a problem hiding this comment.
Just one suggestion - since I can't review code without calling out something - in addition to your and Alex Guteniev (@AlexGuteniev)'s comments.
Alex Guteniev (AlexGuteniev)
approved these changes
Oct 7, 2021
Casey Carter (CaseyCarter)
approved these changes
Oct 7, 2021
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Oct 16, 2021
Member
|
Interestingly, |
Member
|
I'm mirroring this to an MSVC-internal PR; please notify me if any further changes are pushed. |
Member
|
Thanks for implementing this LWG issue resolution! 🌱 😸 ✔️ |
AZero13 (AZero13)
pushed a commit
to AZero13/STL
that referenced
this pull request
Nov 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements LWG-3422.