Skip to content

LWG-3422: Issues of seed_seq's constructors #2260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits into from
Oct 20, 2021
Merged

LWG-3422: Issues of seed_seq's constructors #2260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e60c5c9
LWG-3422: Issues of seed_seq's constructors
MattStephanson Oct 6, 2021
eb6d4f7
code review feedback
MattStephanson Oct 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stl/inc/random
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,9 @@ class seed_seq { // standard sequence of seed values
public:
using result_type = unsigned int;

seed_seq() {}
seed_seq() noexcept {}
Comment thread
CaseyCarter marked this conversation as resolved.

template <class _Ty>
template <class _Ty, enable_if_t<is_integral_v<_Ty>, int> = 0>
seed_seq(initializer_list<_Ty> _Ilist) {
_Construct(_Ilist.begin(), _Ilist.end());
}
Expand Down
1 change: 1 addition & 0 deletions tests/std/test.lst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ tests\GH_002058_debug_iterator_race
tests\GH_002120_streambuf_seekpos_and_seekoff
tests\LWG2597_complex_branch_cut
tests\LWG3018_shared_ptr_function
tests\LWG3422_seed_seq_ctors
tests\P0019R8_atomic_ref
tests\P0024R2_parallel_algorithms_adjacent_difference
tests\P0024R2_parallel_algorithms_adjacent_find
Expand Down
4 changes: 4 additions & 0 deletions tests/std/tests/LWG3422_seed_seq_ctors/env.lst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# Copyright (c) Microsoft Corporation.
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception

RUNALL_INCLUDE ..\usual_matrix.lst
14 changes: 14 additions & 0 deletions tests/std/tests/LWG3422_seed_seq_ctors/test.compile.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// Copyright (c) Microsoft Corporation.
Comment thread
MattStephanson marked this conversation as resolved.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception

#include <random>
#include <type_traits>
#include <vector>

using namespace std;

int main() {
static_assert(is_nothrow_default_constructible_v<seed_seq>, "");
static_assert(!is_constructible_v<seed_seq, initializer_list<vector<int>::iterator>>, "");
Comment thread
MattStephanson marked this conversation as resolved.
static_assert(is_constructible_v<seed_seq, initializer_list<int>>, "");
}